Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: contrib/raid
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The test-contrib test TestRaidNode fails because of a protocol version mismatch due to mapred jars checked into src/contrib/raid/lib. Updating them with jars from a fresh makes the test pass. Seems like we should nuke that directory, and either use mvn to fetch the appropriate jars or move this particular test over to the mapred respository.

      1. hdfs-902-1.patch
        169 kB
        Eli Collins
      2. hdfs-902.patch
        2 kB
        Eli Collins

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          1h 14m 1 Eli Collins 19/Jan/10 08:59
          Open Open Patch Available Patch Available
          4d 6h 2 Eli Collins 19/Jan/10 09:00
          Patch Available Patch Available Resolved Resolved
          3d 10h 13m 1 Owen O'Malley 22/Jan/10 19:14
          Resolved Resolved Closed Closed
          214d 1h 36m 1 Tom White 24/Aug/10 21:51
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Tom White made changes -
          Fix Version/s 0.21.0 [ 12314046 ]
          Fix Version/s 0.22.0 [ 12314241 ]
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #205 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #205 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #101 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/101/)
          Move contrib/raid to MapReduce. (Eli Collins via omalley)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #101 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/101/ ) Move contrib/raid to MapReduce. (Eli Collins via omalley)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #210 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/210/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #210 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/210/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #177 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/177/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #177 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/177/ )
          Owen O'Malley made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.22.0 [ 12314241 ]
          Resolution Fixed [ 1 ]
          Hide
          Owen O'Malley added a comment -

          I committed this. Thanks, Eli!

          Show
          Owen O'Malley added a comment - I committed this. Thanks, Eli!
          Jakob Homan made changes -
          Link This issue blocks HDFS-905 [ HDFS-905 ]
          Jakob Homan made changes -
          Link This issue relates to HDFS-905 [ HDFS-905 ]
          Eli Collins made changes -
          Link This issue is related to MAPREDUCE-1388 [ MAPREDUCE-1388 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12430716/hdfs-902-1.patch
          against trunk revision 899747.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430716/hdfs-902-1.patch against trunk revision 899747. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/99/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12430704/hdfs-902.patch
          against trunk revision 899747.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430704/hdfs-902.patch against trunk revision 899747. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/195/console This message is automatically generated.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Eli Collins made changes -
          Attachment hdfs-902-1.patch [ 12430716 ]
          Hide
          Eli Collins added a comment -

          Attached patch removes the RAID module.

          Show
          Eli Collins added a comment - Attached patch removes the RAID module.
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Eli Collins made changes -
          Summary TestRaidNode fails Move RAID from HDFS to MR
          Hide
          Eli Collins added a comment -

          The contrib/raid code is implemented on MapReduce so the entire RAID module needs to be moved to the mapred repo. Filed MAPREDUCE-1388 for the mapred change.

          Show
          Eli Collins added a comment - The contrib/raid code is implemented on MapReduce so the entire RAID module needs to be moved to the mapred repo. Filed MAPREDUCE-1388 for the mapred change.
          Hide
          Owen O'Malley added a comment -

          If the dependence can not be removed, the module should be moved into MapReduce. It makes the build process much too brittle if HDFS depends on MapReduce and MapReduce depends on HDFS.

          Show
          Owen O'Malley added a comment - If the dependence can not be removed, the module should be moved into MapReduce. It makes the build process much too brittle if HDFS depends on MapReduce and MapReduce depends on HDFS.
          Hide
          Owen O'Malley added a comment -

          No, this is not the right fix. HDFS can not depend on MapReduce. Please remove the dependence completely.

          Show
          Owen O'Malley added a comment - No, this is not the right fix. HDFS can not depend on MapReduce. Please remove the dependence completely.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Eli Collins made changes -
          Attachment hdfs-902.patch [ 12430704 ]
          Hide
          Eli Collins added a comment -

          Patch attached. It removes the marped jars that are checked in and adds the appropriate ivy dependencies. test-contrib now passes on my host.

          Show
          Eli Collins added a comment - Patch attached. It removes the marped jars that are checked in and adds the appropriate ivy dependencies. test-contrib now passes on my host.
          Eli Collins made changes -
          Assignee Eli Collins [ eli ]
          Jakob Homan made changes -
          Link This issue relates to HDFS-905 [ HDFS-905 ]
          dhruba borthakur made changes -
          Field Original Value New Value
          Component/s contrib/raid [ 12313080 ]
          Eli Collins created issue -

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development