Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8825 Enhancements to Balancer
  3. HDFS-9008

Balancer#Parameters class could use a builder pattern

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha1
    • balancer & mover
    • None
    • Reviewed

    Description

      The Balancer#Parameters class is violating a few checkstyle rules.

      1. Instance variables are not privately scoped and do not have accessor methods.
      2. The Balancer#Parameter constructor has too many arguments (according to checkstyle).

      Changing this class to use the builder pattern could fix both of these style issues.

      Attachments

        1. HDFS-9008-trunk-v5.patch
          43 kB
          Chris Trezzo
        2. HDFS-9008-trunk-v4.patch
          43 kB
          Chris Trezzo
        3. HDFS-9008-trunk-v3.patch
          40 kB
          Chris Trezzo
        4. HDFS-9008-trunk-v2.patch
          40 kB
          Chris Trezzo
        5. HDFS-9008-trunk-v1.patch
          59 kB
          Chris Trezzo

        Issue Links

          is related to

          Sub-task - The sub-task of the issue HDFS-8890 Allow admin to specify which blockpools the balancer should run on

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              ctrezzo Chris Trezzo
              ctrezzo Chris Trezzo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: