Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: balancer & mover
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Balancer#Parameters class is violating a few checkstyle rules.

      1. Instance variables are not privately scoped and do not have accessor methods.
      2. The Balancer#Parameter constructor has too many arguments (according to checkstyle).

      Changing this class to use the builder pattern could fix both of these style issues.

      1. HDFS-9008-trunk-v5.patch
        43 kB
        Chris Trezzo
      2. HDFS-9008-trunk-v4.patch
        43 kB
        Chris Trezzo
      3. HDFS-9008-trunk-v3.patch
        40 kB
        Chris Trezzo
      4. HDFS-9008-trunk-v2.patch
        40 kB
        Chris Trezzo
      5. HDFS-9008-trunk-v1.patch
        59 kB
        Chris Trezzo

        Issue Links

          Activity

          Hide
          ctrezzo Chris Trezzo added a comment -

          Ming Ma v1 attached.

          Summary of the major changes in the patch:

          1. The crux of the patch is the addition of the BalancerParameters and BalancerParametersBuilder classes (located in the BalancerParameters.java file). The parsing and parameters logic moved to these classes.
          2. The majority of the changes are converting test code to use the builder class instead of the bloated parameters constructor. The CLI parsing tests were moved into their own class TestBalancerParameters. I did this because I needed to rename the test cases in any case and this makes the TestBalancer class slightly cleaner.

          Let me know what you think. All balancer tests pass locally. I will submit the patch for a QA run.

          Show
          ctrezzo Chris Trezzo added a comment - Ming Ma v1 attached. Summary of the major changes in the patch: The crux of the patch is the addition of the BalancerParameters and BalancerParametersBuilder classes (located in the BalancerParameters.java file). The parsing and parameters logic moved to these classes. The majority of the changes are converting test code to use the builder class instead of the bloated parameters constructor. The CLI parsing tests were moved into their own class TestBalancerParameters . I did this because I needed to rename the test cases in any case and this makes the TestBalancer class slightly cleaner. Let me know what you think. All balancer tests pass locally. I will submit the patch for a QA run.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 57s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 5 new or modified test files.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 9s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 22s There were no new checkstyle issues.
          -1 whitespace 0m 1s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 12s Pre-build of native portion
          -1 hdfs tests 162m 47s Tests failed in hadoop-hdfs.
              208m 28s  



          Reason Tests
          Failed unit tests hadoop.hdfs.web.TestWebHDFSOAuth2



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753900/HDFS-9008-trunk-v1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 09c64ba
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12266/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12266/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12266/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12266/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 5 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 9s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 22s There were no new checkstyle issues. -1 whitespace 0m 1s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 162m 47s Tests failed in hadoop-hdfs.     208m 28s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFSOAuth2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753900/HDFS-9008-trunk-v1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 09c64ba whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12266/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12266/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12266/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12266/console This message was automatically generated.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Ming Ma V2 attached. This patch changes a few things based on your feedback:

          1. Renames BalancerParameters#BalancerParametersBuilder class to BalancerParameters#Builder.
          2. Eliminates create method in Builder that parsed string and moves that logic back to parse method in Balancer#CLI class.
          3. Removes TestBalancerParameters class and moves those tests back to TestBalancer class.

          Let me know what you think! Thanks.

          Show
          ctrezzo Chris Trezzo added a comment - Ming Ma V2 attached. This patch changes a few things based on your feedback: Renames BalancerParameters#BalancerParametersBuilder class to BalancerParameters#Builder . Eliminates create method in Builder that parsed string and moves that logic back to parse method in Balancer#CLI class. Removes TestBalancerParameters class and moves those tests back to TestBalancer class. Let me know what you think! Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 59s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 10m 8s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 47, now 38).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 17s Pre-build of native portion
          -1 hdfs tests 161m 38s Tests failed in hadoop-hdfs.
              207m 18s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestPread
            hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
            hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754291/HDFS-9008-trunk-v2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / bcc85e3
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12320/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12320/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12320/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12320/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 8s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 47, now 38). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 161m 38s Tests failed in hadoop-hdfs.     207m 18s   Reason Tests Failed unit tests hadoop.hdfs.TestPread   hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754291/HDFS-9008-trunk-v2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bcc85e3 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12320/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12320/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12320/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12320/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Could we keep the fields final?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Could we keep the fields final?
          Hide
          ctrezzo Chris Trezzo added a comment -

          Thanks Tsz Wo Nicholas Sze. Attached is a V3 that keeps everything final. It also fixes the checkstyle warning.

          Show
          ctrezzo Chris Trezzo added a comment - Thanks Tsz Wo Nicholas Sze . Attached is a V3 that keeps everything final. It also fixes the checkstyle warning.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 52s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 8m 7s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 21s The applied patch generated 16 new checkstyle issues (total was 48, now 54).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 9s Pre-build of native portion
          -1 hdfs tests 161m 16s Tests failed in hadoop-hdfs.
              206m 39s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.web.TestWebHDFSOAuth2



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754709/HDFS-9008-trunk-v3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 16b9037
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12345/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12345/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12345/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12345/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 8m 7s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 16 new checkstyle issues (total was 48, now 54). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 161m 16s Tests failed in hadoop-hdfs.     206m 39s   Reason Tests Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.web.TestWebHDFSOAuth2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754709/HDFS-9008-trunk-v3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 16b9037 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12345/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12345/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12345/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12345/console This message was automatically generated.
          Hide
          mingma Ming Ma added a comment -

          Some minor issues:

          • It might be better to rename function createBalancerParameters to build.
          • Although it isn't used here, it is more consistent to return builder instance in each set function.
          • To simplify things, instead of having BalancerParameters.DEFAULT you can call the builder set function individually during each parameter parsing.
          • You can make BalancerParameters constructors private.
          Show
          mingma Ming Ma added a comment - Some minor issues: It might be better to rename function createBalancerParameters to build . Although it isn't used here, it is more consistent to return builder instance in each set function. To simplify things, instead of having BalancerParameters.DEFAULT you can call the builder set function individually during each parameter parsing. You can make BalancerParameters constructors private.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Ming Ma V4 attached to address your comments and the checkstyle warnings from V3.

          Show
          ctrezzo Chris Trezzo added a comment - Ming Ma V4 attached to address your comments and the checkstyle warnings from V3.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 3s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 55s There were no new javac warning messages.
          +1 javadoc 10m 15s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 19s The applied patch generated 1 new checkstyle issues (total was 47, now 38).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 11s Pre-build of native portion
          -1 hdfs tests 75m 40s Tests failed in hadoop-hdfs.
              121m 24s  



          Reason Tests
          Timed out tests org.apache.hadoop.hdfs.TestSeekBug



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755191/HDFS-9008-trunk-v4.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 7766610
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12378/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12378/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12378/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12378/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 3s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 15s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 19s The applied patch generated 1 new checkstyle issues (total was 47, now 38). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 11s Pre-build of native portion -1 hdfs tests 75m 40s Tests failed in hadoop-hdfs.     121m 24s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestSeekBug Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755191/HDFS-9008-trunk-v4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7766610 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12378/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12378/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12378/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12378/console This message was automatically generated.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Attached v5 to make BalancerParameters class final since it only has private constructors.

          Show
          ctrezzo Chris Trezzo added a comment - Attached v5 to make BalancerParameters class final since it only has private constructors.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 0s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 57s There were no new javac warning messages.
          +1 javadoc 10m 4s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 32s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 17s Pre-build of native portion
          -1 hdfs tests 67m 20s Tests failed in hadoop-hdfs.
              110m 19s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          Timed out tests org.apache.hadoop.cli.TestHDFSCLI
            org.apache.hadoop.hdfs.server.namenode.TestFileTruncate
            org.apache.hadoop.hdfs.server.namenode.TestINodeFile



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12755247/HDFS-9008-trunk-v5.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / f103a70
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12385/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12385/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12385/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 0s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 57s There were no new javac warning messages. +1 javadoc 10m 4s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 32s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 67m 20s Tests failed in hadoop-hdfs.     110m 19s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer Timed out tests org.apache.hadoop.cli.TestHDFSCLI   org.apache.hadoop.hdfs.server.namenode.TestFileTruncate   org.apache.hadoop.hdfs.server.namenode.TestINodeFile Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755247/HDFS-9008-trunk-v5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f103a70 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12385/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12385/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12385/console This message was automatically generated.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Test failures are unrelated. The patch should be good to go.

          Show
          ctrezzo Chris Trezzo added a comment - Test failures are unrelated. The patch should be good to go.
          Hide
          mingma Ming Ma added a comment -

          +1 for the latest patch. Tsz Wo Nicholas Sze do you have additional comments?

          Show
          mingma Ming Ma added a comment - +1 for the latest patch. Tsz Wo Nicholas Sze do you have additional comments?
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Just took a quick look at the patch. Everything seems fine. Please feel free to commit it.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Just took a quick look at the patch. Everything seems fine. Please feel free to commit it.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks for working on this!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks for working on this!
          Hide
          mingma Ming Ma added a comment -

          I have committed this to trunk and branch-2. Thanks Chris Trezzo for the contribution. Thanks Tsz Wo Nicholas Sze for the review.

          Show
          mingma Ming Ma added a comment - I have committed this to trunk and branch-2. Thanks Chris Trezzo for the contribution. Thanks Tsz Wo Nicholas Sze for the review.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1128 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1128/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1128 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1128/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8455 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8455/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8455 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8455/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #389 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/389/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #389 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/389/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #373 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/373/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #373 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/373/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #395 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/395/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #395 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/395/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2337 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2337/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2337 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2337/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2313 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2313/)
          HDFS-9008. Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2313 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2313/ ) HDFS-9008 . Balancer#Parameters class could use a builder pattern. (Chris Trezzo via mingma) (mingma: rev 083b44c136ea5aba660fcd1dddbb2d21513b4456) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithHANameNodes.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithNodeGroup.java

            People

            • Assignee:
              ctrezzo Chris Trezzo
              Reporter:
              ctrezzo Chris Trezzo
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development