Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: balancer & mover
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Balancer#Parameters class is violating a few checkstyle rules.

      1. Instance variables are not privately scoped and do not have accessor methods.
      2. The Balancer#Parameter constructor has too many arguments (according to checkstyle).

      Changing this class to use the builder pattern could fix both of these style issues.

        Attachments

        1. HDFS-9008-trunk-v1.patch
          59 kB
          Chris Trezzo
        2. HDFS-9008-trunk-v2.patch
          40 kB
          Chris Trezzo
        3. HDFS-9008-trunk-v3.patch
          40 kB
          Chris Trezzo
        4. HDFS-9008-trunk-v4.patch
          43 kB
          Chris Trezzo
        5. HDFS-9008-trunk-v5.patch
          43 kB
          Chris Trezzo

          Issue Links

            Activity

              People

              • Assignee:
                ctrezzo Chris Trezzo
                Reporter:
                ctrezzo Chris Trezzo
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: