Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This jira tracks implementation of delegation token and corresponding changes in Namenode and DFS Api to issue, renew and cancel delegation tokens.

      1. HDFS-899.1.patch
        42 kB
        Jitendra Nath Pandey
      2. HDFS-899.2.patch
        41 kB
        Jitendra Nath Pandey
      3. HDFS-899.3.patch
        41 kB
        Jitendra Nath Pandey
      4. HDFS-899.4.patch
        41 kB
        Jitendra Nath Pandey
      5. HDFS-899.5.patch
        42 kB
        Jitendra Nath Pandey
      6. HDFS-899.6.patch
        42 kB
        Jitendra Nath Pandey
      7. HDFS-899.7.patch
        42 kB
        Jitendra Nath Pandey
      8. HDFS-899-0_20.2.patch
        41 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Kan Zhang added a comment -

          This is a follow-on to HADOOP-6373. For design and discussions, see HADOOP-4343 and HADOOP-6373.

          Show
          Kan Zhang added a comment - This is a follow-on to HADOOP-6373 . For design and discussions, see HADOOP-4343 and HADOOP-6373 .
          Hide
          Kan Zhang added a comment -

          Some quick comments.
          1. Client should only need to deal with Token<? extends TokenIdentifier>, not any specific type like Token<DelegationTokenIdentifier>. A client can find out the type of a token by calling token.getKind().
          2. Mirroring JobToken in MapRed, the directory for Delegation Token in HDFS should be o/a/h/hdfs/security/token/
          3. See some more comments given by Owen in HADOOP-6373.
          4. IssueDate and MaxDate are set twice, first in DelegationTokenIdentifier constructor and then in secret manager.
          5. I think createToken() method in secretManger isn't necessary. Simply use the Token constructor when creating a token and keep createPassword() method as the way it is in my token2.patch in HADOOP-6373 is sufficient (sequenceNumber should be added as you did).

          Show
          Kan Zhang added a comment - Some quick comments. 1. Client should only need to deal with Token<? extends TokenIdentifier>, not any specific type like Token<DelegationTokenIdentifier>. A client can find out the type of a token by calling token.getKind(). 2. Mirroring JobToken in MapRed, the directory for Delegation Token in HDFS should be o/a/h/hdfs/security/token/ 3. See some more comments given by Owen in HADOOP-6373 . 4. IssueDate and MaxDate are set twice, first in DelegationTokenIdentifier constructor and then in secret manager. 5. I think createToken() method in secretManger isn't necessary. Simply use the Token constructor when creating a token and keep createPassword() method as the way it is in my token2.patch in HADOOP-6373 is sufficient (sequenceNumber should be added as you did).
          Hide
          Jitendra Nath Pandey added a comment -

          New patch with getUsername API in DelegationTokenIdentifier.

          Show
          Jitendra Nath Pandey added a comment - New patch with getUsername API in DelegationTokenIdentifier.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12431185/HDFS-899.4.patch
          against trunk revision 902330.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/202/testReport/
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/202/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/202/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431185/HDFS-899.4.patch against trunk revision 902330. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/202/testReport/ Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/202/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/202/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          The patch HDFS-899.4.patch contains the changes for Kan's review comments.

          Show
          Jitendra Nath Pandey added a comment - The patch HDFS-899 .4.patch contains the changes for Kan's review comments.
          Hide
          Kan Zhang added a comment -

          +1, pending Hudson.

          Show
          Kan Zhang added a comment - +1, pending Hudson.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12431333/HDFS-899.5.patch
          against trunk revision 902330.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/203/testReport/
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/203/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/203/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431333/HDFS-899.5.patch against trunk revision 902330. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/203/testReport/ Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/203/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/203/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          Submitting again HDFS-899.5.patch for hudson tests

          Show
          Jitendra Nath Pandey added a comment - Submitting again HDFS-899 .5.patch for hudson tests
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12431333/HDFS-899.5.patch
          against trunk revision 902330.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431333/HDFS-899.5.patch against trunk revision 902330. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/204/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch with javadoc & findbugs warnings fixed.

          Show
          Jitendra Nath Pandey added a comment - New patch with javadoc & findbugs warnings fixed.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12431405/HDFS-899.6.patch
          against trunk revision 902330.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431405/HDFS-899.6.patch against trunk revision 902330. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/102/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          HDFS-899.7.patch is updated because of recent commits in the trunk.

          Show
          Jitendra Nath Pandey added a comment - HDFS-899 .7.patch is updated because of recent commits in the trunk.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #179 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/179/)
          . Delegation Token Implementation

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #179 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/179/ ) . Delegation Token Implementation
          Hide
          Boris Shkolnik added a comment -

          committed, thanks Jitendra.

          Show
          Boris Shkolnik added a comment - committed, thanks Jitendra.
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #208 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #208 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/ )
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for hadoop-20 added.

          Show
          Jitendra Nath Pandey added a comment - Patch for hadoop-20 added.
          Hide
          Jitendra Nath Pandey added a comment -

          This is committed, was not resolved earlier.

          Show
          Jitendra Nath Pandey added a comment - This is committed, was not resolved earlier.

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development