Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8939

Test(S)WebHdfsFileContextMainOperations failing on branch-2

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: webhdfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      After HDFS-8180, TestWebHdfsFileContextMainOperations and TestSWebHdfsFileContextMainOperations are failing with runtime NPEs while instantiating the wrapped WebHDFSFileSystems because getDefaultPort is trying to access a conf that was never provided. In the constructor both both WebHdfs and SWebhdfs the underlying (S)WebHdfsFileSystems are instantiated in the constructor and never have a chance to have their setConf methods called:

        SWebHdfs(URI theUri, Configuration conf)
            throws IOException, URISyntaxException {
          super(theUri, new SWebHdfsFileSystem(), conf, SCHEME, false);
        }r

      The test passes on trunk because HDFS-5321 removed the call to the Configuration instance as part of getDefaultPort. HDFS-5321 was applied to branch-2 but reverted in HDFS-6632, so there's a bit of a difference in how branch-2 versus trunk handles default values (branch-2 pulls them from configs if specified, trunk just returns the hard-coded value from the constants file).

      I've fixed this behave like trunk and return just the hard-coded value, which causes the test to pass.

      There is no WebHdfsFileSystem that takes a Config, which would be another way to fix this.

      1. HDFS-8939-branch-2.001.patch
        2 kB
        Jakob Homan
      2. HDFS-8939-branch-2.002.patch
        5 kB
        Jakob Homan
      3. HDFS-8939-branch-2.003.patch
        2 kB
        Chris Nauroth
      4. HDFS-8939.003.patch
        2 kB
        Chris Nauroth

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #332 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/332/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #332 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/332/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2270 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2270/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2270 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2270/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #343 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/343/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #343 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/343/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2291 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2291/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2291 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2291/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #349 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/349/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #349 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/349/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1080 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1080/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1080 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1080/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8400 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8400/)
          HDFS-8939. Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8400 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8400/ ) HDFS-8939 . Test(S)WebHdfsFileContextMainOperations failing on branch-2. Contributed by Chris Nauroth. (jghoman: rev c2d2c1802a11e3e11a953b23b0eccbf4d107de59) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/WebHdfs.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/SWebHdfs.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          cnauroth Chris Nauroth added a comment -

          Jakob Homan, thanks for the review and commit.

          Show
          cnauroth Chris Nauroth added a comment - Jakob Homan , thanks for the review and commit.
          Hide
          jghoman Jakob Homan added a comment -

          +1. I've committed this to branch-2 and trunk. Thanks, Chris. Resolving.

          Show
          jghoman Jakob Homan added a comment - +1. I've committed this to branch-2 and trunk. Thanks, Chris. Resolving.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 47s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 51s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 21s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 13s Pre-build of native portion
          -1 hdfs tests 161m 35s Tests failed in hadoop-hdfs.
              206m 41s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestFileCreation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753851/HDFS-8939.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / afc88b3
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12258/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12258/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12258/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 21s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 161m 35s Tests failed in hadoop-hdfs.     206m 41s   Reason Tests Failed unit tests hadoop.hdfs.TestFileCreation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753851/HDFS-8939.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / afc88b3 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12258/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12258/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12258/console This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hi Jakob Homan. I'd like to clear up these test failures. I'm attaching patches that implement what I described in the last comment. Please let me know your thoughts.

          The two patch files labeled 003 are identical. They just have different file names to trigger separate Jenkins test runs for trunk and branch-2.

          Show
          cnauroth Chris Nauroth added a comment - Hi Jakob Homan . I'd like to clear up these test failures. I'm attaching patches that implement what I described in the last comment. Please let me know your thoughts. The two patch files labeled 003 are identical. They just have different file names to trigger separate Jenkins test runs for trunk and branch-2.
          Hide
          cnauroth Chris Nauroth added a comment -

          ...am getting a bit concerned about the backwards compatibility of this change...

          Yes, I agree. Navigating through the twisty history, I can see that there was concern expressed about this part of the change in the later comments of HDFS-5321. There was a specific choice to restore the behavior of making getDefaultPort respect the configuration as part of HDFS-6632, so I think we need to preserve that.

          FWIW, I don't think this is strictly correct for the contract of getDefaultPort. Other implementations hard-code the return value to its typical default instead of reading configuration. DistributedFileSystem is hard-coded to return 8020. FTPFileSystem hard-codes 21. Sometimes we have to let compatibility win though. I suppose that's why we're taking the opportunity change it on trunk.

          For these test failures on branch-2, shall we change WebHdfs and SWebHdfs to call setConf on the wrapped instance? This would require private static helper methods that do the instantiation + setConf, just to satisfy Java's rules about the call to super being the first line in the constructor. e.g.:

              super(theUri, createWebHdfsFileSystem(conf), conf, SCHEME, false);
          
            private static WebHdfsFileSystem createWebHdfsFileSystem(Configuration conf) {
              WebHdfsFileSystem fs = new WebHdfsFileSystem();
              fs.setConf(conf);
              return fs;
            }
          
          Show
          cnauroth Chris Nauroth added a comment - ...am getting a bit concerned about the backwards compatibility of this change... Yes, I agree. Navigating through the twisty history, I can see that there was concern expressed about this part of the change in the later comments of HDFS-5321 . There was a specific choice to restore the behavior of making getDefaultPort respect the configuration as part of HDFS-6632 , so I think we need to preserve that. FWIW, I don't think this is strictly correct for the contract of getDefaultPort . Other implementations hard-code the return value to its typical default instead of reading configuration. DistributedFileSystem is hard-coded to return 8020. FTPFileSystem hard-codes 21. Sometimes we have to let compatibility win though. I suppose that's why we're taking the opportunity change it on trunk. For these test failures on branch-2, shall we change WebHdfs and SWebHdfs to call setConf on the wrapped instance? This would require private static helper methods that do the instantiation + setConf , just to satisfy Java's rules about the call to super being the first line in the constructor. e.g.: super (theUri, createWebHdfsFileSystem(conf), conf, SCHEME, false ); private static WebHdfsFileSystem createWebHdfsFileSystem(Configuration conf) { WebHdfsFileSystem fs = new WebHdfsFileSystem(); fs.setConf(conf); return fs; }
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 23m 15s Pre-patch branch-2 has 4 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 6m 8s There were no new javac warning messages.
          +1 javadoc 9m 46s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 55s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 16s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 1m 52s Pre-build of native portion
          -1 hdfs tests 164m 42s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.
              216m 16s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752106/HDFS-8939-branch-2.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision branch-2 / 137bde0
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/branch-2FindbugsWarningshadoop-hdfs.html
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/branch-2FindbugsWarningshadoop-hdfs-client.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12101/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12101/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 23m 15s Pre-patch branch-2 has 4 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 6m 8s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 55s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 16s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 52s Pre-build of native portion -1 hdfs tests 164m 42s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.     216m 16s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752106/HDFS-8939-branch-2.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision branch-2 / 137bde0 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/branch-2FindbugsWarningshadoop-hdfs.html Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/branch-2FindbugsWarningshadoop-hdfs-client.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12101/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12101/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12101/console This message was automatically generated.
          Hide
          jghoman Jakob Homan added a comment -

          btw, Allen Wittenauer, any idea why Jenkins isn't picking this up to run against branch 2? I believe it's named correctly according to HowToContribute.

          Show
          jghoman Jakob Homan added a comment - btw, Allen Wittenauer , any idea why Jenkins isn't picking this up to run against branch 2? I believe it's named correctly according to HowToContribute .
          Hide
          jghoman Jakob Homan added a comment -

          Branch 2 has a test for these custom properties, which of course fails with their removal. Updated the patch to remove the test, but am getting a bit concerned about the backwards compatibility of this change. The concept of changing defaults is of course wonky and is correct to remove; not sure I'm convinced it's safe to remove it as part of branch-2, however...

          Show
          jghoman Jakob Homan added a comment - Branch 2 has a test for these custom properties, which of course fails with their removal. Updated the patch to remove the test, but am getting a bit concerned about the backwards compatibility of this change. The concept of changing defaults is of course wonky and is correct to remove; not sure I'm convinced it's safe to remove it as part of branch-2, however...
          Hide
          jghoman Jakob Homan added a comment -

          Match getDefaultPort behavior on trunk.

          Show
          jghoman Jakob Homan added a comment - Match getDefaultPort behavior on trunk.

            People

            • Assignee:
              cnauroth Chris Nauroth
              Reporter:
              jghoman Jakob Homan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development