Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8932

NPE thrown in NameNode when try to get "TotalSyncCount" metric before editLogStream initialization

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HDFS-8932.patch
      2 kB
      Surendra Singh Lilhore

      Issue Links

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2243 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2243/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2243 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2243/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2262/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2262/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/305/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/305/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #318 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/318/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #318 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/318/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1046 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1046/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1046 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1046/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #313 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/313/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #313 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/313/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8358 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8358/)
        HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8358 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8358/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        Hide
        vinayrpet Vinayakumar B added a comment -

        Oh. Okay, got it. Since patch accessed twice for null check, it changed the number

        Show
        vinayrpet Vinayakumar B added a comment - Oh. Okay, got it. Since patch accessed twice for null check, it changed the number
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Hi Vinayakumar B
        getTotalSyncCount() is introduced in HDFS-8911 which is using editLogStream,where it was not synchronized.And this issue introduced one more.

        	
        Bug type IS2_INCONSISTENT_SYNC (click for details) 
        In class org.apache.hadoop.hdfs.server.namenode.FSEditLog
        Field org.apache.hadoop.hdfs.server.namenode.FSEditLog.editLogStream
        Synchronized 78% of the time
        Unsynchronized access at FSEditLog.java:[line 1699]
        Unsynchronized access at FSEditLog.java:[line 1700]
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - Hi Vinayakumar B getTotalSyncCount() is introduced in HDFS-8911 which is using editLogStream ,where it was not synchronized.And this issue introduced one more. Bug type IS2_INCONSISTENT_SYNC (click for details) In class org.apache.hadoop.hdfs.server.namenode.FSEditLog Field org.apache.hadoop.hdfs.server.namenode.FSEditLog.editLogStream Synchronized 78% of the time Unsynchronized access at FSEditLog.java:[line 1699] Unsynchronized access at FSEditLog.java:[line 1700]
        Hide
        vinayrpet Vinayakumar B added a comment -

        I wonder how editLogStream inconsistence synchronization findbug was introduced in this Jira, as there is no change related to synchronization in the patch.
        I feel that was a existing findbug, but shown as this patch touches FSEditlog.

        Show
        vinayrpet Vinayakumar B added a comment - I wonder how editLogStream inconsistence synchronization findbug was introduced in this Jira, as there is no change related to synchronization in the patch. I feel that was a existing findbug, but shown as this patch touches FSEditlog .
        Hide
        anu Anu Engineer added a comment -

        thx for pointing it out, I just filed HDFS-8969

        Show
        anu Anu Engineer added a comment - thx for pointing it out, I just filed HDFS-8969
        Hide
        brahmareddy Brahma Reddy Battula added a comment -
        Show
        brahmareddy Brahma Reddy Battula added a comment - It appears that this jira introduces one new findbugs warnings in Jenkins. https://builds.apache.org/job/PreCommit-HDFS-Build/12138/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #293 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/293/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #293 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/293/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2250/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2250/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #306 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/306/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #306 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/306/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2231 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2231/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2231 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2231/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1034 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1034/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1034 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1034/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #301 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/301/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #301 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/301/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8345/)
        HDFS-8932. NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8345/ ) HDFS-8932 . NPE thrown in NameNode when try to get TotalSyncCount metric before editLogStream initialization. Contributed by Surendra Singh Lilhore (xyao: rev 3b00eaea256d252be3361a7d9106b88756fcb9ba) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Surendra Singh Lilhore for the contribution and all for the reviews. I've commit the fix to trunk and branch-2.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Surendra Singh Lilhore for the contribution and all for the reviews. I've commit the fix to trunk and branch-2.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Checkstyle, findbugs and test case unrelated to this patch..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Checkstyle, findbugs and test case unrelated to this patch..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 13s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 9m 7s There were no new javac warning messages.
        +1 javadoc 12m 38s There were no new javadoc warning messages.
        +1 release audit 0m 28s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 41s The applied patch generated 1 new checkstyle issues (total was 383, now 383).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 52s mvn install still works.
        +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
        -1 findbugs 3m 11s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 3m 42s Pre-build of native portion
        -1 hdfs tests 83m 16s Tests failed in hadoop-hdfs.
            137m 54s  



        Reason Tests
        FindBugs module:hadoop-hdfs
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
        Timed out tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751660/HDFS-8932.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 22de7c1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12069/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12069/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12069/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12069/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12069/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 7s There were no new javac warning messages. +1 javadoc 12m 38s There were no new javadoc warning messages. +1 release audit 0m 28s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 41s The applied patch generated 1 new checkstyle issues (total was 383, now 383). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 52s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. -1 findbugs 3m 11s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 42s Pre-build of native portion -1 hdfs tests 83m 16s Tests failed in hadoop-hdfs.     137m 54s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Timed out tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751660/HDFS-8932.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 22de7c1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12069/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12069/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12069/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12069/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12069/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Anu Engineer for review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Anu Engineer for review..
        Hide
        anu Anu Engineer added a comment -

        +1, thanks for catching this and fixing it quickly.

        Show
        anu Anu Engineer added a comment - +1, thanks for catching this and fixing it quickly.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Vinayakumar B for review

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review
        Hide
        vinayrpet Vinayakumar B added a comment -

        Waiting for jenkins

        Show
        vinayrpet Vinayakumar B added a comment - Waiting for jenkins
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1,
        Will commit soon.

        Show
        vinayrpet Vinayakumar B added a comment - +1, Will commit soon.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached patch. Please review ..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached patch. Please review ..
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -
        Caused by: java.lang.NullPointerException
        	at org.apache.hadoop.hdfs.server.namenode.FSEditLog.getTotalSyncCount(FSEditLog.java:1699)
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getTotalSyncCount(FSNamesystem.java:7292)
        
        Show
        surendrasingh Surendra Singh Lilhore added a comment - Caused by: java.lang.NullPointerException at org.apache.hadoop.hdfs.server.namenode.FSEditLog.getTotalSyncCount(FSEditLog.java:1699) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getTotalSyncCount(FSNamesystem.java:7292)

          People

          • Assignee:
            surendrasingh Surendra Singh Lilhore
            Reporter:
            surendrasingh Surendra Singh Lilhore
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development