Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8923

Add -source flag to balancer usage message

    Details

    • Hadoop Flags:
      Reviewed

      Description

      HDFS-8826 added a -source flag to the balancer, but the usage message still needs to be updated. See current usage message in trunk:

         private static final String USAGE = "Usage: hdfs balancer"
             + "\n\t[-policy <policy>]\tthe balancing policy: "
             + BalancingPolicy.Node.INSTANCE.getName() + " or "
             + BalancingPolicy.Pool.INSTANCE.getName()
             + "\n\t[-threshold <threshold>]\tPercentage of disk capacity"
             + "\n\t[-exclude [-f <hosts-file> | <comma-separated list of hosts>]]"
             + "\tExcludes the specified datanodes."
             + "\n\t[-include [-f <hosts-file> | <comma-separated list of hosts>]]"
             + "\tIncludes only the specified datanodes."
             + "\n\t[-idleiterations <idleiterations>]"
             + "\tNumber of consecutive idle iterations (-1 for Infinite) before "
             + "exit."
             + "\n\t[-runDuringUpgrade]"
             + "\tWhether to run the balancer during an ongoing HDFS upgrade."
             + "This is usually not desired since it will not affect used space "
             + "on over-utilized machines.";
      
      1. HDFS-8923-trunk-v4.patch
        2 kB
        Chris Trezzo
      2. HDFS-8923-trunk-v3.patch
        2 kB
        Chris Trezzo
      3. HDFS-8923-trunk-v2.patch
        2 kB
        Chris Trezzo
      4. HDFS-8923-trunk-v1.patch
        0.9 kB
        Chris Trezzo

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9328 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9328/)
          HDFS-8923. Add -source flag to balancer usage message. Contributed by (szetszwo: rev 46f77902368e5d8cc2d3e24de735b98a83ad46e1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
            Move HDFS-8923 to Release 2.8.0 in CHANGES.txt. (szetszwo: rev 748b6c07fe29bf52510d2e84d82fcbef7f1bb35c)
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9328 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9328/ ) HDFS-8923 . Add -source flag to balancer usage message. Contributed by (szetszwo: rev 46f77902368e5d8cc2d3e24de735b98a83ad46e1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java Move HDFS-8923 to Release 2.8.0 in CHANGES.txt. (szetszwo: rev 748b6c07fe29bf52510d2e84d82fcbef7f1bb35c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Chris!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Chris!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 14s trunk passed
          +1 compile 0m 53s trunk passed with JDK v1.8.0_72
          +1 compile 0m 51s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 28s trunk passed
          +1 javadoc 1m 21s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 52s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 56s the patch passed
          +1 compile 0m 51s the patch passed with JDK v1.8.0_72
          +1 javac 0m 51s the patch passed
          +1 compile 0m 43s the patch passed with JDK v1.7.0_95
          +1 javac 0m 43s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 29s the patch passed
          +1 javadoc 1m 22s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 56s the patch passed with JDK v1.7.0_95
          -1 unit 69m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 60m 49s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          159m 1s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestFileAppend
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788563/HDFS-8923-trunk-v4.patch
          JIRA Issue HDFS-8923
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 88faa7e5796c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8ab7658
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14537/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14537/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 14s trunk passed +1 compile 0m 53s trunk passed with JDK v1.8.0_72 +1 compile 0m 51s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 28s trunk passed +1 javadoc 1m 21s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 56s the patch passed +1 compile 0m 51s the patch passed with JDK v1.8.0_72 +1 javac 0m 51s the patch passed +1 compile 0m 43s the patch passed with JDK v1.7.0_95 +1 javac 0m 43s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 29s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_95 -1 unit 69m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 60m 49s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 159m 1s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestFileAppend   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788563/HDFS-8923-trunk-v4.patch JIRA Issue HDFS-8923 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 88faa7e5796c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ab7658 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14537/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14537/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14537/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Tsz Wo Nicholas Sze sounds good! Attached is v4.

          Show
          ctrezzo Chris Trezzo added a comment - Tsz Wo Nicholas Sze sounds good! Attached is v4.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -
                 + "\n\t[-include [-f <hosts-file> | <comma-separated list of hosts>]]"
                 + "\tIncludes only the specified datanodes."
          +      + "\n\t[-source [-f <hosts-file> | <comma-separated list of hosts>]]"
          +      + "\tIncludes only the specified datanodes when picking source nodes."
          

          Let's don't use "Includes" since it may be confused with -include. How about "Pick only the specified datanodes as source nodes"?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - + "\n\t[-include [-f <hosts-file> | <comma-separated list of hosts>]]" + "\tIncludes only the specified datanodes." + + "\n\t[-source [-f <hosts-file> | <comma-separated list of hosts>]]" + + "\tIncludes only the specified datanodes when picking source nodes." Let's don't use "Includes" since it may be confused with -include. How about "Pick only the specified datanodes as source nodes"?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 6m 36s trunk passed
          +1 compile 0m 46s trunk passed with JDK v1.8.0_66
          +1 compile 0m 43s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 2m 0s trunk passed
          +1 javadoc 1m 9s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.8.0_66
          +1 javac 0m 40s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.7.0_91
          +1 javac 0m 37s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 48s the patch passed with JDK v1.7.0_91
          -1 unit 55m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 52m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          133m 32s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
            hadoop.hdfs.server.datanode.TestBlockScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786118/HDFS-8923-trunk-v3.patch
          JIRA Issue HDFS-8923
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 875d1032f6e1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7badf15
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14375/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14375/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 2m 0s trunk passed +1 javadoc 1m 9s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_66 +1 javac 0m 40s the patch passed +1 compile 0m 37s the patch passed with JDK v1.7.0_91 +1 javac 0m 37s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_91 -1 unit 55m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 52m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 133m 32s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786118/HDFS-8923-trunk-v3.patch JIRA Issue HDFS-8923 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 875d1032f6e1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7badf15 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14375/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14375/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14375/console This message was automatically generated.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Thanks Xiaoyu Yao! Attached is a rebased v3 of the patch.

          Show
          ctrezzo Chris Trezzo added a comment - Thanks Xiaoyu Yao ! Attached is a rebased v3 of the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 4s HDFS-8923 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12753818/HDFS-8923-trunk-v2.patch
          JIRA Issue HDFS-8923
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14372/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 4s HDFS-8923 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12753818/HDFS-8923-trunk-v2.patch JIRA Issue HDFS-8923 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14372/console This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Chris Trezzo, the patch v2 looks good to me. Can you rebase the patch to trunk?

          Show
          xyao Xiaoyu Yao added a comment - Chris Trezzo , the patch v2 looks good to me. Can you rebase the patch to trunk?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 21m 11s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 3s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 5s Site still builds.
          +1 checkstyle 1m 20s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 14s Pre-build of native portion
          -1 hdfs tests 192m 18s Tests failed in hadoop-hdfs.
              244m 14s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.TestNameEditsConfigs
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.TestBlockReaderFactory



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753818/HDFS-8923-trunk-v2.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 7d6687f
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12253/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12253/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12253/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 11s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 3s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 site 3m 5s Site still builds. +1 checkstyle 1m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 192m 18s Tests failed in hadoop-hdfs.     244m 14s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestBlockReaderFactory Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753818/HDFS-8923-trunk-v2.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 7d6687f hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12253/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12253/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12253/console This message was automatically generated.
          Hide
          ctrezzo Chris Trezzo added a comment -

          Thanks Tsz Wo Nicholas Sze. Attached is V2 with the markdown update as well.

          Show
          ctrezzo Chris Trezzo added a comment - Thanks Tsz Wo Nicholas Sze . Attached is V2 with the markdown update as well.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          BTW, thanks for working on this. It is a good catch!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - BTW, thanks for working on this. It is a good catch!
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          We should also update hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md .

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - We should also update hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md .
          Hide
          ctrezzo Chris Trezzo added a comment -

          Test failure is unrelated. Patch should be good to go.

          Show
          ctrezzo Chris Trezzo added a comment - Test failure is unrelated. Patch should be good to go.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 35s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 32s There were no new javac warning messages.
          +1 javadoc 10m 31s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 32s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 2m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 20s Pre-build of native portion
          -1 hdfs tests 93m 2s Tests failed in hadoop-hdfs.
              140m 52s  



          Reason Tests
          Timed out tests org.apache.hadoop.hdfs.TestPread



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751312/HDFS-8923-trunk-v1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3aac475
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12045/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12045/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12045/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 32s There were no new javac warning messages. +1 javadoc 10m 31s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 32s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 20s Pre-build of native portion -1 hdfs tests 93m 2s Tests failed in hadoop-hdfs.     140m 52s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestPread Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751312/HDFS-8923-trunk-v1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3aac475 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12045/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12045/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12045/console This message was automatically generated.
          Hide
          ctrezzo Chris Trezzo added a comment -
          Show
          ctrezzo Chris Trezzo added a comment - Tsz Wo Nicholas Sze Arpit Agarwal V1 patch attached.

            People

            • Assignee:
              ctrezzo Chris Trezzo
              Reporter:
              ctrezzo Chris Trezzo
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development