Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8879

Quota by storage type usage incorrectly initialized upon namenode restart

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This was found by Kihwal Lee as part of HDFS-8865 work in this comment.

      The unit test testQuotaByStorageTypePersistenceInFsImage/testQuotaByStorageTypePersistenceInFsEdit failed to detect this because they were using an obsolete
      FsDirectory instance. Once added the highlighted line below, the issue can be reproed.

      ++++>fsdir = cluster.getNamesystem().getFSDirectory();
      INode testDirNodeAfterNNRestart = fsdir.getINode4Write(testDir.toString());
      

        Issue Links

          Activity

          Hide
          xyao Xiaoyu Yao added a comment -

          Attach a patch that fix the issue and unit tests.

          Show
          xyao Xiaoyu Yao added a comment - Attach a patch that fix the issue and unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 50s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 14s There were no new javac warning messages.
          +1 javadoc 10m 20s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 31s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 23s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 9s Pre-build of native portion
          -1 hdfs tests 184m 27s Tests failed in hadoop-hdfs.
              230m 27s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          Timed out tests org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12749601/HDFS-8879.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8f73bdd
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11953/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11953/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11953/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 14s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 31s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 184m 27s Tests failed in hadoop-hdfs.     230m 27s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749601/HDFS-8879.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8f73bdd hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11953/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11953/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11953/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1

          The test failures look unrelated.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 The test failures look unrelated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Arpit for the review. I will hold off commit until tomorrow in case Kihwal Lee has additional feedback.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Arpit for the review. I will hold off commit until tomorrow in case Kihwal Lee has additional feedback.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks all for the review. I've checked in the fix to trunk and branch-2.

          Show
          xyao Xiaoyu Yao added a comment - Thanks all for the review. I've checked in the fix to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8289 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8289/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8289 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8289/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1016 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1016/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1016 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1016/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2213 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2213/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2213 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2213/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #275 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/275/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #275 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/275/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #283 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/283/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #283 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/283/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2232/)
          HDFS-8879. Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2232/ ) HDFS-8879 . Quota by storage type usage incorrectly initialized upon namenode restart. Contributed by Xiaoyu Yao. (xyao: rev 3e715a4f4c46bcd8b3054cb0566e526c46bd5d66) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestQuotaByStorageType.java
          Hide
          kihwal Kihwal Lee added a comment -

          Cherry-picked the fix to branch-2.7.

          Show
          kihwal Kihwal Lee added a comment - Cherry-picked the fix to branch-2.7.

            People

            • Assignee:
              xyao Xiaoyu Yao
              Reporter:
              kihwal Kihwal Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development