Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      LeaseManager#countPath loops over all existing lease holders to compute the pending lease count. We can just track the pending leased files so it runs in constant time.

      1. HDFS-8856.04.patch
        9 kB
        Arpit Agarwal
      2. HDFS-8856.03.patch
        8 kB
        Arpit Agarwal
      3. HDFS-8856.02.patch
        8 kB
        Arpit Agarwal
      4. HDFS-8856.01.patch
        10 kB
        Arpit Agarwal

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Also remove redundant call to getNumUnderConstructionBlocks on startup.

        Show
        arpitagarwal Arpit Agarwal added a comment - Also remove redundant call to getNumUnderConstructionBlocks on startup.
        Hide
        hitliuyi Yi Liu added a comment -

        +1, thanks Arpit.

        I found a nit in getCompleteBlocksTotal, if you can modify it too, that would be nice.

        readLock();
        numUCBlocks = leaseManager.getNumUnderConstructionBlocks();
        

        It's better to put readLock below

        Show
        hitliuyi Yi Liu added a comment - +1, thanks Arpit. I found a nit in getCompleteBlocksTotal , if you can modify it too, that would be nice. readLock(); numUCBlocks = leaseManager.getNumUnderConstructionBlocks(); It's better to put readLock below
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 10s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 21s There were no new javac warning messages.
        +1 javadoc 10m 33s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 36s The applied patch generated 2 new checkstyle issues (total was 296, now 293).
        -1 whitespace 0m 0s The patch has 12 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 25s mvn install still works.
        +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
        +1 findbugs 2m 43s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 10s Pre-build of native portion
        -1 hdfs tests 166m 27s Tests failed in hadoop-hdfs.
            214m 30s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
        Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
          org.apache.hadoop.hdfs.server.namenode.TestFsck
          org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12748780/HDFS-8856.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d540374
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11902/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11902/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11902/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11902/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11902/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 21s There were no new javac warning messages. +1 javadoc 10m 33s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 36s The applied patch generated 2 new checkstyle issues (total was 296, now 293). -1 whitespace 0m 0s The patch has 12 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 2m 43s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 10s Pre-build of native portion -1 hdfs tests 166m 27s Tests failed in hadoop-hdfs.     214m 30s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   org.apache.hadoop.hdfs.server.namenode.TestFsck   org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748780/HDFS-8856.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d540374 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11902/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11902/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11902/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11902/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11902/console This message was automatically generated.
        Hide
        wheat9 Haohui Mai added a comment -

        Is it possible to return leasesById.size() instead?

        Show
        wheat9 Haohui Mai added a comment - Is it possible to return leasesById.size() instead?
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the reviews. v2 patch attached.

        Is it possible to return leasesById.size() instead?

        Fixed.

        I found a nit in getCompleteBlocksTotal, if you can modify it too, that would be nice.

        Looks risky, the lock ensures consistent state for each INodeFile.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the reviews. v2 patch attached. Is it possible to return leasesById.size() instead? Fixed. I found a nit in getCompleteBlocksTotal, if you can modify it too, that would be nice. Looks risky, the lock ensures consistent state for each INodeFile.
        Hide
        xyao Xiaoyu Yao added a comment -

        Patch v2 looks good to me. +1
        One nit: you can use a timeout rule that applies to all cases instead of adding them individually.

        @Rule
        publicTimeout timeout=new Timeout(300000);
        
        Show
        xyao Xiaoyu Yao added a comment - Patch v2 looks good to me. +1 One nit: you can use a timeout rule that applies to all cases instead of adding them individually. @Rule publicTimeout timeout= new Timeout(300000);
        Hide
        wheat9 Haohui Mai added a comment -
        +    private Collection<Long> getFiles() { 
        +      return Collections.unmodifiableCollection(files);
        +    }
        

        Just wondering whether it is necessary?

        -  @Test (timeout=1000)
        +  @Test (timeout=300000)
        

        Are you seeing timeouts? I would be surprised as the tests operate on mocked objects and should be really quick.

        Show
        wheat9 Haohui Mai added a comment - + private Collection< Long > getFiles() { + return Collections.unmodifiableCollection(files); + } Just wondering whether it is necessary? - @Test (timeout=1000) + @Test (timeout=300000) Are you seeing timeouts? I would be surprised as the tests operate on mocked objects and should be really quick.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        I don't see a good reason to return a modifiable reference to the internal list.

        One nit: you can use a timeout rule that applies to all cases instead of adding them individually.

        Done in v3 patch.

        Show
        arpitagarwal Arpit Agarwal added a comment - I don't see a good reason to return a modifiable reference to the internal list. One nit: you can use a timeout rule that applies to all cases instead of adding them individually. Done in v3 patch.
        Hide
        wheat9 Haohui Mai added a comment -

        +1 pending jenkins.

        Show
        wheat9 Haohui Mai added a comment - +1 pending jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 45s There were no new javac warning messages.
        +1 javadoc 9m 44s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 25s The applied patch generated 2 new checkstyle issues (total was 296, now 293).
        -1 whitespace 0m 0s The patch has 12 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 4s Pre-build of native portion
        +1 hdfs tests 162m 47s Tests passed in hadoop-hdfs.
            207m 8s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12748887/HDFS-8856.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4ab49a4
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11908/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11908/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11908/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11908/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11908/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 25s The applied patch generated 2 new checkstyle issues (total was 296, now 293). -1 whitespace 0m 0s The patch has 12 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 4s Pre-build of native portion +1 hdfs tests 162m 47s Tests passed in hadoop-hdfs.     207m 8s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748887/HDFS-8856.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4ab49a4 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11908/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11908/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11908/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11908/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11908/console This message was automatically generated.
        Hide
        hitliuyi Yi Liu added a comment - - edited

        Looks risky, the lock ensures consistent state for each INodeFile.

        Arpit, sorry, I mean to put following in the try .. finally closure, ideally it will not throw exception in real case, but from the implementation, it contains and could cause dead lock.

        numUCBlocks = leaseManager.getNumUnderConstructionBlocks();
        
        Show
        hitliuyi Yi Liu added a comment - - edited Looks risky, the lock ensures consistent state for each INodeFile. Arpit, sorry, I mean to put following in the try .. finally closure, ideally it will not throw exception in real case, but from the implementation, it contains and could cause dead lock. numUCBlocks = leaseManager.getNumUnderConstructionBlocks();
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 53s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 13s There were no new javac warning messages.
        +1 javadoc 9m 54s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 28s The applied patch generated 2 new checkstyle issues (total was 296, now 293).
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 10s Pre-build of native portion
        -1 hdfs tests 162m 14s Tests failed in hadoop-hdfs.
            208m 48s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12748920/HDFS-8856.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ba2313d
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11911/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11911/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11911/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11911/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11911/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 53s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 13s There were no new javac warning messages. +1 javadoc 9m 54s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 28s The applied patch generated 2 new checkstyle issues (total was 296, now 293). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 10s Pre-build of native portion -1 hdfs tests 162m 14s Tests failed in hadoop-hdfs.     208m 48s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748920/HDFS-8856.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ba2313d checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11911/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11911/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11911/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11911/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11911/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the clarification Yi Liu. Looks like the bug around for a while, v4 patch updates getCompleteBlocksTotal to fix it. Also fixed the checkstyle issue.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the clarification Yi Liu . Looks like the bug around for a while, v4 patch updates getCompleteBlocksTotal to fix it. Also fixed the checkstyle issue.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 18s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 298, now 294).
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 4s Pre-build of native portion
        +1 hdfs tests 165m 21s Tests passed in hadoop-hdfs.
            209m 15s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749103/HDFS-8856.04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8572a5a
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11922/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11922/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11922/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11922/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11922/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 298, now 294). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 4s Pre-build of native portion +1 hdfs tests 165m 21s Tests passed in hadoop-hdfs.     209m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749103/HDFS-8856.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8572a5a checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11922/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11922/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11922/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11922/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11922/console This message was automatically generated.
        Hide
        hitliuyi Yi Liu added a comment -

        Thanks Arpit Agarwal, +1.

        Show
        hitliuyi Yi Liu added a comment - Thanks Arpit Agarwal , +1.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The checkstyle issue is unrelated to the patch.

        Thank you for the reviews all. Committed for 2.8.0.

        Show
        arpitagarwal Arpit Agarwal added a comment - The checkstyle issue is unrelated to the patch. Thank you for the reviews all. Committed for 2.8.0.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8276 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8276/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8276 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8276/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #280 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/280/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #280 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/280/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1010 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1010/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1010 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1010/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/269/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/269/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #277 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/277/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #277 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/277/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2226 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2226/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2226 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2226/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2207 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2207/)
        HDFS-8856. Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2207 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2207/ ) HDFS-8856 . Make LeaseManager#countPath O(1). (Contributed by Arpit Agarwal) (arp: rev 6d4eee718a3fe1450a627128eb94728011bd9b68) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestLeaseManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

          People

          • Assignee:
            arpitagarwal Arpit Agarwal
            Reporter:
            arpitagarwal Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development