Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8846

Add a unit test for INotify functionality across a layout version upgrade

    Details

    • Target Version/s:

      Description

      Per discussion under HDFS-8480, we should create some edit log files with old layout version, to test whether they can be correctly handled in upgrades.

      1. HDFS-8846.00.patch
        7 kB
        Zhe Zhang
      2. HDFS-8846.01.patch
        25 kB
        Zhe Zhang
      3. HDFS-8846.02.patch
        25 kB
        Zhe Zhang
      4. HDFS-8846.03.patch
        28 kB
        Zhe Zhang
      5. HDFS-8846-branch-2.6.1.txt
        13 kB
        Vinod Kumar Vavilapalli

        Activity

        Hide
        zhz Zhe Zhang added a comment -

        Ming Ma Colin P. McCabe Let me know if the below looks a reasonable plan:

        1. Start a local 2.5.2 cluster (it's just the oldest version shown on Apache website, let me know if the version is appropriate)
        2. Add the following Ops:
          • Create a directory
          • Copy ~10 local files into the dir
          • Delete a few copied files
        3. Add the generated edit log files in hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/old-edits
        4. Copy over old edits in TestDFSUpgrade#testPreserveEditLogs

        Thanks

        Show
        zhz Zhe Zhang added a comment - Ming Ma Colin P. McCabe Let me know if the below looks a reasonable plan: Start a local 2.5.2 cluster (it's just the oldest version shown on Apache website, let me know if the version is appropriate) Add the following Ops: Create a directory Copy ~10 local files into the dir Delete a few copied files Add the generated edit log files in hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/old-edits Copy over old edits in TestDFSUpgrade#testPreserveEditLogs Thanks
        Hide
        mingma Ming Ma added a comment -

        2.5 should be fine. Although people still use 2.3 or 2.4, this test tries to verify old edits can be replayed during upgrade; not necessarily compatibilities around edit log formats.

        If you unpack the existing fsimage tgz files under hadoop-hdfs-project/hadoop-hdfs/src/test/resources, they have the proper namenode dir contents that include VERSION file, etc.. Just wonder if you are going to create something similar except that the fsimage is empty.

        Show
        mingma Ming Ma added a comment - 2.5 should be fine. Although people still use 2.3 or 2.4, this test tries to verify old edits can be replayed during upgrade; not necessarily compatibilities around edit log formats. If you unpack the existing fsimage tgz files under hadoop-hdfs-project/hadoop-hdfs/src/test/resources , they have the proper namenode dir contents that include VERSION file, etc.. Just wonder if you are going to create something similar except that the fsimage is empty.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Ming for the feedback!

        I was planning to only add edit log files. But I think creating an entire NN dir structure with old layout version is a good idea. It could support a broader range of upgrade tests.

        Show
        zhz Zhe Zhang added a comment - Thanks Ming for the feedback! I was planning to only add edit log files. But I think creating an entire NN dir structure with old layout version is a good idea. It could support a broader range of upgrade tests.
        Hide
        zhz Zhe Zhang added a comment -

        The patch does the following:

        1. Added a packed /dfs dir. I basically started a 2.5.2 local cluster, created /input and 200 sub directories under it. The inotify test in this patch only uses the create event of /input.
        2. Moved testPreserveEditLogs to TestDFSUpgradeFromImage. Similar to other tests in the class, it unpacks the image and tries to upgrade.
        Show
        zhz Zhe Zhang added a comment - The patch does the following: Added a packed /dfs dir. I basically started a 2.5.2 local cluster, created /input and 200 sub directories under it. The inotify test in this patch only uses the create event of /input . Moved testPreserveEditLogs to TestDFSUpgradeFromImage . Similar to other tests in the class, it unpacks the image and tries to upgrade.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Hi Zhe Zhang,

        It seems that you left out the binary changes:

        diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        new file mode 100644
        index 0000000..2aaab18
        Binary files /dev/null and b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz differ
        

        You should create the patch with --binary so that these are included

        Show
        cmccabe Colin P. McCabe added a comment - Hi Zhe Zhang , It seems that you left out the binary changes: diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz new file mode 100644 index 0000000..2aaab18 Binary files /dev/ null and b/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz differ You should create the patch with --binary so that these are included
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the good catch Colin! Updating the patch with the binary diff.

        Show
        zhz Zhe Zhang added a comment - Thanks for the good catch Colin! Updating the patch with the binary diff.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 6m 31s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 8m 14s There were no new javac warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 46s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 6s Pre-build of native portion
        -1 hdfs tests 193m 14s Tests failed in hadoop-hdfs.
            215m 13s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
          hadoop.hdfs.TestHDFSTrash
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750924/HDFS-8846.01.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 71566e2
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12015/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12015/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12015/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12015/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 6m 31s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 14s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 46s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 6s Pre-build of native portion -1 hdfs tests 193m 14s Tests failed in hadoop-hdfs.     215m 13s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger   hadoop.hdfs.TestHDFSTrash Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750924/HDFS-8846.01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 71566e2 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12015/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12015/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12015/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12015/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 6m 4s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 51s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 38s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 2m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 6s Pre-build of native portion
        -1 hdfs tests 63m 31s Tests failed in hadoop-hdfs.
            84m 12s  



        Reason Tests
        Failed unit tests hadoop.fs.TestEnhancedByteBufferAccess
        Timed out tests org.apache.hadoop.fs.TestFcHdfsSetUMask
          org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750924/HDFS-8846.01.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 71566e2
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12019/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12019/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12019/testReport/
        Java 1.7.0_55
        uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12019/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 6m 4s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 38s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 2m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 6s Pre-build of native portion -1 hdfs tests 63m 31s Tests failed in hadoop-hdfs.     84m 12s   Reason Tests Failed unit tests hadoop.fs.TestEnhancedByteBufferAccess Timed out tests org.apache.hadoop.fs.TestFcHdfsSetUMask   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750924/HDFS-8846.01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 71566e2 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12019/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12019/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12019/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12019/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Updating the patch to fix white space issue and removing unused imports in TestDFSUpgrade.

        The reported test failures are unrelated and pass locally.

        One thing I'm not sure about is whether I should shrink the binary file by only containing 1 (or 2~3) edit log. Right now it has ~200 edit logs.

        Show
        zhz Zhe Zhang added a comment - Updating the patch to fix white space issue and removing unused imports in TestDFSUpgrade . The reported test failures are unrelated and pass locally. One thing I'm not sure about is whether I should shrink the binary file by only containing 1 (or 2~3) edit log. Right now it has ~200 edit logs.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 6m 36s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 9m 6s There were no new javac warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 42s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 2m 37s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 14s Pre-build of native portion
        -1 hdfs tests 190m 11s Tests failed in hadoop-hdfs.
            214m 26s  



        Reason Tests
        Failed unit tests hadoop.fs.viewfs.TestViewFsWithAcls
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
          hadoop.fs.TestResolveHdfsSymlink
          hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
          hadoop.fs.TestWebHdfsFileContextMainOperations
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.fs.TestSWebHdfsFileContextMainOperations
          hadoop.fs.shell.TestHdfsTextCommand
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750979/HDFS-8846.02.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 71566e2
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12022/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12022/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12022/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 6m 36s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 9m 6s There were no new javac warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 42s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 2m 37s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 14s Pre-build of native portion -1 hdfs tests 190m 11s Tests failed in hadoop-hdfs.     214m 26s   Reason Tests Failed unit tests hadoop.fs.viewfs.TestViewFsWithAcls   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.fs.TestResolveHdfsSymlink   hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger   hadoop.fs.TestWebHdfsFileContextMainOperations   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.fs.TestSWebHdfsFileContextMainOperations   hadoop.fs.shell.TestHdfsTextCommand   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750979/HDFS-8846.02.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 71566e2 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12022/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12022/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12022/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        The reported test failures are unrelated (this change itself is test-only), and they all pass locally.

        Show
        zhz Zhe Zhang added a comment - The reported test failures are unrelated (this change itself is test-only), and they all pass locally.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Looks good overall! Can we test reading a few different events rather than just the CreateEvent? And perhaps also test reading by transaction ID. (i.e. if we poll a transaction ID that's too high, we get nothing... if we look for one that exists in the old edit logs, we start right there). +1 once that's addressed

        Show
        cmccabe Colin P. McCabe added a comment - Looks good overall! Can we test reading a few different events rather than just the CreateEvent? And perhaps also test reading by transaction ID. (i.e. if we poll a transaction ID that's too high, we get nothing... if we look for one that exists in the old edit logs, we start right there). +1 once that's addressed
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Colin for the suggestion! Updating the patch with more comprehensive checking of returned edits.

        Show
        zhz Zhe Zhang added a comment - Thanks Colin for the suggestion! Updating the patch with more comprehensive checking of returned edits.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 5m 52s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 31s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 30s The patch built with eclipse:eclipse.
        -1 findbugs 2m 30s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 1m 13s Pre-build of native portion
        -1 hdfs tests 162m 7s Tests failed in hadoop-hdfs.
            182m 27s  



        Reason Tests
        FindBugs module:hadoop-hdfs
        Failed unit tests hadoop.hdfs.TestPread
          hadoop.hdfs.TestLeaseRecovery2
          hadoop.hdfs.TestReplaceDatanodeOnFailure



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751824/HDFS-8846.03.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / b5ce87f
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12092/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12092/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12092/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12092/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 5m 52s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 31s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 30s The patch built with eclipse:eclipse. -1 findbugs 2m 30s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 1m 13s Pre-build of native portion -1 hdfs tests 162m 7s Tests failed in hadoop-hdfs.     182m 27s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.TestPread   hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.TestReplaceDatanodeOnFailure Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751824/HDFS-8846.03.patch Optional Tests javac unit findbugs checkstyle git revision trunk / b5ce87f Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12092/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12092/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12092/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12092/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 7m 53s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        +1 javac 7m 51s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 22s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 16s Pre-build of native portion
        -1 hdfs tests 160m 43s Tests failed in hadoop-hdfs.
            184m 2s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestEditLog



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751824/HDFS-8846.03.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 3b00eae
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12099/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12099/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12099/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12099/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 53s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 16s Pre-build of native portion -1 hdfs tests 160m 43s Tests failed in hadoop-hdfs.     184m 2s   Reason Tests Timed out tests org.apache.hadoop.hdfs.server.namenode.TestEditLog Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751824/HDFS-8846.03.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 3b00eae Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12099/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12099/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12099/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12099/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        The change is test-only and is not related to TestEditLog. It also passes locally.

        Show
        zhz Zhe Zhang added a comment - The change is test-only and is not related to TestEditLog . It also passes locally.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Zhe Zhang.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Zhe Zhang .
        Hide
        cmccabe Colin P. McCabe added a comment -

        committed to 2.8

        Show
        cmccabe Colin P. McCabe added a comment - committed to 2.8
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Colin for reviewing the patch!

        Show
        zhz Zhe Zhang added a comment - Thanks Colin for reviewing the patch!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8349 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8349/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8349 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8349/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1038 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1038/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1038 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1038/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/305/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/305/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #310 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/310/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #310 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/310/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2254 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2254/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2254 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2254/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #297 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/297/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #297 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/297/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2235 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2235/)
        HDFS-8846. Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2235 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2235/ ) HDFS-8846 . Add a unit test for INotify functionality across a layout version upgrade (Zhe Zhang via Colin P. McCabe) (cmccabe: rev a4d9acc51d1a977bc333da17780c00c72e8546f1) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgradeFromImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/hadoop-252-dfs-dir.tgz
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Pulled this as a companion to HDFS-8480 into 2.6.1.

        Fixed minor merge conflicts. Ran compilation and TestDFSInotifyEventInputStream, TestDFSUpgrade, TestDFSUpgradeFromImage before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this as a companion to HDFS-8480 into 2.6.1. Fixed minor merge conflicts. Ran compilation and TestDFSInotifyEventInputStream, TestDFSUpgrade, TestDFSUpgradeFromImage before the push.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Attaching patch that I committed to 2.6.1.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Attaching patch that I committed to 2.6.1.
        Hide
        zhz Zhe Zhang added a comment -

        The patch looks good (I suppose the binary file was also included). Thanks Vinod Kumar Vavilapalli!

        Show
        zhz Zhe Zhang added a comment - The patch looks good (I suppose the binary file was also included). Thanks Vinod Kumar Vavilapalli !
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1.

        branch-2 patch had a minor merge conflict in the test on 2.7. Ran compilation and TestDFSInotifyEventInputStream, TestDFSUpgrade, TestDFSUpgradeFromImage the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1. branch-2 patch had a minor merge conflict in the test on 2.7. Ran compilation and TestDFSInotifyEventInputStream, TestDFSUpgrade, TestDFSUpgradeFromImage the push.

          People

          • Assignee:
            zhz Zhe Zhang
            Reporter:
            zhz Zhe Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development