Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-883

Datanode shutdown should log problems with Storage.unlockAll()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When shutting down, Datanode calls Storage.unlockAll(), but discards any exceptions thrown in the process.

      These exceptions could be useful in diagnosing problems, and should be logged.

      1. HDFS-883.patch
        0.6 kB
        Steve Loughran

        Activity

        Hide
        Steve Loughran added a comment -

        Patch logs at warn level. No tests, not unless someone starts simulating storage failures.

               try {
                 this.storage.unlockAll();
               } catch (IOException ie) {
        +        LOG.warn("Exception when unlocking storage: " + ie,
        +                 ie);
               }
             }
        
        Show
        Steve Loughran added a comment - Patch logs at warn level. No tests, not unless someone starts simulating storage failures. try { this .storage.unlockAll(); } catch (IOException ie) { + LOG.warn( "Exception when unlocking storage: " + ie, + ie); } }
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12429766/HDFS-883.patch
        against trunk revision 897068.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429766/HDFS-883.patch against trunk revision 897068. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/console This message is automatically generated.
        Hide
        Steve Loughran added a comment -

        As I said in the patch; no tests here as all that is happening is logging shutdown problems that are fairly hard to simulate, but when they happen, should at least be logged

        Show
        Steve Loughran added a comment - As I said in the patch; no tests here as all that is happening is logging shutdown problems that are fairly hard to simulate, but when they happen, should at least be logged
        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Steve.

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Steve.

          People

          • Assignee:
            Steve Loughran
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development