Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8810

Correct assertions in TestDFSInotifyEventInputStream class.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0, 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Some assertions are wrong in the test. Here is an example.

          Assert.assertTrue(batch.getEvents()[0].getEventType() == Event.EventType.RENAME);
            Event.RenameEvent re3 = (Event.RenameEvent) batch.getEvents()[0];
            Assert.assertTrue(re3.getDstPath().equals("/dir/file5"));
            Assert.assertTrue(re3.getSrcPath().equals("/file5"));
            Assert.assertTrue(re.getTimestamp() > 0);
      

      https://issues.apache.org/jira/browse/HDFS-8735?focusedCommentId=14636571&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14636571

      1. HDFS-8810.patch
        1 kB
        Surendra Singh Lilhore

        Activity

        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached patch..
        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached patch.. Please review..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 7m 40s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 35s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 25s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 19s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 6s Pre-build of native portion
        -1 hdfs tests 160m 39s Tests failed in hadoop-hdfs.
            183m 11s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747210/HDFS-8810.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 156f24e
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11841/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11841/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11841/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 35s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 25s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 19s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 6s Pre-build of native portion -1 hdfs tests 160m 39s Tests failed in hadoop-hdfs.     183m 11s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747210/HDFS-8810.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 156f24e hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11841/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11841/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11841/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, the test failures are not related to the patch.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, the test failures are not related to the patch.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this patch to trunk and branch-2. Thank you, Surendra Singh Lilhore.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this patch to trunk and branch-2. Thank you, Surendra Singh Lilhore .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8224 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8224/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8224 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8224/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Akira Ajisaka for review and commit..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review and commit..
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/269/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/269/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #999 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/999/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #999 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/999/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2196 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2196/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2196 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2196/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/258/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/258/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/266/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/266/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2215/)
        HDFS-8810. Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2215/ ) HDFS-8810 . Correct assertions in TestDFSInotifyEventInputStream class. Contributed by Surendra Singh Lilhore. (aajisaka: rev 1df78688c69476f89d16f93bc74a4f05d0b1a3da) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java

          People

          • Assignee:
            surendrasingh Surendra Singh Lilhore
            Reporter:
            surendrasingh Surendra Singh Lilhore
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development