Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8808

dfs.image.transfer.bandwidthPerSec should not apply to -bootstrapStandby

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The parameter dfs.image.transfer.bandwidthPerSec can be used to limit the speed with which the fsimage is copied between the namenodes during regular use. However, as a side effect, this also limits transfers when the -bootstrapStandby option is used. This option is often used during upgrades and could potentially slow down the entire workflow. The request here is to ensure -bootstrapStandby is unaffected by this bandwidth setting

      1. HDFS-8808.04.patch
        16 kB
        Zhe Zhang
      2. HDFS-8808-00.patch
        9 kB
        Zhe Zhang
      3. HDFS-8808-01.patch
        14 kB
        Zhe Zhang
      4. HDFS-8808-02.patch
        14 kB
        Zhe Zhang
      5. HDFS-8808-03.patch
        14 kB
        Zhe Zhang

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2467 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2467/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #531 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/531/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2521 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2521/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1312 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1312/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/589/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #576 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/576/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8697/)
        HDFS-8808. dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8697/ ) HDFS-8808 . dfs.image.transfer.bandwidthPerSec should not apply to (zhz: rev ab3c4cff4af338caaa23be0ec383fc1fe473714f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ImageServlet.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Checkpointer.java
        Hide
        zhz Zhe Zhang added a comment -

        All reported test failures are unrelated. I could only reproduce testThrottle locally and it's a known issue that will be addressed in HDFS-9300.

        I just committed the 04 patch to trunk and branch-2. Thanks Gautam for reporting the issue, and ATM / Brahma / Ajith for the review!

        Show
        zhz Zhe Zhang added a comment - All reported test failures are unrelated. I could only reproduce testThrottle locally and it's a known issue that will be addressed in HDFS-9300 . I just committed the 04 patch to trunk and branch-2. Thanks Gautam for reporting the issue, and ATM / Brahma / Ajith for the review!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 24m 58s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 10m 48s There were no new javac warning messages.
        +1 javadoc 16m 39s There were no new javadoc warning messages.
        +1 release audit 0m 43s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 19s The applied patch generated 1 new checkstyle issues (total was 555, now 555).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 56s mvn install still works.
        +1 eclipse:eclipse 0m 45s The patch built with eclipse:eclipse.
        +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 4m 4s Pre-build of native portion
        -1 hdfs tests 66m 47s Tests failed in hadoop-hdfs.
            132m 25s  



        Reason Tests
        Failed unit tests hadoop.tracing.TestTracing
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.TestReplaceDatanodeOnFailure
          hadoop.hdfs.TestEncryptionZones



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / eb6379c
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13158/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13158/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13158/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13158/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13158/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 24m 58s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 10m 48s There were no new javac warning messages. +1 javadoc 16m 39s There were no new javadoc warning messages. +1 release audit 0m 43s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 19s The applied patch generated 1 new checkstyle issues (total was 555, now 555). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 56s mvn install still works. +1 eclipse:eclipse 0m 45s The patch built with eclipse:eclipse. +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 4m 4s Pre-build of native portion -1 hdfs tests 66m 47s Tests failed in hadoop-hdfs.     132m 25s   Reason Tests Failed unit tests hadoop.tracing.TestTracing   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / eb6379c Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13158/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13158/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13158/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13158/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13158/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks ATM for reviewing again. I just triggered Jenkins since the last run was from a month ago.

        Show
        zhz Zhe Zhang added a comment - Thanks ATM for reviewing again. I just triggered Jenkins since the last run was from a month ago.
        Hide
        atm Aaron T. Myers added a comment -

        +1, the latest patch looks good to me.

        Thanks very much, Zhe.

        Show
        atm Aaron T. Myers added a comment - +1, the latest patch looks good to me. Thanks very much, Zhe.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 9s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 8m 10s There were no new javac warning messages.
        +1 javadoc 11m 15s There were no new javadoc warning messages.
        +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 31s The applied patch generated 1 new checkstyle issues (total was 546, now 546).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 55s mvn install still works.
        +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse.
        +1 findbugs 2m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 12s Pre-build of native portion
        -1 hdfs tests 0m 19s Tests failed in hadoop-hdfs.
            49m 32s  



        Reason Tests
        Failed build hadoop-hdfs



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 58d1a02
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12514/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12514/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12514/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12514/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 10s There were no new javac warning messages. +1 javadoc 11m 15s There were no new javadoc warning messages. +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 31s The applied patch generated 1 new checkstyle issues (total was 546, now 546). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 55s mvn install still works. +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse. +1 findbugs 2m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 0m 19s Tests failed in hadoop-hdfs.     49m 32s   Reason Tests Failed build hadoop-hdfs Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 58d1a02 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12514/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12514/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12514/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12514/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Triggering Jenkins again.

        Show
        zhz Zhe Zhang added a comment - Triggering Jenkins again.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 13s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 8m 0s There were no new javac warning messages.
        +1 javadoc 10m 11s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 549, now 549).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 15s Pre-build of native portion
        -1 hdfs tests 164m 20s Tests failed in hadoop-hdfs.
            210m 24s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.qjournal.client.TestQuorumJournalManager
          hadoop.hdfs.web.TestWebHDFSOAuth2
          hadoop.hdfs.qjournal.client.TestQJMWithFaults



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 826ae1c
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12220/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12220/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12220/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12220/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. +1 javadoc 10m 11s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 1 new checkstyle issues (total was 549, now 549). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 164m 20s Tests failed in hadoop-hdfs.     210m 24s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.qjournal.client.TestQuorumJournalManager   hadoop.hdfs.web.TestWebHDFSOAuth2   hadoop.hdfs.qjournal.client.TestQJMWithFaults Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 826ae1c checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12220/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12220/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12220/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12220/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 11m 7s Pre-patch trunk JavaDoc compilation may be broken.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        -1 javac 0m 11s The patch appears to cause the build to fail.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 30e342a
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12033/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 11m 7s Pre-patch trunk JavaDoc compilation may be broken. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. -1 javac 0m 11s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751151/HDFS-8808.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 30e342a Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12033/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 52s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 9m 22s There were no new javac warning messages.
        +1 javadoc 11m 29s There were no new javadoc warning messages.
        +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 57s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 43s mvn install still works.
        +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
        +1 findbugs 2m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 25s Pre-build of native portion
        -1 hdfs tests 107m 2s Tests failed in hadoop-hdfs.
            155m 57s  



        Reason Tests
        Failed unit tests hadoop.fs.contract.hdfs.TestHDFSContractOpen
          hadoop.fs.contract.hdfs.TestHDFSContractCreate
          hadoop.fs.TestGlobPaths
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750240/HDFS-8808-03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 71aedfa
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12028/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12028/testReport/
        Java 1.7.0_55
        uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12028/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 9m 22s There were no new javac warning messages. +1 javadoc 11m 29s There were no new javadoc warning messages. +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 57s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 2m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 25s Pre-build of native portion -1 hdfs tests 107m 2s Tests failed in hadoop-hdfs.     155m 57s   Reason Tests Failed unit tests hadoop.fs.contract.hdfs.TestHDFSContractOpen   hadoop.fs.contract.hdfs.TestHDFSContractCreate   hadoop.fs.TestGlobPaths Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750240/HDFS-8808-03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 71aedfa hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12028/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12028/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12028/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Aaron T. Myers for the review! Updating the patch to address the comments (not sure if we need to run Jenkins again since the new changes are text-only):

        1. Updated hdfs-default.xml
        2. Fixed misspelling.

        The plan of deprecating camel-cased config keys sounds good to me. Will file another JIRA to address.

        Show
        zhz Zhe Zhang added a comment - Thanks Aaron T. Myers for the review! Updating the patch to address the comments (not sure if we need to run Jenkins again since the new changes are text-only): Updated hdfs-default.xml Fixed misspelling. The plan of deprecating camel-cased config keys sounds good to me. Will file another JIRA to address.
        Hide
        atm Aaron T. Myers added a comment -

        Hey Zhe, latest patch looks pretty good to me. Just a few small comments:

        1. You should add an entry in hdfs-default.xml that describes what this config setting does, and perhaps also amend the description of dfs.image.transfer.bandwidthPerSec to make it clear that this does not apply to bootstrapping the standby.
        2. It's kind of unfortunate that this patch is perpetuating the inconsistent camel cased config name. I think much better would be to go with something consistent with, for example, the block scanner config name, which uses "bytes.per.second" instead of "bandwidthPerSec", which removes the camel case and is more consistent. Of course, doing that would be inconsistent with dfs.image.transfer.bandwidthPerSec. Perhaps we should go with being consistent with the "bandwidthPerSec" style for now, but file a follow-up JIRA to deprecate that form?
        3. Given that this JIRA will change the applicability of the existing config name, I believe we should consider this an incompatible change. That said, I think very few if any users are actually using the current config intending to limit the bandwidth of bootstrapping the standby, so I'm personally OK putting it into branch-2, but I still think we should mark this JIRA incompatible so as to call it out appropriately.
        4. Nit: I think that "bootstrapping" should have two "p"s.
        Show
        atm Aaron T. Myers added a comment - Hey Zhe, latest patch looks pretty good to me. Just a few small comments: You should add an entry in hdfs-default.xml that describes what this config setting does, and perhaps also amend the description of dfs.image.transfer.bandwidthPerSec to make it clear that this does not apply to bootstrapping the standby. It's kind of unfortunate that this patch is perpetuating the inconsistent camel cased config name. I think much better would be to go with something consistent with, for example, the block scanner config name, which uses "bytes.per.second" instead of "bandwidthPerSec", which removes the camel case and is more consistent. Of course, doing that would be inconsistent with dfs.image.transfer.bandwidthPerSec . Perhaps we should go with being consistent with the "bandwidthPerSec" style for now, but file a follow-up JIRA to deprecate that form? Given that this JIRA will change the applicability of the existing config name, I believe we should consider this an incompatible change. That said, I think very few if any users are actually using the current config intending to limit the bandwidth of bootstrapping the standby, so I'm personally OK putting it into branch-2, but I still think we should mark this JIRA incompatible so as to call it out appropriately. Nit: I think that "bootstrapping" should have two "p"s.
        Hide
        zhz Zhe Zhang added a comment -

        The patch still applies against trunk. Triggering Jenkins again.

        Show
        zhz Zhe Zhang added a comment - The patch still applies against trunk. Triggering Jenkins again.
        Hide
        zhz Zhe Zhang added a comment -

        Both reported test issues are unrelated and pass locally. The error message from Jenkins test result of testIdempotentAllocateBlockAndClose is interesting though. We should examine it in a separate JIRA.

        The checkstyle issue was pre-existing.

        Show
        zhz Zhe Zhang added a comment - Both reported test issues are unrelated and pass locally. The error message from Jenkins test result of testIdempotentAllocateBlockAndClose is interesting though. We should examine it in a separate JIRA. The checkstyle issue was pre-existing.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 28s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 27s The applied patch generated 1 new checkstyle issues (total was 574, now 574).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 22s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 177m 4s Tests failed in hadoop-hdfs.
            221m 22s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDFSClientRetries
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750240/HDFS-8808-03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 40f8151
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11986/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11986/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11986/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11986/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 27s The applied patch generated 1 new checkstyle issues (total was 574, now 574). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 177m 4s Tests failed in hadoop-hdfs.     221m 22s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSClientRetries Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750240/HDFS-8808-03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 40f8151 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11986/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11986/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11986/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11986/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Updating patch to fix whitespace issue (it was actually not caused by the patch, fixing anyway).

        TestReplaceDatanodeOnFailure is unrelated to the change and passes locally.

        Show
        zhz Zhe Zhang added a comment - Updating patch to fix whitespace issue (it was actually not caused by the patch, fixing anyway). TestReplaceDatanodeOnFailure is unrelated to the change and passes locally.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 29s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 52s There were no new javac warning messages.
        +1 javadoc 9m 50s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 47s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 12s Pre-build of native portion
        -1 hdfs tests 75m 15s Tests failed in hadoop-hdfs.
            117m 27s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750029/HDFS-8808-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1ea1a83
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11979/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11979/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11979/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11979/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 29s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 52s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 47s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 75m 15s Tests failed in hadoop-hdfs.     117m 27s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750029/HDFS-8808-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1ea1a83 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11979/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11979/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11979/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11979/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        The failed tests are unrelated and all pass locally. Updating patch to fix whitespace and checkstyle issues.

        Show
        zhz Zhe Zhang added a comment - The failed tests are unrelated and all pass locally. Updating patch to fix whitespace and checkstyle issues.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 53s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 10m 2s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 33s The applied patch generated 4 new checkstyle issues (total was 574, now 578).
        -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 51s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 70m 41s Tests failed in hadoop-hdfs.
            116m 45s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.TestFileCreationDelete
          org.apache.hadoop.hdfs.TestDFSClientExcludedNodes
          org.apache.hadoop.hdfs.TestGetBlocks
          org.apache.hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749985/HDFS-8808-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 3ae716f
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11973/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11973/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11973/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11973/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11973/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 53s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 33s The applied patch generated 4 new checkstyle issues (total was 574, now 578). -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 51s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 70m 41s Tests failed in hadoop-hdfs.     116m 45s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestFileCreationDelete   org.apache.hadoop.hdfs.TestDFSClientExcludedNodes   org.apache.hadoop.hdfs.TestGetBlocks   org.apache.hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749985/HDFS-8808-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3ae716f checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11973/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11973/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11973/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11973/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11973/console This message was automatically generated.
        Hide
        ajithshetty Ajith S added a comment -

        +1

        Show
        ajithshetty Ajith S added a comment - +1
        Hide
        zhz Zhe Zhang added a comment -

        Updating the patch with a unit test and the configuration option for transferring images for bootstrapping standby.

        Show
        zhz Zhe Zhang added a comment - Updating the patch with a unit test and the configuration option for transferring images for bootstrapping standby.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 16s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 14s There were no new javac warning messages.
        +1 javadoc 10m 0s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 28s The applied patch generated 1 new checkstyle issues (total was 152, now 153).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 23s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 11s Pre-build of native portion
        -1 hdfs tests 87m 49s Tests failed in hadoop-hdfs.
            134m 0s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestQuotaByStorageType
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
          hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
          hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749886/HDFS-8808-00.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1fc3c77
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11964/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11964/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11964/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11964/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 16s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 14s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 28s The applied patch generated 1 new checkstyle issues (total was 152, now 153). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 11s Pre-build of native portion -1 hdfs tests 87m 49s Tests failed in hadoop-hdfs.     134m 0s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749886/HDFS-8808-00.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1fc3c77 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11964/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11964/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11964/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11964/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Submitting initial patch to trigger Jenkins and collect feedback on the basic idea. In the next rev I will add a unit test and the additional config as Ajith S suggested.

        Show
        zhz Zhe Zhang added a comment - Submitting initial patch to trigger Jenkins and collect feedback on the basic idea. In the next rev I will add a unit test and the additional config as Ajith S suggested.
        Hide
        zhz Zhe Zhang added a comment -

        if i could suggest, may be add a configuration to configure bandwidth specifically for bootstrap.

        Thanks for the suggestion Ajith S. bootstrapping standby NN looks a pretty urgent task to me and I haven't seen a scenario where its xfer rate should be limited. That said, adding a config with zero default also looks reasonable.

        Any thoughts Aaron T. Myers?

        Show
        zhz Zhe Zhang added a comment - if i could suggest, may be add a configuration to configure bandwidth specifically for bootstrap. Thanks for the suggestion Ajith S . bootstrapping standby NN looks a pretty urgent task to me and I haven't seen a scenario where its xfer rate should be limited. That said, adding a config with zero default also looks reasonable. Any thoughts Aaron T. Myers ?
        Hide
        ajithshetty Ajith S added a comment -

        +1 on Zhang's comment
        Hi Zhe Zhang
        if i could suggest, may be add a configuration to configure bandwidth specifically for bootstrap.??
        Because i think its case basis if we want to throttle bandwidth on bootstrap.. please correct me if i am wrong

        Show
        ajithshetty Ajith S added a comment - +1 on Zhang's comment Hi Zhe Zhang if i could suggest, may be add a configuration to configure bandwidth specifically for bootstrap.?? Because i think its case basis if we want to throttle bandwidth on bootstrap.. please correct me if i am wrong
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Gautam Gopalakrishnan for reporting the problem.

        Ajith S: I think your idea is a valid workaround. However I think we still need a proper fix to address the issue. Changing system configuration only for a specific operation incurs more burden to admins and is prone to human errors.

        I'll take a crack on the task.

        Show
        zhz Zhe Zhang added a comment - Thanks Gautam Gopalakrishnan for reporting the problem. Ajith S : I think your idea is a valid workaround. However I think we still need a proper fix to address the issue. Changing system configuration only for a specific operation incurs more burden to admins and is prone to human errors. I'll take a crack on the task.
        Hide
        ajithshetty Ajith S added a comment -

        Hi Gautam Gopalakrishnan

        Why not bootstrap the standby without that property and when its complete, before starting the standby you add dfs.image.tranfer.bandwidthPerSec

        Show
        ajithshetty Ajith S added a comment - Hi Gautam Gopalakrishnan Why not bootstrap the standby without that property and when its complete, before starting the standby you add dfs.image.tranfer.bandwidthPerSec
        Hide
        ggop Gautam Gopalakrishnan added a comment -

        That's right, when the setting is at a non-default value. In one situation it was set to 600KB/s which was fine for normal checkpointing but was slowing down the -bootstrapStandby

        Show
        ggop Gautam Gopalakrishnan added a comment - That's right, when the setting is at a non-default value. In one situation it was set to 600KB/s which was fine for normal checkpointing but was slowing down the -bootstrapStandby
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Default value is zero. Hope You mean,when dfs.image.tranfer.bandwidthPerSec is configured some value?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Default value is zero. Hope You mean,when dfs.image.tranfer.bandwidthPerSec is configured some value?

          People

          • Assignee:
            zhz Zhe Zhang
            Reporter:
            ggop Gautam Gopalakrishnan
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development