Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8779

WebUI fails to display block IDs that are larger than 2^53 - 1

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: webhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Old release use randomly generated block ID(HDFS-4645).
      max value of Long in Java is 2^63-1
      max value of number(integer) in Javascript is 2^53-1. ( See Link)

      Which means almost every randomly generated block ID exceeds MAX_SAFE_INTEGER.

      A integer which exceeds MAX_SAFE_INTEGER cannot be represented in Javascript.

      1. after-02-patch.png
        32 kB
        Walter Su
      2. before.png
        17 kB
        Walter Su
      3. HDFS-8779.005.patch
        13 kB
        Haohui Mai
      4. HDFS-8779.006.patch
        13 kB
        Haohui Mai
      5. HDFS-8779.01.patch
        0.8 kB
        Walter Su
      6. HDFS-8779.02.patch
        2 kB
        Walter Su
      7. HDFS-8779.03.patch
        3 kB
        Walter Su
      8. HDFS-8779.04.patch
        25 kB
        Walter Su
      9. patch-to-json-parse.txt
        0.4 kB
        Walter Su
      10. test-006-patch.PNG
        14 kB
        Walter Su

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 4s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 42s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 22s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 4s Pre-build of native portion
          -1 hdfs tests 157m 53s Tests failed in hadoop-hdfs.
              201m 31s  



          Reason Tests
          Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract
            hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745417/HDFS-8779.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / edcaae4
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11711/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11711/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11711/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 4s Pre-build of native portion -1 hdfs tests 157m 53s Tests failed in hadoop-hdfs.     201m 31s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745417/HDFS-8779.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / edcaae4 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11711/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11711/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11711/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 55s Findbugs (version 3.0.0) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 39s There were no new javac warning messages.
          +1 javadoc 9m 43s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 1s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 1s Pre-build of native portion
          -1 hdfs tests 160m 48s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.
              207m 37s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745448/HDFS-8779.02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / edcaae4
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11714/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11714/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11714/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11714/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 55s Findbugs (version 3.0.0) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 43s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 1s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 1s Pre-build of native portion -1 hdfs tests 160m 48s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.     207m 37s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745448/HDFS-8779.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / edcaae4 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11714/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11714/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11714/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11714/console This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Walter Su, is it possible to add a test for this? Otherwise looks good

          Show
          andrew.wang Andrew Wang added a comment - Hi Walter Su , is it possible to add a test for this? Otherwise looks good
          Hide
          walter.k.su Walter Su added a comment -

          Sorry, I can't. The JSON data is just a string in HTTP body. How WebUI shows depends on thr behavior of browsers. How browser parses the string into JavaScript object.

          Upload test screenshots with chrome/ie11/firefox.

          Show
          walter.k.su Walter Su added a comment - Sorry, I can't. The JSON data is just a string in HTTP body. How WebUI shows depends on thr behavior of browsers. How browser parses the string into JavaScript object. Upload test screenshots with chrome/ie11/firefox.
          Hide
          andrew.wang Andrew Wang added a comment -

          Upon thinking about it more, I'm worried about compatibility issues with WebHDFS. We're changing the type of blockId from number to string.

          I'm guessing that the Java WebHdfsFileSystem implementation somehow already avoids the JS MAX_SAFE_INTEGER issue, else we would have seen some issues back when we were using random block IDs. We need to maintain compatibility both with old WebHdfsFileSystem implementations as well as out-of-tree WebHDFS clients.

          Could you do a little more digging on this front? Thanks Walter.

          Show
          andrew.wang Andrew Wang added a comment - Upon thinking about it more, I'm worried about compatibility issues with WebHDFS. We're changing the type of blockId from number to string. I'm guessing that the Java WebHdfsFileSystem implementation somehow already avoids the JS MAX_SAFE_INTEGER issue, else we would have seen some issues back when we were using random block IDs. We need to maintain compatibility both with old WebHdfsFileSystem implementations as well as out-of-tree WebHDFS clients. Could you do a little more digging on this front? Thanks Walter.
          Hide
          walter.k.su Walter Su added a comment -

          Uploaded 03 patch. I replace the response body before parsing it to json.
          03 patch tested in chrome/ie11/firefox.

          Show
          walter.k.su Walter Su added a comment - Uploaded 03 patch. I replace the response body before parsing it to json. 03 patch tested in chrome/ie11/firefox.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 release audit 0m 18s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 22s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745764/HDFS-8779.03.patch
          Optional Tests  
          git revision trunk / ee36f4f
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11735/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 18s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745764/HDFS-8779.03.patch Optional Tests   git revision trunk / ee36f4f Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11735/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          Is it possible to bring in a dedicated library like https://github.com/sidorares/json-bigint instead of putting hacks into the JSON string? It looks much cleaner.

          I'm guessing that the Java WebHdfsFileSystem implementation somehow already avoids the JS MAX_SAFE_INTEGER issue...

          I don't see why there are related. As pointed out in the description, in Java MAX_LONG equals to 2^63 - 1 while in JavaScript MAX_SAFE_INTEGER is only 2^53 - 1. JavaScript can represent numbers that are larger than 2^53 -1, but most likely with the loss of precisions.

          Show
          wheat9 Haohui Mai added a comment - Is it possible to bring in a dedicated library like https://github.com/sidorares/json-bigint instead of putting hacks into the JSON string? It looks much cleaner. I'm guessing that the Java WebHdfsFileSystem implementation somehow already avoids the JS MAX_SAFE_INTEGER issue... I don't see why there are related. As pointed out in the description, in Java MAX_LONG equals to 2^63 - 1 while in JavaScript MAX_SAFE_INTEGER is only 2^53 - 1. JavaScript can represent numbers that are larger than 2^53 -1, but most likely with the loss of precisions.
          Hide
          andrew.wang Andrew Wang added a comment -

          Yea, so like I said WebHdfsFileSystem's JSON parser does not have the 2^53-1 limitation...that was an aside to my concern about compatibility, which I think is accurate.

          Show
          andrew.wang Andrew Wang added a comment - Yea, so like I said WebHdfsFileSystem's JSON parser does not have the 2^53-1 limitation...that was an aside to my concern about compatibility, which I think is accurate.
          Hide
          walter.k.su Walter Su added a comment -

          Thanks Haohui Mai for the idea.
          json-bigint doesn't have a front-end version. The author gives a browserify version in here
          The file is up to 79kb.

          Since both BigNumber and JSON-js have a front-end version. I re-create the file using the idea of json-bigint:

          I simply add 2 lines to JSON-js library ( that's how json-bigint does):

          +                if (string.length > 15)
          +                   return new BigNumber(string);
          

          patch-to-json-parse.txt shows that. I didn't change anything to BigNumber.

          Uploaded 04 patch, tested in chrome/ie11/firefox. I still prefer 03 patch because it's simple. Both works for me.

          Show
          walter.k.su Walter Su added a comment - Thanks Haohui Mai for the idea. json-bigint doesn't have a front-end version. The author gives a browserify version in here The file is up to 79kb. Since both BigNumber and JSON-js have a front-end version. I re-create the file using the idea of json-bigint: I simply add 2 lines to JSON-js library ( that's how json-bigint does): + if (string.length > 15) + return new BigNumber(string); patch-to-json-parse.txt shows that. I didn't change anything to BigNumber . Uploaded 04 patch, tested in chrome/ie11/firefox. I still prefer 03 patch because it's simple. Both works for me.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 release audit 0m 13s The applied patch generated 2 release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 16s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746254/HDFS-8779.04.patch
          Optional Tests  
          git revision trunk / df1e8ce
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/11761/artifact/patchprocess/patchReleaseAuditProblems.txt
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11761/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 release audit 0m 13s The applied patch generated 2 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746254/HDFS-8779.04.patch Optional Tests   git revision trunk / df1e8ce Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/11761/artifact/patchprocess/patchReleaseAuditProblems.txt Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11761/console This message was automatically generated.
          Hide
          walter.k.su Walter Su added a comment -

          Seems like we run out of options:
          1. change JsonString from server side. (01, 02 patch)
          2. hack JsonString from client side. (03 patch)
          3. hack Json Parser(04 patch) (It's impossible to hack browser' Json Parser. You have to hack a parser library.)
          4. hack JavaScript Engine.

          #1 is the best way but is incompatible. I think server side has a bad design in the first place. We have to add a workaround at client side, just like HDFS-8388. I think #3,#4 is very inappropriate. So, Haohui Mai. could you reconsider #2 approach again? in 03 patch.

          Show
          walter.k.su Walter Su added a comment - Seems like we run out of options: 1. change JsonString from server side. (01, 02 patch) 2. hack JsonString from client side. (03 patch) 3. hack Json Parser(04 patch) (It's impossible to hack browser' Json Parser. You have to hack a parser library.) 4. hack JavaScript Engine. #1 is the best way but is incompatible. I think server side has a bad design in the first place. We have to add a workaround at client side, just like HDFS-8388 . I think #3,#4 is very inappropriate. So, Haohui Mai . could you reconsider #2 approach again? in 03 patch.
          Hide
          andrew.wang Andrew Wang added a comment -

          I'm +1 on the 03 patch, seems like the cleanest and least intrusive change on the table. Haohui Mai I'll commit in a while unless you have more comments.

          Show
          andrew.wang Andrew Wang added a comment - I'm +1 on the 03 patch, seems like the cleanest and least intrusive change on the table. Haohui Mai I'll commit in a while unless you have more comments.
          Hide
          wheat9 Haohui Mai added a comment -

          -1 on the 03 patch.

          For 04 patch the javascript needs to be minimized. Or it might make sense to create a browsified version of our own.

          Show
          wheat9 Haohui Mai added a comment - -1 on the 03 patch. For 04 patch the javascript needs to be minimized. Or it might make sense to create a browsified version of our own.
          Hide
          wheat9 Haohui Mai added a comment -

          I'll upload a patch to demonstrate the idea later today.

          Show
          wheat9 Haohui Mai added a comment - I'll upload a patch to demonstrate the idea later today.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 release audit 0m 13s The applied patch generated 1 release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 16s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753070/HDFS-8779.005.patch
          Optional Tests  
          git revision trunk / cbb2495
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12204/artifact/patchprocess/patchReleaseAuditProblems.txt
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12204/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 release audit 0m 13s The applied patch generated 1 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753070/HDFS-8779.005.patch Optional Tests   git revision trunk / cbb2495 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12204/artifact/patchprocess/patchReleaseAuditProblems.txt Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12204/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          The v06 patch is based on the idea of the v4 patch except that:

          Show
          wheat9 Haohui Mai added a comment - The v06 patch is based on the idea of the v4 patch except that: Use the recursive JSON parser from https://github.com/douglascrockford/JSON-js Wrap big integers as a simple BigNumber class without any arithmetic operations. Only wrap big integers if necessary. It's wrapped in a try..catch clause. The idea is from https://github.com/datalanche/json-bignum .
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 22s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 57s There were no new javac warning messages.
          +1 javadoc 10m 11s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 native 3m 8s Pre-build of native portion
          -1 hdfs tests 162m 12s Tests failed in hadoop-hdfs.
              201m 15s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753072/HDFS-8779.006.patch
          Optional Tests javadoc javac unit
          git revision trunk / cbb2495
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12205/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12205/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12205/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 22s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 57s There were no new javac warning messages. +1 javadoc 10m 11s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 native 3m 8s Pre-build of native portion -1 hdfs tests 162m 12s Tests failed in hadoop-hdfs.     201m 15s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753072/HDFS-8779.006.patch Optional Tests javadoc javac unit git revision trunk / cbb2495 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12205/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12205/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12205/console This message was automatically generated.
          Hide
          walter.k.su Walter Su added a comment -

          Thanks Haohui Mai for keep exploring 3rd-party library. I've tested with 3 browsers, and the 006 patch LGTM. Let me assign this to you. I'll update the screenshot of the result.
          Also thanks Andrew Wang for keep an eye on this all the time.

          Show
          walter.k.su Walter Su added a comment - Thanks Haohui Mai for keep exploring 3rd-party library. I've tested with 3 browsers, and the 006 patch LGTM. Let me assign this to you. I'll update the screenshot of the result. Also thanks Andrew Wang for keep an eye on this all the time.
          Hide
          jingzhao Jing Zhao added a comment -

          +1 on the 006 patch

          Show
          jingzhao Jing Zhao added a comment - +1 on the 006 patch
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks everybody for the contributions and reviews.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks everybody for the contributions and reviews.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8625 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8625/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8625 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8625/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1259 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1259/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1259 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1259/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #524 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/524/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #524 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/524/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2471 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2471/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2471 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2471/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #535 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/535/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #535 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/535/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #491 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/491/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #491 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/491/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2429 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2429/)
          HDFS-8779. WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92)

          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2429 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2429/ ) HDFS-8779 . WebUI fails to display block IDs that are larger than 2^53 - (wheat9: rev aa299ecd5e5d0fab6a50dd02e58fb0b4c1804e92) hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.html hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/json-bignum.js

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              walter.k.su Walter Su
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development