Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8735

Inotify : All events classes should implement toString() API.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Event classes is used by client, it’s good to implement toString() API.

      for(Event event : events){
      	System.out.println(event.toString());
      }
      

      This will give output like this

      org.apache.hadoop.hdfs.inotify.Event$CreateEvent@6916d97d
      
      1. HDFS-8735.01.patch
        7 kB
        Surendra Singh Lilhore
      2. HDFS-8735.patch
        7 kB
        Surendra Singh Lilhore
      3. HDFS-8735-002.patch
        13 kB
        Surendra Singh Lilhore
      4. HDFS-8735-003.patch
        13 kB
        Surendra Singh Lilhore
      5. HDFS-8735-004.patch
        13 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached patch , Please review ..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached patch , Please review ..
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Akira Ajisaka Would you please review ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Akira Ajisaka Would you please review ?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Good catch and thanks Surendra Singh Lilhore for taking this issue. Here are three comments.
          1. StringBuffer should be StringBuilder. StringBuilder is faster.
          2. You don't need to use StringBuffer except in CreateEvent and MetadataUpdateEvent. For example,

          +    @Override
          +    public String toString() {
          +      StringBuffer content = new StringBuffer();
          +      content.append("UnlinkEvent [path=" + path + ", timestamp=" + timestamp
          +          + "]");
          +      return content.toString();
          +    }
          

          can be simplified as

          +    @Override
          +    public String toString() {
          +      return new String("UnlinkEvent [path=" + path + ", timestamp=" + timestamp
          +          + "]");
          +    }
          

          3. Would you add null check for perm in MetadataUpdateEvent#toString()? We should add null check for all the optional variables. inotify.proto tells us whether the variable is required or not.

          Show
          ajisakaa Akira Ajisaka added a comment - Good catch and thanks Surendra Singh Lilhore for taking this issue. Here are three comments. 1. StringBuffer should be StringBuilder . StringBuilder is faster. 2. You don't need to use StringBuffer except in CreateEvent and MetadataUpdateEvent . For example, + @Override + public String toString() { + StringBuffer content = new StringBuffer (); + content.append( "UnlinkEvent [path=" + path + ", timestamp=" + timestamp + + "]" ); + return content.toString(); + } can be simplified as + @Override + public String toString() { + return new String ( "UnlinkEvent [path=" + path + ", timestamp=" + timestamp + + "]" ); + } 3. Would you add null check for perm in MetadataUpdateEvent#toString() ? We should add null check for all the optional variables. inotify.proto tells us whether the variable is required or not.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +    @Override
          +    public String toString() {
          +      return new String("UnlinkEvent [path=" + path + ", timestamp=" + timestamp
          +          + "]");
          +    }
          

          new String is redundant and should be removed. Sorry for the confusion.

          Show
          ajisakaa Akira Ajisaka added a comment - + @Override + public String toString() { + return new String ( "UnlinkEvent [path=" + path + ", timestamp=" + timestamp + + "]" ); + } new String is redundant and should be removed. Sorry for the confusion.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review and comments.

          We should add null check for all the optional variables. inotify.proto tells us whether the variable is required or not.

          I think only for string optional variable we should add check

          I Attached new patch, Please review...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review and comments. We should add null check for all the optional variables. inotify.proto tells us whether the variable is required or not. I think only for string optional variable we should add check I Attached new patch, Please review...
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 18m 39s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 32s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 49s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 2s Pre-build of native portion
          -1 hdfs tests 160m 49s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.
              209m 36s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746322/HDFS-8735.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 29cf887b
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11768/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11768/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11768/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11768/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11768/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 39s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 49s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 2s Pre-build of native portion -1 hdfs tests 160m 49s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 28s Tests passed in hadoop-hdfs-client.     209m 36s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746322/HDFS-8735.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 29cf887b Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11768/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11768/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11768/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11768/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11768/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          I think this is a good improvement. I would caution people not to start parsing the toString representation since it might change over time (if we add new optional fields to the Events). But it is nice for debugging and logging.

          Show
          cmccabe Colin P. McCabe added a comment - I think this is a good improvement. I would caution people not to start parsing the toString representation since it might change over time (if we add new optional fields to the Events). But it is nice for debugging and logging.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Surendra Singh Lilhore for updating the patch. Three comments:
          1. I still see some unnecessarily output in the test (modified to log the events). mtime=0, atime=0, replication=0 is confusing to me.

          2015-07-22 17:49:45,769 [Thread-0] INFO  hdfs.TestDFSInotifyEventInputStream (TestDFSInotifyEventInputStream.java:testBasic(289)) - MetadataUpdateEvent [path=/dir, metadataType=PERMS, mtime=0, atime=0, replication=0, perms=rw-rw-rw-, xAttrsRemoved=false]
          2015-07-22 17:49:45,770 [Thread-0] INFO  hdfs.TestDFSInotifyEventInputStream (TestDFSInotifyEventInputStream.java:testBasic(302)) - MetadataUpdateEvent [path=/dir, metadataType=OWNER, mtime=0, atime=0, replication=0, ownerName=username, groupName=groupname, xAttrsRemoved=false]
          

          Can we switch by metadataType and output the necessarily information as follows?

          @Override
          public String toString() {
            StringBuilder content = new StringBuilder();
            content.append("MetadataUpdateEvent [path=" + path + ", metadataType="
                + metadataType);
            switch (metadataType) {
            case TIMES:
              content.append(", mtime=" + mtime + ", atime=" + atime);
              break;
            case REPLICATION:
              content.append(", replication=" + replication);
              break;
            ...
            }
            content.append(']');
            return content.toString();
          }
          

          2. I'm thinking logging the event in the test is good for debugging.

                Assert.assertTrue(re.toString().contains("RenameEvent [srcPath="));
          

          3. (minor) re.toString().startsWith is more strict. It should be used instead of String.contains.

                 Event.CloseEvent ce3 = (Event.CloseEvent) batch.getEvents()[2];
                 Assert.assertTrue(ce3.getPath().equals("/file2"));
                 Assert.assertTrue(ce3.getTimestamp() > 0);
          +      Assert.assertTrue(ue2.toString().contains("UnlinkEvent [path="));
          

          4. (minor) Would you move the assertion before defining ce3?

          I found some assertions are wrong in the test. Here is an example.

                Assert.assertTrue(batch.getEvents()[0].getEventType() == Event.EventType.RENAME);
                Event.RenameEvent re3 = (Event.RenameEvent) batch.getEvents()[0];
                Assert.assertTrue(re3.getDstPath().equals("/dir/file5"));
                Assert.assertTrue(re3.getSrcPath().equals("/file5"));
                Assert.assertTrue(re.getTimestamp() > 0);
          

          We should fix them in a separate jira.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Surendra Singh Lilhore for updating the patch. Three comments: 1. I still see some unnecessarily output in the test (modified to log the events). mtime=0, atime=0, replication=0 is confusing to me. 2015-07-22 17:49:45,769 [Thread-0] INFO hdfs.TestDFSInotifyEventInputStream (TestDFSInotifyEventInputStream.java:testBasic(289)) - MetadataUpdateEvent [path=/dir, metadataType=PERMS, mtime=0, atime=0, replication=0, perms=rw-rw-rw-, xAttrsRemoved=false] 2015-07-22 17:49:45,770 [Thread-0] INFO hdfs.TestDFSInotifyEventInputStream (TestDFSInotifyEventInputStream.java:testBasic(302)) - MetadataUpdateEvent [path=/dir, metadataType=OWNER, mtime=0, atime=0, replication=0, ownerName=username, groupName=groupname, xAttrsRemoved=false] Can we switch by metadataType and output the necessarily information as follows? @Override public String toString() { StringBuilder content = new StringBuilder(); content.append( "MetadataUpdateEvent [path=" + path + ", metadataType=" + metadataType); switch (metadataType) { case TIMES: content.append( ", mtime=" + mtime + ", atime=" + atime); break ; case REPLICATION: content.append( ", replication=" + replication); break ; ... } content.append(']'); return content.toString(); } 2. I'm thinking logging the event in the test is good for debugging. Assert.assertTrue(re.toString().contains( "RenameEvent [srcPath=" )); 3. (minor) re.toString().startsWith is more strict. It should be used instead of String.contains . Event.CloseEvent ce3 = (Event.CloseEvent) batch.getEvents()[2]; Assert.assertTrue(ce3.getPath().equals( "/file2" )); Assert.assertTrue(ce3.getTimestamp() > 0); + Assert.assertTrue(ue2.toString().contains( "UnlinkEvent [path=" )); 4. (minor) Would you move the assertion before defining ce3 ? — I found some assertions are wrong in the test. Here is an example. Assert.assertTrue(batch.getEvents()[0].getEventType() == Event.EventType.RENAME); Event.RenameEvent re3 = (Event.RenameEvent) batch.getEvents()[0]; Assert.assertTrue(re3.getDstPath().equals( "/dir/file5" )); Assert.assertTrue(re3.getSrcPath().equals( "/file5" )); Assert.assertTrue(re.getTimestamp() > 0); We should fix them in a separate jira.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Colin P. McCabe for the comment.

          I would caution people not to start parsing the toString representation since it might change over time (if we add new optional fields to the Events). But it is nice for debugging and logging.

          Adding @Public and @Unstable to the subclasses is good for you? Event class is annotated, but the subclasses are not annotated and that's why they don't exist in API doc.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Colin P. McCabe for the comment. I would caution people not to start parsing the toString representation since it might change over time (if we add new optional fields to the Events). But it is nice for debugging and logging. Adding @Public and @Unstable to the subclasses is good for you? Event class is annotated, but the subclasses are not annotated and that's why they don't exist in API doc.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Good idea... I think the subclasses should have a @Public annotation. I think all the functions are "stable" except for toString.

          Show
          cmccabe Colin P. McCabe added a comment - Good idea... I think the subclasses should have a @Public annotation. I think all the functions are "stable" except for toString.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I think the subclasses should have a @Public annotation. I think all the functions are "stable" except for toString.

          Agree. Hi Surendra Singh Lilhore, would you add @Public annotation to the subclasses and @Unstable annotation to toString()?

          Show
          ajisakaa Akira Ajisaka added a comment - I think the subclasses should have a @Public annotation. I think all the functions are "stable" except for toString. Agree. Hi Surendra Singh Lilhore , would you add @Public annotation to the subclasses and @Unstable annotation to toString() ?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka and Colin P. McCabe for comments.

          I attached new patch. Please review ....

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka and Colin P. McCabe for comments. I attached new patch. Please review ....
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          I found some assertions are wrong in the test. Here is an example.

          I raised new jira for fixing assertions in test class..HDFS-8810

          Show
          surendrasingh Surendra Singh Lilhore added a comment - I found some assertions are wrong in the test. Here is an example. I raised new jira for fixing assertions in test class.. HDFS-8810
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 7s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 39s There were no new javac warning messages.
          +1 javadoc 9m 47s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 48s The applied patch generated 1 new checkstyle issues (total was 41, now 42).
          -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 19s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 3s Pre-build of native portion
          -1 hdfs tests 159m 54s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.
              209m 25s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746712/HDFS-8735-002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ee98d63
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11798/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11798/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 48s The applied patch generated 1 new checkstyle issues (total was 41, now 42). -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 19s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 159m 54s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.     209m 25s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746712/HDFS-8735-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ee98d63 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11798/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11798/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11798/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached new patch.

          Fixed checkstyle error and removed whitespace...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached new patch. Fixed checkstyle error and removed whitespace...
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 54s Findbugs (version 3.0.0) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 38s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 22s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 2s Pre-build of native portion
          -1 hdfs tests 162m 15s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.
              208m 46s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.web.TestWebHDFS



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746827/HDFS-8735-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 813cf89
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11809/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11809/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11809/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11809/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 54s Findbugs (version 3.0.0) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 22s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 2s Pre-build of native portion -1 hdfs tests 162m 15s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.     208m 46s   Reason Tests Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746827/HDFS-8735-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 813cf89 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11809/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11809/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11809/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11809/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Surendra for updating the patch. Mostly looks good to me. Would you add @Public annotation to CloseEvent class?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Surendra for updating the patch. Mostly looks good to me. Would you add @Public annotation to CloseEvent class?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Sorry I missed it.. I updated the patch

          Please review ...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Sorry I missed it.. I updated the patch Please review ...
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 9m 47s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 54s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 8s Pre-build of native portion
          -1 hdfs tests 159m 32s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 30s Tests passed in hadoop-hdfs-client.
              209m 44s  



          Reason Tests
          Failed unit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746968/HDFS-8735-004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 02c0181
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11825/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11825/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11825/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11825/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 54s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 8s Pre-build of native portion -1 hdfs tests 159m 32s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 30s Tests passed in hadoop-hdfs-client.     209m 44s   Reason Tests Failed unit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746968/HDFS-8735-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 02c0181 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11825/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11825/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11825/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11825/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, the test failures looks unrelated to the patch. The tests passed locally.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, the test failures looks unrelated to the patch. The tests passed locally.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Surendra Singh Lilhore and Colin P. McCabe for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Surendra Singh Lilhore and Colin P. McCabe for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8216 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8216/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8216 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8216/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Akira Ajisaka for review and commit..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Akira Ajisaka for review and commit..
          Hide
          cmccabe Colin P. McCabe added a comment -
          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Surendra Singh Lilhore and Akira Ajisaka .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/267/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #267 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/267/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #997 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/997/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #997 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/997/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2194 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2194/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/256/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/256/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/264/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #264 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/264/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2213 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2213/)
          HDFS-8735. Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2213 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2213/ ) HDFS-8735 . Inotify: All events classes should implement toString() API. Contributed by Surendra Singh Lilhore. (aajisaka: rev f8f60918230dd466ae8dda1fbc28878e19273232) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInotifyEventInputStream.java

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development