Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8687

Remove the duplicate usage message from Dfsck.java

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Toolrunner also give same usage message,, I think , we can remove

      printUsage(System.err);

      if ((args.length == 0) || ("-files".equals(args[0]))) {
            printUsage(System.err);
            ToolRunner.printGenericCommandUsage(System.err);
          } 
      
      1. HDFS-8687.patch
        0.9 kB
        Brahma Reddy Battula
      2. HDFS-8687-002.patch
        0.8 kB
        Brahma Reddy Battula

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/)
        HDFS-8687. Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/ ) HDFS-8687 . Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/)
        HDFS-8687. Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/ ) HDFS-8687 . Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/)
        HDFS-8687. Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/ ) HDFS-8687 . Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/)
        HDFS-8687. Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/ ) HDFS-8687 . Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Arpit Agarwal Thanks a lot for review and commit.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal Thanks a lot for review and commit.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8089 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8089/)
        HDFS-8687. Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8089 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8089/ ) HDFS-8687 . Remove the duplicate usage message from Dfsck.java. (Contributed by Brahma Reddy Battula) (arp: rev 8e333720e13428a4d0d0f65692102f8f2e5da98d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Test failures didn't repro locally.

        Committed for 2.8.0. Thanks for the contribution Brahma Reddy Battula.

        Show
        arpitagarwal Arpit Agarwal added a comment - Test failures didn't repro locally. Committed for 2.8.0. Thanks for the contribution Brahma Reddy Battula .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 19m 24s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 31s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 14s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 19s Pre-build of native portion
        -1 hdfs tests 156m 38s Tests failed in hadoop-hdfs.
            204m 34s  



        Reason Tests
        Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract
          hadoop.hdfs.TestHDFSFileSystemContract
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
          org.apache.hadoop.hdfs.server.balancer.TestBalancer
          org.apache.hadoop.hdfs.server.mover.TestMover
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742534/HDFS-8687-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fde20ff
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11534/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11534/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11534/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11534/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 24s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 19s Pre-build of native portion -1 hdfs tests 156m 38s Tests failed in hadoop-hdfs.     204m 34s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.TestHDFSFileSystemContract Timed out tests org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   org.apache.hadoop.hdfs.server.balancer.TestBalancer   org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742534/HDFS-8687-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fde20ff Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11534/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11534/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11534/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11534/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the updated patch.

        +1 pending Jenkins.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the updated patch. +1 pending Jenkins.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Arpit Agarwal thanks a lot for taking a look into this issue..

        Yes, you are correct..Updated the patch..Kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks a lot for taking a look into this issue.. Yes, you are correct..Updated the patch..Kindly review..
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Brahma Reddy Battula, thanks for submitting this fix.

        We should remove the line ToolRunner.printGenericCommandUsage(System.err); instead. Looks like removing printUsage will only print the generic options.

        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Brahma Reddy Battula , thanks for submitting this fix. We should remove the line ToolRunner.printGenericCommandUsage(System.err); instead. Looks like removing printUsage will only print the generic options.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Testcase failures are unrelated and raised jira to track (HDFS-8692)..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated and raised jira to track ( HDFS-8692 )..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 51s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 21s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 16s Pre-build of native portion
        -1 hdfs tests 163m 6s Tests failed in hadoop-hdfs.
            209m 33s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestHDFSFileSystemContract
          hadoop.hdfs.web.TestWebHdfsFileSystemContract



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742493/HDFS-8687.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fde20ff
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11529/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11529/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11529/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11529/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 51s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 21s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion -1 hdfs tests 163m 6s Tests failed in hadoop-hdfs.     209m 33s   Reason Tests Failed unit tests hadoop.hdfs.TestHDFSFileSystemContract   hadoop.hdfs.web.TestWebHdfsFileSystemContract Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742493/HDFS-8687.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fde20ff Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11529/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11529/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11529/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11529/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attaching the patch to remove the duplicate usage message.. Kindly Review

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attaching the patch to remove the duplicate usage message.. Kindly Review

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development