Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8670

Better to exclude decommissioned nodes for namenode NodeUsage JMX

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The namenode NodeUsage JMX has Max, Median, Min and Standard Deviation of DataNodes usage, it currently includes decommissioned nodes for the calculation. However, given balancer doesn't work on decommissioned nodes and sometimes we could have nodes stay in decommissioned states for a long time; it might be better to exclude decommissioned nodes for the metrics calculation.

      1. HDFS-8670.1.patch
        6 kB
        J.Andreina
      2. HDFS-8670.2.patch
        5 kB
        J.Andreina
      3. HDFS-8670.3.patch
        8 kB
        J.Andreina
      4. HDFS-8670.4.patch
        6 kB
        J.Andreina
      5. HDFS-8670.5.patch
        6 kB
        J.Andreina

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2217 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2217/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2217 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2217/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #268 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/268/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #268 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/268/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #260 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/260/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #260 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/260/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2198 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2198/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2198 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2198/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1001 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1001/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1001 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1001/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #271 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/271/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #271 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/271/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #8238 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8238/)
        HDFS-8670. Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8238 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8238/ ) HDFS-8670 . Better to exclude decommissioned nodes for namenode NodeUsage JMX (Contributed by J.Andreina) (vinayakumarb: rev 6374ee0db445e0a1c3462c19ddee345df740cfb3) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks J.Andreina for the contribution.
        Thanks Ming Ma for reporting and reviews.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks J.Andreina for the contribution. Thanks Ming Ma for reporting and reviews.
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1 for the latest patch

        Show
        vinayrpet Vinayakumar B added a comment - +1 for the latest patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 1s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 20s The applied patch generated 1 new checkstyle issues (total was 253, now 253).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 4s Pre-build of native portion
        +1 hdfs tests 161m 50s Tests passed in hadoop-hdfs.
            205m 14s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747709/HDFS-8670.5.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0712a81
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11862/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11862/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11862/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11862/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 1s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 20s The applied patch generated 1 new checkstyle issues (total was 253, now 253). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 4s Pre-build of native portion +1 hdfs tests 161m 50s Tests passed in hadoop-hdfs.     205m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747709/HDFS-8670.5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0712a81 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11862/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11862/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11862/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11862/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Thanks Vinayakumar B for the review comments.
        I have updated the patch .Sorry for the delay. Please review.

        Show
        andreina J.Andreina added a comment - Thanks Vinayakumar B for the review comments. I have updated the patch .Sorry for the delay. Please review.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Patch looks overall good.

        have some nits in test,
        1. use try-finally after starting cluster and shutdown cluster in finally block.
        2. Since DECOMMISSIONED and DECOMMISSION_INPROGRESS are enums, they are static, '==' also can be used for comparison instead of equals(..).

        Show
        vinayrpet Vinayakumar B added a comment - Patch looks overall good. have some nits in test, 1. use try-finally after starting cluster and shutdown cluster in finally block. 2. Since DECOMMISSIONED and DECOMMISSION_INPROGRESS are enums, they are static, '==' also can be used for comparison instead of equals(..) .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 17s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 25s The applied patch generated 1 new checkstyle issues (total was 256, now 256).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 24s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 161m 45s Tests failed in hadoop-hdfs.
            205m 42s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746267/HDFS-8670.4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / df1e8ce
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11762/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11762/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11762/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11762/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11762/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 17s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 25s The applied patch generated 1 new checkstyle issues (total was 256, now 256). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 24s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 161m 45s Tests failed in hadoop-hdfs.     205m 42s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746267/HDFS-8670.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / df1e8ce Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11762/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11762/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11762/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11762/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11762/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Thanks Ming Ma .
        Have updated the patch as per your comments.
        Please review.

        Show
        andreina J.Andreina added a comment - Thanks Ming Ma . Have updated the patch as per your comments. Please review.
        Hide
        mingma Ming Ma added a comment -

        Thanks J.Andreina. Overall it looks good.

        The two test cases have quite amount of overlaps. It seems the only differences between decommissioned test case and decommission_inprogress test case are the number of datanodes and the expected decommission state the test cases wait for. Maybe these two test cases can call a common function that takes number of datanodes and expected decommission state as parameters?

        Show
        mingma Ming Ma added a comment - Thanks J.Andreina . Overall it looks good. The two test cases have quite amount of overlaps. It seems the only differences between decommissioned test case and decommission_inprogress test case are the number of datanodes and the expected decommission state the test cases wait for. Maybe these two test cases can call a common function that takes number of datanodes and expected decommission state as parameters?
        Hide
        andreina J.Andreina added a comment -

        Testcase failures are not related to this patch.

        Show
        andreina J.Andreina added a comment - Testcase failures are not related to this patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 37s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 49s There were no new javac warning messages.
        +1 javadoc 9m 59s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 36s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 38s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 7s Pre-build of native portion
        -1 hdfs tests 158m 55s Tests failed in hadoop-hdfs.
            201m 12s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDistributedFileSystem
        Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12745432/HDFS-8670.3.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / edcaae4
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11713/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11713/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11713/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 37s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 38s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 7s Pre-build of native portion -1 hdfs tests 158m 55s Tests failed in hadoop-hdfs.     201m 12s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745432/HDFS-8670.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / edcaae4 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11713/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11713/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11713/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Thanks Ming Ma .

        I have updated the patch as per your review comments.

        Any reason it changes to call fetchDatanodes with parameter removeDecommissionNode set to false?

        Seems there is an issue in the logic for removing decommission node from live/dead node list .I have raised a separate jira for the same (HDFS-8780).

        Please review the patch.

        Show
        andreina J.Andreina added a comment - Thanks Ming Ma . I have updated the patch as per your review comments. Any reason it changes to call fetchDatanodes with parameter removeDecommissionNode set to false? Seems there is an issue in the logic for removing decommission node from live/dead node list .I have raised a separate jira for the same ( HDFS-8780 ). Please review the patch.
        Hide
        mingma Ming Ma added a comment -

        Thanks J.Andreina for the patch!

        • Maybe we should exclude decommission_inprogress node as well given the balancer excludes them.
        • Any reason it changes to call fetchDatanodes with parameter removeDecommissionNode set to false?
        • In test code, you can use JSON.parse to convert String to Map.
        • In test code, can you remove System.out.println statement?
        Show
        mingma Ming Ma added a comment - Thanks J.Andreina for the patch! Maybe we should exclude decommission_inprogress node as well given the balancer excludes them. Any reason it changes to call fetchDatanodes with parameter removeDecommissionNode set to false? In test code, you can use JSON.parse to convert String to Map. In test code, can you remove System.out.println statement?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 8s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 19s The applied patch generated 1 new checkstyle issues (total was 257, now 257).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 15s Pre-build of native portion
        +1 hdfs tests 163m 38s Tests passed in hadoop-hdfs.
            210m 23s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742309/HDFS-8670.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fe6c1bd
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11514/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11514/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11514/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11514/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11514/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 8s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 19s The applied patch generated 1 new checkstyle issues (total was 257, now 257). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion +1 hdfs tests 163m 38s Tests passed in hadoop-hdfs.     210m 23s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742309/HDFS-8670.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fe6c1bd Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11514/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11514/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11514/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11514/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11514/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Attached an updated patch.
        Please review.

        Show
        andreina J.Andreina added a comment - Attached an updated patch. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 58s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 19s The applied patch generated 2 new checkstyle issues (total was 76, now 76).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 17s Pre-build of native portion
        -1 hdfs tests 158m 46s Tests failed in hadoop-hdfs.
            205m 22s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDecommission
          hadoop.hdfs.server.namenode.TestHostsFiles



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742145/HDFS-8670.1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 40b2569
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11500/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11500/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11500/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11500/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 58s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 19s The applied patch generated 2 new checkstyle issues (total was 76, now 76). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 158m 46s Tests failed in hadoop-hdfs.     205m 22s   Reason Tests Failed unit tests hadoop.hdfs.TestDecommission   hadoop.hdfs.server.namenode.TestHostsFiles Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742145/HDFS-8670.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 40b2569 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11500/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11500/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11500/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11500/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Attached code patch along with a testcase.
        Please review.

        Show
        andreina J.Andreina added a comment - Attached code patch along with a testcase. Please review.
        Hide
        gliptak Gabor Liptak added a comment -

        I also made a patch before seeing J.Andreina's message.

        Show
        gliptak Gabor Liptak added a comment - I also made a patch before seeing J.Andreina 's message.
        Hide
        andreina J.Andreina added a comment -

        I would like to work on this issue.
        Ming Ma, please reassign to you , if you have already started working on this.

        Show
        andreina J.Andreina added a comment - I would like to work on this issue. Ming Ma , please reassign to you , if you have already started working on this.

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            mingma Ming Ma
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development