Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8665

Fix replication check in DFSTestUtils#waitForReplication

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      The check looks at the repl factor set on the file rather than reported # of replica locations. Let's do the latter.

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached, pretty trivial. Only used in TestCacheDirectives right now, which ran okay after this change.

        Show
        andrew.wang Andrew Wang added a comment - Patch attached, pretty trivial. Only used in TestCacheDirectives right now, which ran okay after this change.
        Hide
        andrew.wang Andrew Wang added a comment -

        Colin P. McCabe mind reviewing? Easy one.

        Show
        andrew.wang Andrew Wang added a comment - Colin P. McCabe mind reviewing? Easy one.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 8m 30s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 release audit 0m 18s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 21s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 21s Pre-build of native portion
        +1 hdfs tests 162m 0s Tests passed in hadoop-hdfs.
            187m 45s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741742/hdfs-8665.001.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / a815cc1
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11478/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11478/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11478/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 8m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 release audit 0m 18s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 21s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 21s Pre-build of native portion +1 hdfs tests 162m 0s Tests passed in hadoop-hdfs.     187m 45s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741742/hdfs-8665.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / a815cc1 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11478/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11478/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11478/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        +1, Nice fix. Thanks Andrew Wang!

        Show
        eddyxu Lei (Eddy) Xu added a comment - +1, Nice fix. Thanks Andrew Wang !
        Hide
        andrew.wang Andrew Wang added a comment -

        Pushed, thanks for reviewing Eddy!

        Show
        andrew.wang Andrew Wang added a comment - Pushed, thanks for reviewing Eddy!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8070 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8070/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8070 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8070/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/240/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/240/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #970 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/970/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #970 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/970/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/229/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/229/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2168/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2168/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2186/)
        HDFS-8665. Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2186/ ) HDFS-8665 . Fix replication check in DFSTestUtils#waitForReplication. (wang: rev ff0e5e572f5dcf7b49381cbe901360f6e171d423) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development