Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8659

Block scanner INFO message is spamming logs

    Details

    • Hadoop Flags:
      Reviewed

      Description

      We are seeing the following message spam the DN log:

      2015-06-16 08:51:10,566 INFO org.apache.hadoop.hdfs.server.datanode.BlockScanner: Not scanning suspicious block BP-943360218-10.106.148.16-1416571803827:blk_1083076388_9372245 on DS-2ec89056-afb0-459e-b4e0-ac5eaececda3, because the block scanner is disabled.

      Create this jira to change this and other relevant messages to debug level.

      1. HDFS-8659.001.patch
        3 kB
        Yongjun Zhang
      2. HDFS-8659.002.patch
        2 kB
        Yongjun Zhang

        Activity

        Hide
        yzhangal Yongjun Zhang added a comment -

        Hi Colin P. McCabe,

        Would you please help taking a look at the patch I just submitted?

        Thanks much.

        Show
        yzhangal Yongjun Zhang added a comment - Hi Colin P. McCabe , Would you please help taking a look at the patch I just submitted? Thanks much.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 55s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 48s There were no new javac warning messages.
        +1 javadoc 9m 47s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 16s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 18s Pre-build of native portion
        -1 hdfs tests 65m 57s Tests failed in hadoop-hdfs.
            112m 55s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.web.TestWebHDFSXAttr



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741684/HDFS-8659.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2236b57
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11472/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11472/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11472/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 55s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 16s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 18s Pre-build of native portion -1 hdfs tests 65m 57s Tests failed in hadoop-hdfs.     112m 55s   Reason Tests Timed out tests org.apache.hadoop.hdfs.web.TestWebHDFSXAttr Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741684/HDFS-8659.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2236b57 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11472/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11472/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11472/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        The if statements should not be necessary, for two reasons:
        1. slf4j doesn't create new strings through concatenation unless the log is enabled (this is ignoring things like the overhead of VolumeScanner#toString
        2. These are not code paths we should hit often, since they are for handling I/O errors and starting up.

        +1 once that's fixed.

        thanks, Yongjun Zhang.

        Show
        cmccabe Colin P. McCabe added a comment - The if statements should not be necessary, for two reasons: 1. slf4j doesn't create new strings through concatenation unless the log is enabled (this is ignoring things like the overhead of VolumeScanner#toString 2. These are not code paths we should hit often, since they are for handling I/O errors and starting up. +1 once that's fixed. thanks, Yongjun Zhang .
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Colin P. McCabe for the review, and Brahma Reddy Battula for a similar comment in email.

        I attached rev 002 to address the comment. Plus, I found somehow rev 001 missed an important one in BlockScanner (though I remember I did that change last time), added back in rev 002.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Colin P. McCabe for the review, and Brahma Reddy Battula for a similar comment in email. I attached rev 002 to address the comment. Plus, I found somehow rev 001 missed an important one in BlockScanner (though I remember I did that change last time), added back in rev 002.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yongjun Zhang thanks for updating the patch...rev 002 LGTM ,+1 ( non-binding).

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yongjun Zhang thanks for updating the patch...rev 002 LGTM ,+1 ( non-binding).
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 26s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 53s There were no new javac warning messages.
        +1 javadoc 10m 0s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 26s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 21s Pre-build of native portion
        -1 hdfs tests 162m 30s Tests failed in hadoop-hdfs.
            210m 39s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestCacheDirectives



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742066/HDFS-8659.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8ef07f7
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11496/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11496/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11496/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 26s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 26s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 21s Pre-build of native portion -1 hdfs tests 162m 30s Tests failed in hadoop-hdfs.     210m 39s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestCacheDirectives Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742066/HDFS-8659.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8ef07f7 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11496/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11496/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11496/console This message was automatically generated.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Brahma Reddy Battula.

        Hi Colin P. McCabe,

        I ran the failed test TestCacheDirectives successfully at local machine. Would you please take a second look? thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Brahma Reddy Battula . Hi Colin P. McCabe , I ran the failed test TestCacheDirectives successfully at local machine. Would you please take a second look? thanks.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Yongjun Zhang.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Yongjun Zhang .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8089 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8089/)
        HDFS-8659. Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8089 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8089/ ) HDFS-8659 . Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Colin P. McCabe and Brahma Reddy Battula for the review.

        I committed to trunk, branch-2 and branch-2.7.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Colin P. McCabe and Brahma Reddy Battula for the review. I committed to trunk, branch-2 and branch-2.7.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/)
        HDFS-8659. Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/ ) HDFS-8659 . Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/)
        HDFS-8659. Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/ ) HDFS-8659 . Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/)
        HDFS-8659. Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/ ) HDFS-8659 . Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/)
        HDFS-8659. Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/ ) HDFS-8659 . Block scanner INFO message is spamming logs. Contributed by Yongjun Zhang. (yzhang: rev 43a1288fff5e323895fde66b9e3eb31a7412fcc2) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockScanner.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/VolumeScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            yzhangal Yongjun Zhang
            Reporter:
            yzhangal Yongjun Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development