Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: native
    • Labels:
      None
    • Target Version/s:

      Description

      As we specify -Wall as a default compilation flag, it would be helpful if the Native code was -Wall-clean

      1. HDFS-8651.001.patch
        0.8 kB
        Alan Burlison

        Activity

        Hide
        alanburlison Alan Burlison added a comment -

        Patch attached

        Show
        alanburlison Alan Burlison added a comment - Patch attached
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Alan Burlison.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Alan Burlison .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 19s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 native 1m 10s Pre-build of native portion
        +1 hdfs tests 161m 44s Tests passed in hadoop-hdfs.
            178m 23s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741626/HDFS-8651.001.patch
        Optional Tests javac unit
        git revision trunk / 2df00d5
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11470/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11470/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11470/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 19s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 41s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 native 1m 10s Pre-build of native portion +1 hdfs tests 161m 44s Tests passed in hadoop-hdfs.     178m 23s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741626/HDFS-8651.001.patch Optional Tests javac unit git revision trunk / 2df00d5 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11470/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11470/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11470/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Committed to 2.8. Thanks, Alan.

        Show
        cmccabe Colin P. McCabe added a comment - Committed to 2.8. Thanks, Alan.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8073 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8073/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8073 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8073/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #241 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/241/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #241 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/241/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #971 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/971/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #971 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/971/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/230/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/230/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2169/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2169/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/239/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #239 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/239/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2187/)
        HDFS-8651. Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2187/ ) HDFS-8651 . Make hadoop-hdfs-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 1b764a01fd8010cf9660eb378977a1b2b81f330a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_impls_open.c

          People

          • Assignee:
            alanburlison Alan Burlison
            Reporter:
            alanburlison Alan Burlison
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development