Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8640

Make reserved RBW space visible through JMX

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      At present there is no way to trace the reserved space for RBW in DataNode to identify any leaks like HDFS-8626

      Idea is to add the value to VolumeInfo so that the DataNodeInfo JMX bean can be referred to know the present reserved space

      1. HDFS-8640-00.patch
        4 kB
        Kanaka Kumar Avvaru

        Activity

        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Attached patch with reservedRBW space included in VolumeInfo map

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Attached patch with reservedRBW space included in VolumeInfo map
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 40s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 26s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 16s The applied patch generated 2 new checkstyle issues (total was 121, now 122).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 12s Pre-build of native portion
        +1 hdfs tests 161m 24s Tests passed in hadoop-hdfs.
            207m 22s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741833/HDFS-8640-00.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a815cc1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11487/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11487/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11487/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11487/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 16s The applied patch generated 2 new checkstyle issues (total was 121, now 122). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion +1 hdfs tests 161m 24s Tests passed in hadoop-hdfs.     207m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741833/HDFS-8640-00.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a815cc1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11487/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11487/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11487/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11487/console This message was automatically generated.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        The check style issues reported in the build can be ignored..

        ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:1: File length is 3,107 lines (max allowed is 2,000).

        The file was already more than 2000 line earlier to this patch. So, this can be ignored.

        ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:2563:16: Variable 'reservedSpaceForRBW' must be private and have accessor methods.
        

        All other fields usedSpace,freeSpace, reservedSpace in VolumeInfo are declared in the same fashion with out accessor menthods for some reason. I think we can ignore this also.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - The check style issues reported in the build can be ignored.. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:1: File length is 3,107 lines (max allowed is 2,000). The file was already more than 2000 line earlier to this patch. So, this can be ignored. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:2563:16: Variable 'reservedSpaceForRBW' must be private and have accessor methods. All other fields usedSpace,freeSpace, reservedSpace in VolumeInfo are declared in the same fashion with out accessor menthods for some reason. I think we can ignore this also.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the patch. I will commit it shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the patch. I will commit it shortly.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed for 2.8.0. Thank you for the contribution Kanaka Kumar Avvaru.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed for 2.8.0. Thank you for the contribution Kanaka Kumar Avvaru .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8068 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8068/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8068 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8068/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/240/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/240/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #970 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/970/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #970 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/970/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/229/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/229/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2168/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2168/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2186/)
        HDFS-8640. Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2186/ ) HDFS-8640 . Make reserved RBW space visible through JMX. (Contributed by kanaka kumar avvaru) (arp: rev 67a62da5c5f592b07d083440ced3666c7709b20d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestRbwSpaceReservation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java

          People

          • Assignee:
            kanaka Kanaka Kumar Avvaru
            Reporter:
            kanaka Kanaka Kumar Avvaru
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development