Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8633

Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Found this using the XML/Config verifier. One of these properties has two digits swapped.

      XML Property: dfs.datanode.readahead.bytes
      XML Value: 4193404
      Config Name: DFS_DATANODE_READAHEAD_BYTES_DEFAULT
      Config Value: 4194304

      What is the intended value?

        Issue Links

          Activity

          Hide
          yzhangal Yongjun Zhang added a comment -

          Good catch Ray Chiang, it should be 4M, 4194304. Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Good catch Ray Chiang , it should be 4M, 4194304. Thanks.
          Hide
          rchiang Ray Chiang added a comment -
          • Change 4193404 to 4194304 for dfs.datanode.readahead.bytes
          Show
          rchiang Ray Chiang added a comment - Change 4193404 to 4194304 for dfs.datanode.readahead.bytes
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 34s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 55s The patch built with eclipse:eclipse.
          +1 native 3m 15s Pre-build of native portion
          +1 hdfs tests 161m 30s Tests passed in hadoop-hdfs.
              199m 37s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12740459/HDFS-8633.001.patch
          Optional Tests javadoc javac unit
          git revision trunk / 5b5bb8d
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11406/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11406/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11406/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 55s The patch built with eclipse:eclipse. +1 native 3m 15s Pre-build of native portion +1 hdfs tests 161m 30s Tests passed in hadoop-hdfs.     199m 37s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740459/HDFS-8633.001.patch Optional Tests javadoc javac unit git revision trunk / 5b5bb8d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11406/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11406/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11406/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Ray. +1, will commit soon.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Ray. +1, will commit soon.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk, branch-2 and branch-2.7. Thanks Ray Chiang for the contribution!

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2 and branch-2.7. Thanks Ray Chiang for the contribution!
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for the quick review and commit!

          Show
          rchiang Ray Chiang added a comment - Thanks for the quick review and commit!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/233/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/233/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #963 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/963/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #963 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/963/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2161 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2161/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2161 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2161/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/222/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/222/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/231/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #231 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/231/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2179 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2179/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2179 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2179/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8039 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8039/)
          HDFS-8633. Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8039 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8039/ ) HDFS-8633 . Fix setting of dfs.datanode.readahead.bytes in hdfs-default.xml to match DFSConfigKeys. Contributed by Ray Chiang. (yzhang: rev b42f1ec13d0a837f188cf424a8dd177720478cc9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development