Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: webhdfs
    • Labels:
      None

      Description

      User can set and get the storage policy from filesystem object. Same operation can be allowed trough REST API.

      1. HDFS-8630.001.patch
        22 kB
        Surendra Singh Lilhore
      2. HDFS-8630.002.patch
        22 kB
        Surendra Singh Lilhore
      3. HDFS-8630.003.patch
        22 kB
        Surendra Singh Lilhore
      4. HDFS-8630.004.patch
        22 kB
        Surendra Singh Lilhore
      5. HDFS-8630.005.patch
        22 kB
        Surendra Singh Lilhore
      6. HDFS-8630.006.patch
        31 kB
        Surendra Singh Lilhore
      7. HDFS-8630.007.patch
        32 kB
        Surendra Singh Lilhore
      8. HDFS-8630.008.patch
        58 kB
        Surendra Singh Lilhore
      9. HDFS-8630.009.patch
        54 kB
        Surendra Singh Lilhore
      10. HDFS-8630.010.patch
        57 kB
        Surendra Singh Lilhore
      11. HDFS-8630.011.patch
        55 kB
        Surendra Singh Lilhore
      12. HDFS-8630.patch
        22 kB
        Surendra Singh Lilhore
      13. HDFS-8630-branch-2.001.patch
        56 kB
        Surendra Singh Lilhore
      14. HDFS-8630-branch-2.8-001.patch
        55 kB
        Surendra Singh Lilhore
      15. WebHDFS.html
        160 kB
        Surendra Singh Lilhore

        Activity

        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Implemented webhdfs API for storage policy

        curl -i -X PUT "http://<HOST>:<PORT>/webhdfs/v1/<PATH>?op=SETSTORAGEPOLICY[&storagepolicy=<NAME>]"
        
        curl -i "http://<HOST>:<PORT>/webhdfs/v1/?op=GETALLSTORAGEPOLICY
        
        Show
        surendrasingh Surendra Singh Lilhore added a comment - Implemented webhdfs API for storage policy curl -i -X PUT "http://<HOST>:<PORT>/webhdfs/v1/<PATH>?op=SETSTORAGEPOLICY[&storagepolicy=<NAME>]" curl -i "http://<HOST>:<PORT>/webhdfs/v1/?op=GETALLSTORAGEPOLICY
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached patch, Please review ..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached patch, Please review ..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        -1 javac 7m 34s The applied patch generated 1 additional warning messages.
        -1 javadoc 9m 35s The applied patch generated 1 additional warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 47s The applied patch generated 3 new checkstyle issues (total was 140, now 143).
        -1 whitespace 0m 2s The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        -1 findbugs 4m 9s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        +1 hdfs tests 159m 42s Tests passed in hadoop-hdfs.
        +1 hdfs tests 0m 18s Tests passed in hadoop-hdfs-client.
            207m 37s  



        Reason Tests
        FindBugs module:hadoop-hdfs-client



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741384/HDFS-8630.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 122cad6
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/diffJavacWarnings.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/diffJavadocWarnings.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/whitespace.txt
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11452/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11452/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. -1 javac 7m 34s The applied patch generated 1 additional warning messages. -1 javadoc 9m 35s The applied patch generated 1 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 47s The applied patch generated 3 new checkstyle issues (total was 140, now 143). -1 whitespace 0m 2s The patch has 7 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 4m 9s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion +1 hdfs tests 159m 42s Tests passed in hadoop-hdfs. +1 hdfs tests 0m 18s Tests passed in hadoop-hdfs-client.     207m 37s   Reason Tests FindBugs module:hadoop-hdfs-client Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741384/HDFS-8630.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 122cad6 javac https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/diffJavacWarnings.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/whitespace.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11452/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11452/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11452/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        javac and javadoc warnings are not related to this patch...

        Show
        surendrasingh Surendra Singh Lilhore added a comment - javac and javadoc warnings are not related to this patch...
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Rebased the patch based on changes done in HDFS-8815 ...
        Please review

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Rebased the patch based on changes done in HDFS-8815 ... Please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 5s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 10m 1s There were no new javac warning messages.
        +1 javadoc 11m 39s There were no new javadoc warning messages.
        +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 3m 16s The applied patch generated 2 new checkstyle issues (total was 140, now 142).
        -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 52s mvn install still works.
        +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
        -1 findbugs 5m 57s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 4m 16s Pre-build of native portion
        -1 hdfs tests 95m 15s Tests failed in hadoop-hdfs.
        +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.
            154m 1s  



        Reason Tests
        FindBugs module:hadoop-hdfs-client
        Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
        Timed out tests org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749466/HDFS-8630.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8f73bdd
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/whitespace.txt
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11948/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11948/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 5s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 10m 1s There were no new javac warning messages. +1 javadoc 11m 39s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 16s The applied patch generated 2 new checkstyle issues (total was 140, now 142). -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 52s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. -1 findbugs 5m 57s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 4m 16s Pre-build of native portion -1 hdfs tests 95m 15s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.     154m 1s   Reason Tests FindBugs module:hadoop-hdfs-client Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure Timed out tests org.apache.hadoop.hdfs.qjournal.TestSecureNNWithQJM Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749466/HDFS-8630.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8f73bdd checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/whitespace.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11948/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11948/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11948/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks Surendra Singh Lilhore for working on this.

        Have few comments
        1. Need to rebase the patch with latest trunk code.
        2. Some places formatting is not proper, so please format code for changed lines
        3. In WebHdfsFileSystem.java XAttrEncodingParam not required to pass.

        +    return new FsPathResponseRunner<Collection<? extends BlockStoragePolicySpi>>(
        +        op, null, new XAttrEncodingParam(XAttrCodec.HEX)) {

        4. In Tests, testGetAllStoragePolicy, I think you are just doing duplicate work. webhdfs also uses HTTP to get storage policies, and you are explicitly querying via PUT request. I think it would be better to get expected values via DFS, and actual values via both WebHDFS and direct PUT query.

        5. Same #4, In testGetandSetStoragePolicy, each operation you can cross verify again by using DFS.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks Surendra Singh Lilhore for working on this. Have few comments 1. Need to rebase the patch with latest trunk code. 2. Some places formatting is not proper, so please format code for changed lines 3. In WebHdfsFileSystem.java XAttrEncodingParam not required to pass. + return new FsPathResponseRunner<Collection<? extends BlockStoragePolicySpi>>( + op, null , new XAttrEncodingParam(XAttrCodec.HEX)) { 4. In Tests, testGetAllStoragePolicy , I think you are just doing duplicate work. webhdfs also uses HTTP to get storage policies, and you are explicitly querying via PUT request. I think it would be better to get expected values via DFS, and actual values via both WebHDFS and direct PUT query. 5. Same #4, In testGetandSetStoragePolicy , each operation you can cross verify again by using DFS.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Vinayakumar B for review..
        Attached updated patch...
        Please review...

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review.. Attached updated patch... Please review...
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 22m 41s Pre-patch trunk has 748 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 9m 11s There were no new javac warning messages.
        +1 javadoc 11m 44s There were no new javadoc warning messages.
        -1 release audit 0m 21s The applied patch generated 1 release audit warnings.
        +1 checkstyle 2m 56s There were no new checkstyle issues.
        +1 whitespace 0m 2s The patch has no lines that end in whitespace.
        +1 install 2m 3s mvn install still works.
        +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
        -1 findbugs 5m 22s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
        +1 native 3m 42s Pre-build of native portion
        -1 hdfs tests 229m 55s Tests failed in hadoop-hdfs.
        +1 hdfs tests 0m 32s Tests passed in hadoop-hdfs-client.
            289m 10s  



        Reason Tests
        FindBugs module:hadoop-hdfs-client
        Failed unit tests hadoop.fs.TestSWebHdfsFileContextMainOperations
          hadoop.hdfs.TestRollingUpgrade
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.fs.TestSymlinkHdfsFileSystem
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765573/HDFS-8630.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1107bd3
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html
        Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12861/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12861/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 22m 41s Pre-patch trunk has 748 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 9m 11s There were no new javac warning messages. +1 javadoc 11m 44s There were no new javadoc warning messages. -1 release audit 0m 21s The applied patch generated 1 release audit warnings. +1 checkstyle 2m 56s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 2m 3s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. -1 findbugs 5m 22s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 42s Pre-build of native portion -1 hdfs tests 229m 55s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 32s Tests passed in hadoop-hdfs-client.     289m 10s   Reason Tests FindBugs module:hadoop-hdfs-client Failed unit tests hadoop.fs.TestSWebHdfsFileContextMainOperations   hadoop.hdfs.TestRollingUpgrade   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765573/HDFS-8630.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1107bd3 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12861/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12861/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12861/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        The failed tests and release audit warning are unrelated..
        Attached updated patch, fixed findbug issue.
        Please review.

        Show
        surendrasingh Surendra Singh Lilhore added a comment - The failed tests and release audit warning are unrelated.. Attached updated patch, fixed findbug issue. Please review.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Resubmitting patch for QA results..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Resubmitting patch for QA results..
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks Surendra Singh Lilhore for the update.

        Patch looks almost good.
        only nits.

        1. webHfsPolicy typo, in test
        2. I think, to make test run faster, you need not run datanodes for these tests. You can create empty file to verify setting storagepolicy.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks Surendra Singh Lilhore for the update. Patch looks almost good. only nits. 1. webHfsPolicy typo, in test 2. I think, to make test run faster, you need not run datanodes for these tests. You can create empty file to verify setting storagepolicy.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Vinayakumar B for review...
        Attached updated patch..
        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review... Attached updated patch.. Please review..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 51s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 53s There were no new javac warning messages.
        +1 javadoc 10m 20s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 33s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 39s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 4m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 9s Pre-build of native portion
        -1 hdfs tests 49m 54s Tests failed in hadoop-hdfs.
        +1 hdfs tests 0m 31s Tests passed in hadoop-hdfs-client.
            101m 21s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.datanode.TestBPOfferService



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766335/HDFS-8630.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 39581e3
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12951/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12951/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12951/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12951/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 51s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 33s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 49m 54s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 31s Tests passed in hadoop-hdfs-client.     101m 21s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestBPOfferService Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766335/HDFS-8630.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 39581e3 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12951/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12951/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12951/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12951/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Failed tests are unrelated. Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Failed tests are unrelated. Please review..
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Fixed second comment for testGetAllStoragePolicy() test.
        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Fixed second comment for testGetAllStoragePolicy() test. Please review..
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 20m 25s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 48s There were no new javac warning messages.
        +1 javadoc 10m 30s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 25s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 4m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        +1 hdfs tests 49m 12s Tests passed in hadoop-hdfs.
        +1 hdfs tests 0m 31s Tests passed in hadoop-hdfs-client.
            101m 18s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767023/HDFS-8630.005.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cf23f2c
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13028/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13028/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/13028/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13028/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13028/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 25s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 10m 30s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 25s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 4m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 49m 12s Tests passed in hadoop-hdfs. +1 hdfs tests 0m 31s Tests passed in hadoop-hdfs-client.     101m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767023/HDFS-8630.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf23f2c Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13028/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13028/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/13028/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13028/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13028/console This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached new patch..
        Updated document(webhdfs.md) for new API.

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached new patch.. Updated document(webhdfs.md) for new API.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 12m 28s trunk passed
        +1 compile 3m 34s trunk passed with JDK v1.8.0_66
        +1 compile 2m 41s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 2m 30s trunk passed
        +1 mvneclipse 0m 40s trunk passed
        +1 findbugs 7m 1s trunk passed
        +1 javadoc 3m 43s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 20s trunk passed with JDK v1.7.0_85
        -1 mvninstall 0m 53s hadoop-hdfs in the patch failed.
        +1 compile 4m 20s the patch passed with JDK v1.8.0_66
        -1 javac 18m 2s hadoop-hdfs-project-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 49, now 49).
        +1 javac 4m 20s the patch passed
        +1 compile 3m 16s the patch passed with JDK v1.7.0_85
        -1 javac 21m 18s hadoop-hdfs-project-jdk1.7.0_85 with JDK v1.7.0_85 generated 2 new issues (was 51, now 51).
        +1 javac 3m 16s the patch passed
        -1 checkstyle 0m 43s Patch generated 6 new checkstyle issues in hadoop-hdfs-project (total was 207, now 209).
        +1 mvnsite 3m 4s the patch passed
        +1 mvneclipse 0m 50s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 0s The patch has 1 line(s) with tabs.
        +1 findbugs 6m 49s the patch passed
        +1 javadoc 2m 52s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 59s the patch passed with JDK v1.7.0_85
        -1 unit 139m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 2m 46s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 108m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
        +1 unit 1m 40s hadoop-hdfs-client in the patch passed with JDK v1.7.0_85.
        -1 asflicense 0m 28s Patch generated 56 ASF License warnings.
        324m 20s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestBlockStoragePolicy
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_85 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.tracing.TestTracing
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestIncrementalBrVariations
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774751/HDFS-8630.006.patch
        JIRA Issue HDFS-8630
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fe76493388ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c37c3f4
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        javac hadoop-hdfs-project-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_66.txt
        javac hadoop-hdfs-project-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_85.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13684/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13684/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 12m 28s trunk passed +1 compile 3m 34s trunk passed with JDK v1.8.0_66 +1 compile 2m 41s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 39s trunk passed +1 mvnsite 2m 30s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 7m 1s trunk passed +1 javadoc 3m 43s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 20s trunk passed with JDK v1.7.0_85 -1 mvninstall 0m 53s hadoop-hdfs in the patch failed. +1 compile 4m 20s the patch passed with JDK v1.8.0_66 -1 javac 18m 2s hadoop-hdfs-project-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 49, now 49). +1 javac 4m 20s the patch passed +1 compile 3m 16s the patch passed with JDK v1.7.0_85 -1 javac 21m 18s hadoop-hdfs-project-jdk1.7.0_85 with JDK v1.7.0_85 generated 2 new issues (was 51, now 51). +1 javac 3m 16s the patch passed -1 checkstyle 0m 43s Patch generated 6 new checkstyle issues in hadoop-hdfs-project (total was 207, now 209). +1 mvnsite 3m 4s the patch passed +1 mvneclipse 0m 50s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 0s The patch has 1 line(s) with tabs. +1 findbugs 6m 49s the patch passed +1 javadoc 2m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 59s the patch passed with JDK v1.7.0_85 -1 unit 139m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 2m 46s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 108m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_85. +1 unit 1m 40s hadoop-hdfs-client in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 28s Patch generated 56 ASF License warnings. 324m 20s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_85 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.tracing.TestTracing   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestIncrementalBrVariations   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774751/HDFS-8630.006.patch JIRA Issue HDFS-8630 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fe76493388ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c37c3f4 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt javac hadoop-hdfs-project-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.8.0_66.txt javac hadoop-hdfs-project-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13684/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13684/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13684/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HDFS-8630 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774751/HDFS-8630.006.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16974/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-8630 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774751/HDFS-8630.006.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16974/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        v7 :

        Updated patch for support unset storage operation in webhdfs

        Vinayakumar B Please can you review.

        Show
        surendrasingh Surendra Singh Lilhore added a comment - v7 : Updated patch for support unset storage operation in webhdfs Vinayakumar B Please can you review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 7s Maven dependency ordering for branch
        +1 mvninstall 6m 57s trunk passed
        +1 compile 1m 23s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 24s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 3m 4s trunk passed
        +1 javadoc 1m 15s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        -1 mvninstall 0m 23s hadoop-hdfs-client in the patch failed.
        -1 mvninstall 0m 22s hadoop-hdfs in the patch failed.
        -1 compile 0m 24s hadoop-hdfs-project in the patch failed.
        -1 javac 0m 24s hadoop-hdfs-project in the patch failed.
        -0 checkstyle 0m 29s hadoop-hdfs-project: The patch generated 8 new + 253 unchanged - 3 fixed = 261 total (was 256)
        -1 mvnsite 0m 25s hadoop-hdfs-client in the patch failed.
        -1 mvnsite 0m 24s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 18s the patch passed
        -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 0s The patch 1 line(s) with tabs.
        -1 findbugs 0m 15s hadoop-hdfs-client in the patch failed.
        -1 findbugs 0m 22s hadoop-hdfs in the patch failed.
        -1 javadoc 0m 52s hadoop-hdfs-project_hadoop-hdfs generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7)
        -1 unit 0m 25s hadoop-hdfs-client in the patch failed.
        -1 unit 0m 24s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        22m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831305/HDFS-8630.007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8f1e15d56adc 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6e130c3
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/whitespace-tabs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16975/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16975/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 6m 57s trunk passed +1 compile 1m 23s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 3m 4s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch -1 mvninstall 0m 23s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 22s hadoop-hdfs in the patch failed. -1 compile 0m 24s hadoop-hdfs-project in the patch failed. -1 javac 0m 24s hadoop-hdfs-project in the patch failed. -0 checkstyle 0m 29s hadoop-hdfs-project: The patch generated 8 new + 253 unchanged - 3 fixed = 261 total (was 256) -1 mvnsite 0m 25s hadoop-hdfs-client in the patch failed. -1 mvnsite 0m 24s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 18s the patch passed -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 0s The patch 1 line(s) with tabs. -1 findbugs 0m 15s hadoop-hdfs-client in the patch failed. -1 findbugs 0m 22s hadoop-hdfs in the patch failed. -1 javadoc 0m 52s hadoop-hdfs-project_hadoop-hdfs generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7) -1 unit 0m 25s hadoop-hdfs-client in the patch failed. -1 unit 0m 24s hadoop-hdfs in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 22m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831305/HDFS-8630.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8f1e15d56adc 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6e130c3 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16975/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16975/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16975/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        v7 :
        Updated patch. In last patch forgot to add newly added file..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - v7 : Updated patch. In last patch forgot to add newly added file..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 28s Maven dependency ordering for branch
        +1 mvninstall 7m 28s trunk passed
        +1 compile 1m 33s trunk passed
        +1 checkstyle 0m 34s trunk passed
        +1 mvnsite 1m 30s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 15s trunk passed
        +1 javadoc 1m 19s trunk passed
        0 mvndep 0m 6s Maven dependency ordering for patch
        +1 mvninstall 1m 22s the patch passed
        +1 compile 1m 30s the patch passed
        +1 javac 1m 30s the patch passed
        -0 checkstyle 0m 33s hadoop-hdfs-project: The patch generated 8 new + 252 unchanged - 3 fixed = 260 total (was 255)
        +1 mvnsite 1m 27s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 23s the patch passed
        +1 javadoc 1m 14s the patch passed
        +1 unit 0m 56s hadoop-hdfs-client in the patch passed.
        -1 unit 58m 4s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        87m 29s



        Reason Tests
        Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831328/HDFS-8630.007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3d193b2b8f31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0da54e8
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16978/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16978/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16978/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 7m 28s trunk passed +1 compile 1m 33s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 30s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 15s trunk passed +1 javadoc 1m 19s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 30s the patch passed +1 javac 1m 30s the patch passed -0 checkstyle 0m 33s hadoop-hdfs-project: The patch generated 8 new + 252 unchanged - 3 fixed = 260 total (was 255) +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 23s the patch passed +1 javadoc 1m 14s the patch passed +1 unit 0m 56s hadoop-hdfs-client in the patch passed. -1 unit 58m 4s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 87m 29s Reason Tests Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831328/HDFS-8630.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3d193b2b8f31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0da54e8 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16978/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16978/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16978/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Failed test unrelated. I think reported check style no need to fix.

        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Failed test unrelated. I think reported check style no need to fix. Please review..
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Surendra, thanks for working on this. Overall looks great! The patch needs a rebase, but some review comments:

        • Need @Test annotation on testStoragePolicyParam to run it
        • Want to combine the two minicluster tests in TestWebHDFS? testGetAllStoragePolicy is mostly boilerplate, so we can save some code.
        • For Get All Storage Policies, I think we should wrap it in a "BlockStoragePolicies" dictionary, the way we have "FileStatuses" and then "FileStatus". This is important to differentiate from when we have an array of BlockStoragePolicies vs. a single item like in Get Storage Policy.
        • Would be good to add some tests for error cases, like when storage policies are disabled, or the policy can't be changed.

        Do you want to also add HttpFS support, perhaps in a follow-on patch? This is pretty important for secure clusters.

        Show
        andrew.wang Andrew Wang added a comment - Hi Surendra, thanks for working on this. Overall looks great! The patch needs a rebase, but some review comments: Need @Test annotation on testStoragePolicyParam to run it Want to combine the two minicluster tests in TestWebHDFS? testGetAllStoragePolicy is mostly boilerplate, so we can save some code. For Get All Storage Policies, I think we should wrap it in a "BlockStoragePolicies" dictionary, the way we have "FileStatuses" and then "FileStatus". This is important to differentiate from when we have an array of BlockStoragePolicies vs. a single item like in Get Storage Policy. Would be good to add some tests for error cases, like when storage policies are disabled, or the policy can't be changed. Do you want to also add HttpFS support, perhaps in a follow-on patch? This is pretty important for secure clusters.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thansk Andrew Wang for review..

        Sorry for late response. I was busy in internal works..

        Want to combine the two minicluster tests in TestWebHDFS? testGetAllStoragePolicy is mostly boilerplate, so we can save some code.

        Yes

        Do you want to also add HttpFS support, perhaps in a follow-on patch? This is pretty important for secure clusters.

        Yes

        I will update the patch soon with HttpFS support.

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thansk Andrew Wang for review.. Sorry for late response. I was busy in internal works.. Want to combine the two minicluster tests in TestWebHDFS? testGetAllStoragePolicy is mostly boilerplate, so we can save some code. Yes Do you want to also add HttpFS support, perhaps in a follow-on patch? This is pretty important for secure clusters. Yes I will update the patch soon with HttpFS support.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached updated patch
        Please review...

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached updated patch Please review...
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        0 mvndep 0m 12s Maven dependency ordering for branch
        +1 mvninstall 6m 54s trunk passed
        +1 compile 1m 21s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 51s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        +1 findbugs 3m 29s trunk passed
        +1 javadoc 1m 14s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 46s the patch passed
        +1 compile 1m 18s the patch passed
        +1 javac 1m 18s the patch passed
        -0 checkstyle 0m 36s hadoop-hdfs-project: The patch generated 42 new + 713 unchanged - 5 fixed = 755 total (was 718)
        +1 mvnsite 1m 43s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 47s the patch passed
        +1 javadoc 1m 7s the patch passed
        +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
        +1 unit 84m 49s hadoop-hdfs in the patch passed.
        +1 unit 3m 12s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        118m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840455/HDFS-8630.008.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0ba3b7969cef 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 01665e4
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17661/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17661/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17661/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 1m 21s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 3m 29s trunk passed +1 javadoc 1m 14s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 1m 18s the patch passed +1 javac 1m 18s the patch passed -0 checkstyle 0m 36s hadoop-hdfs-project: The patch generated 42 new + 713 unchanged - 5 fixed = 755 total (was 718) +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 47s the patch passed +1 javadoc 1m 7s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. +1 unit 84m 49s hadoop-hdfs in the patch passed. +1 unit 3m 12s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 118m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840455/HDFS-8630.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ba3b7969cef 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 01665e4 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17661/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17661/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17661/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 26s Maven dependency ordering for branch
        +1 mvninstall 7m 27s trunk passed
        +1 compile 1m 25s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 1m 57s trunk passed
        +1 mvneclipse 0m 44s trunk passed
        +1 findbugs 3m 40s trunk passed
        +1 javadoc 1m 19s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 2m 3s the patch passed
        +1 compile 1m 25s the patch passed
        +1 javac 1m 25s the patch passed
        -0 checkstyle 0m 36s hadoop-hdfs-project: The patch generated 33 new + 665 unchanged - 5 fixed = 698 total (was 670)
        +1 mvnsite 1m 50s the patch passed
        +1 mvneclipse 0m 31s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 4m 19s the patch passed
        +1 javadoc 1m 18s the patch passed
        +1 unit 1m 3s hadoop-hdfs-client in the patch passed.
        -1 unit 94m 1s hadoop-hdfs in the patch failed.
        +1 unit 3m 32s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        130m 46s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestFileAppend3



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840544/HDFS-8630.009.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bb39f5b98de4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 07825f2
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17663/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/17663/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17663/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17663/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17663/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 26s Maven dependency ordering for branch +1 mvninstall 7m 27s trunk passed +1 compile 1m 25s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 44s trunk passed +1 findbugs 3m 40s trunk passed +1 javadoc 1m 19s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 2m 3s the patch passed +1 compile 1m 25s the patch passed +1 javac 1m 25s the patch passed -0 checkstyle 0m 36s hadoop-hdfs-project: The patch generated 33 new + 665 unchanged - 5 fixed = 698 total (was 670) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 31s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 4m 19s the patch passed +1 javadoc 1m 18s the patch passed +1 unit 1m 3s hadoop-hdfs-client in the patch passed. -1 unit 94m 1s hadoop-hdfs in the patch failed. +1 unit 3m 32s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 130m 46s Reason Tests Failed junit tests hadoop.hdfs.TestFileAppend3 Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840544/HDFS-8630.009.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bb39f5b98de4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 07825f2 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17663/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/17663/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17663/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17663/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17663/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java:360: case GETSTORAGEPOLICY: {:28: Avoid nested blocks.

        I think no need to fix this checkstyle warning

        ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java:501: break;: 'block' child have incorrect indentation level 8, expected level should be 6.

        Existing indentation is wrong in HttpFSServer.java, so I think we no need to fix indentation related warning or we can correct full code indentation.

        Failed tests are unrelated.
        Please review...

        Show
        surendrasingh Surendra Singh Lilhore added a comment - ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java:360: case GETSTORAGEPOLICY: {:28: Avoid nested blocks. I think no need to fix this checkstyle warning ./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java:501: break;: 'block' child have incorrect indentation level 8, expected level should be 6. Existing indentation is wrong in HttpFSServer.java , so I think we no need to fix indentation related warning or we can correct full code indentation. Failed tests are unrelated. Please review...
        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Surendra, thanks for updating the patch, only really have nits,

        • baseTestHttpFSWith, could we convert the isLocalFS early exits to instead use Assume.assumeFalse ? It's cleaner and more informative.
        • baseTestHttpFSWith, can also use assertArrayEquals. Please also add messages to the asserts for easier debugging in case it fails (and as documentation).
        • FSOperations, please move the JSON conversion code to static methods like the others at the top of the file

        WebHDFS.md

        • The anchor links are broken, I think incorrectly capitalized
        • Although this is not related, could you add param documentation for "startAfter" as well? Or we can do it in a separate JIRA.
        • Need to also define the StoragePolicies schema, see FileStatuses/FileStatus as an example
        Show
        andrew.wang Andrew Wang added a comment - Hi Surendra, thanks for updating the patch, only really have nits, baseTestHttpFSWith, could we convert the isLocalFS early exits to instead use Assume.assumeFalse ? It's cleaner and more informative. baseTestHttpFSWith, can also use assertArrayEquals. Please also add messages to the asserts for easier debugging in case it fails (and as documentation). FSOperations, please move the JSON conversion code to static methods like the others at the top of the file WebHDFS.md The anchor links are broken, I think incorrectly capitalized Although this is not related, could you add param documentation for "startAfter" as well? Or we can do it in a separate JIRA. Need to also define the StoragePolicies schema, see FileStatuses/FileStatus as an example
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Andrew Wang for review..

        v10 >

        Although this is not related, could you add param documentation for "startAfter" as well?

        I added doc for "startafter" param.

        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Andrew Wang for review.. v10 > Although this is not related, could you add param documentation for "startAfter" as well? I added doc for "startafter" param. Please review..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 28s Maven dependency ordering for branch
        +1 mvninstall 7m 49s trunk passed
        +1 compile 1m 27s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 53s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        -1 findbugs 1m 44s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
        +1 javadoc 1m 24s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        -1 mvninstall 0m 25s hadoop-hdfs-client in the patch failed.
        -1 mvninstall 0m 26s hadoop-hdfs in the patch failed.
        -1 compile 0m 26s hadoop-hdfs-project in the patch failed.
        -1 javac 0m 26s hadoop-hdfs-project in the patch failed.
        -0 checkstyle 0m 37s hadoop-hdfs-project: The patch generated 37 new + 666 unchanged - 6 fixed = 703 total (was 672)
        -1 mvnsite 0m 27s hadoop-hdfs-client in the patch failed.
        -1 mvnsite 0m 26s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 33s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 14s hadoop-hdfs-client in the patch failed.
        -1 findbugs 0m 26s hadoop-hdfs in the patch failed.
        -1 javadoc 0m 38s hadoop-hdfs-project_hadoop-hdfs generated 7 new + 8 unchanged - 0 fixed = 15 total (was 8)
        -1 unit 0m 26s hadoop-hdfs-client in the patch failed.
        -1 unit 0m 25s hadoop-hdfs in the patch failed.
        -1 unit 3m 22s hadoop-hdfs-httpfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        31m 2s



        Reason Tests
        Failed junit tests hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem
          hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841628/HDFS-8630.010.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 373b57b9951b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f885160
        Default Java 1.8.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17750/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17750/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 7m 49s trunk passed +1 compile 1m 27s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 53s trunk passed +1 mvneclipse 0m 38s trunk passed -1 findbugs 1m 44s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 24s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch -1 mvninstall 0m 25s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 26s hadoop-hdfs in the patch failed. -1 compile 0m 26s hadoop-hdfs-project in the patch failed. -1 javac 0m 26s hadoop-hdfs-project in the patch failed. -0 checkstyle 0m 37s hadoop-hdfs-project: The patch generated 37 new + 666 unchanged - 6 fixed = 703 total (was 672) -1 mvnsite 0m 27s hadoop-hdfs-client in the patch failed. -1 mvnsite 0m 26s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 14s hadoop-hdfs-client in the patch failed. -1 findbugs 0m 26s hadoop-hdfs in the patch failed. -1 javadoc 0m 38s hadoop-hdfs-project_hadoop-hdfs generated 7 new + 8 unchanged - 0 fixed = 15 total (was 8) -1 unit 0m 26s hadoop-hdfs-client in the patch failed. -1 unit 0m 25s hadoop-hdfs in the patch failed. -1 unit 3m 22s hadoop-hdfs-httpfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 31m 2s Reason Tests Failed junit tests hadoop.fs.http.client.TestHttpFSFWithSWebhdfsFileSystem   hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841628/HDFS-8630.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 373b57b9951b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-compile-hadoop-hdfs-project.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17750/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17750/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17750/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 7s Maven dependency ordering for branch
        +1 mvninstall 6m 54s trunk passed
        +1 compile 1m 20s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 1m 52s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings.
        +1 javadoc 1m 13s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 55s the patch passed
        +1 compile 1m 33s the patch passed
        +1 javac 1m 33s the patch passed
        -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 37 new + 666 unchanged - 6 fixed = 703 total (was 672)
        -1 mvnsite 0m 57s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 36s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 14s the patch passed
        +1 javadoc 1m 7s the patch passed
        +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
        +1 unit 89m 7s hadoop-hdfs in the patch passed.
        +1 unit 3m 22s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        123m 59s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841634/HDFS-8630.010.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ce8dd0f76de3 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f885160
        Default Java 1.8.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17751/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17751/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17751/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17751/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17751/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 1m 20s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 37s trunk passed -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 13s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 55s the patch passed +1 compile 1m 33s the patch passed +1 javac 1m 33s the patch passed -0 checkstyle 0m 42s hadoop-hdfs-project: The patch generated 37 new + 666 unchanged - 6 fixed = 703 total (was 672) -1 mvnsite 0m 57s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 14s the patch passed +1 javadoc 1m 7s the patch passed +1 unit 0m 55s hadoop-hdfs-client in the patch passed. +1 unit 89m 7s hadoop-hdfs in the patch passed. +1 unit 3m 22s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 123m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841634/HDFS-8630.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ce8dd0f76de3 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f885160 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/17751/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17751/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/17751/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17751/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17751/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        A couple tiny nits:

        • We need to update WebHDFS's Get All Storage Policies to say it returns a BlockStoragePolicies rather than BlockStoragePolicy. We also need a newline after this before starting the example code block. The "HTTP1.1 200 OK" line is missing spaces. Starting and ending brace need to be indented 8 times, not 7.
        • Need another space for Set Storage Policy curl example

        Please generate the site docs with "mvn site" and check this page. Otherwise I'm +1, thanks again for sticking with this Surendra!

        Show
        andrew.wang Andrew Wang added a comment - A couple tiny nits: We need to update WebHDFS's Get All Storage Policies to say it returns a BlockStoragePolicies rather than BlockStoragePolicy. We also need a newline after this before starting the example code block. The "HTTP1.1 200 OK" line is missing spaces. Starting and ending brace need to be indented 8 times, not 7. Need another space for Set Storage Policy curl example Please generate the site docs with "mvn site" and check this page. Otherwise I'm +1, thanks again for sticking with this Surendra!
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Andrew Wang for review..
        I attached updated patch and WebHDFS.html for this patch..

        Please review.

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Andrew Wang for review.. I attached updated patch and WebHDFS.html for this patch.. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 27s Maven dependency ordering for branch
        +1 mvninstall 7m 59s trunk passed
        +1 compile 1m 28s trunk passed
        +1 checkstyle 0m 43s trunk passed
        +1 mvnsite 1m 56s trunk passed
        +1 mvneclipse 0m 43s trunk passed
        +1 findbugs 3m 40s trunk passed
        +1 javadoc 1m 12s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 45s the patch passed
        +1 compile 1m 27s the patch passed
        +1 javac 1m 27s the patch passed
        -0 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 37 new + 665 unchanged - 5 fixed = 702 total (was 670)
        +1 mvnsite 1m 55s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 5s the patch passed
        +1 javadoc 1m 10s the patch passed
        +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
        -1 unit 94m 44s hadoop-hdfs in the patch failed.
        +1 unit 3m 21s hadoop-hdfs-httpfs in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        131m 6s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842213/HDFS-8630.011.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cf236ca6c773 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a793cec
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17789/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17789/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17789/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17789/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 7m 59s trunk passed +1 compile 1m 28s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 56s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 3m 40s trunk passed +1 javadoc 1m 12s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 45s the patch passed +1 compile 1m 27s the patch passed +1 javac 1m 27s the patch passed -0 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 37 new + 665 unchanged - 5 fixed = 702 total (was 670) +1 mvnsite 1m 55s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 5s the patch passed +1 javadoc 1m 10s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. -1 unit 94m 44s hadoop-hdfs in the patch failed. +1 unit 3m 21s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 131m 6s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842213/HDFS-8630.011.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cf236ca6c773 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a793cec Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17789/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17789/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17789/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17789/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        +1, committed this to trunk.

        Surendra, if you want this in branch-2/branch-2.8, could you provide a branch-2 patch? trunk patch doesn't apply quite cleanly.

        Show
        andrew.wang Andrew Wang added a comment - +1, committed this to trunk. Surendra, if you want this in branch-2/branch-2.8, could you provide a branch-2 patch? trunk patch doesn't apply quite cleanly.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10964 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10964/)
        HDFS-8630. WebHDFS : Support get/set/unset StoragePolicy. Contributed by (wang: rev ea2895f4ed5031809d856faa52e9de5b9501bdea)

        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/PostOpParam.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/PutOpParam.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/GetOpParam.java
        • (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/StoragePolicyParam.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSParametersProvider.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/WebHDFS.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10964 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10964/ ) HDFS-8630 . WebHDFS : Support get/set/unset StoragePolicy. Contributed by (wang: rev ea2895f4ed5031809d856faa52e9de5b9501bdea) (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/PostOpParam.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/PutOpParam.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/GetOpParam.java (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/StoragePolicyParam.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSParametersProvider.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/WebHDFS.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Andrew Wang.

        could you provide a branch-2 patch? trunk patch doesn't apply quite cleanly.

        yes, I will attach branch-2 patch soon

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Andrew Wang . could you provide a branch-2 patch? trunk patch doesn't apply quite cleanly. yes, I will attach branch-2 patch soon
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached branch-2 patch.
        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached branch-2 patch. Please review..
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 8m 47s branch-2 passed
        +1 compile 1m 17s branch-2 passed with JDK v1.8.0_111
        +1 compile 1m 23s branch-2 passed with JDK v1.7.0_121
        +1 checkstyle 0m 42s branch-2 passed
        +1 mvnsite 2m 7s branch-2 passed
        +1 mvneclipse 0m 44s branch-2 passed
        +1 findbugs 4m 3s branch-2 passed
        +1 javadoc 1m 28s branch-2 passed with JDK v1.8.0_111
        +1 javadoc 2m 13s branch-2 passed with JDK v1.7.0_121
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 31s the patch passed
        +1 compile 1m 10s the patch passed with JDK v1.8.0_111
        +1 javac 1m 10s the patch passed
        +1 compile 1m 20s the patch passed with JDK v1.7.0_121
        +1 javac 1m 20s the patch passed
        -0 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 37 new + 666 unchanged - 4 fixed = 703 total (was 670)
        +1 mvnsite 1m 58s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 36s the patch passed
        +1 javadoc 1m 18s the patch passed with JDK v1.8.0_111
        +1 javadoc 2m 7s the patch passed with JDK v1.7.0_121
        +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121.
        +1 unit 48m 31s hadoop-hdfs in the patch passed with JDK v1.7.0_121.
        +1 unit 3m 26s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        151m 24s



        Reason Tests
        JDK v1.8.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestCheckpoint
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842604/HDFS-8630-branch-2.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b0ca8e9c360a 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 73d5de5
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17811/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17811/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17811/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 8m 47s branch-2 passed +1 compile 1m 17s branch-2 passed with JDK v1.8.0_111 +1 compile 1m 23s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 42s branch-2 passed +1 mvnsite 2m 7s branch-2 passed +1 mvneclipse 0m 44s branch-2 passed +1 findbugs 4m 3s branch-2 passed +1 javadoc 1m 28s branch-2 passed with JDK v1.8.0_111 +1 javadoc 2m 13s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_111 +1 javac 1m 10s the patch passed +1 compile 1m 20s the patch passed with JDK v1.7.0_121 +1 javac 1m 20s the patch passed -0 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 37 new + 666 unchanged - 4 fixed = 703 total (was 670) +1 mvnsite 1m 58s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 36s the patch passed +1 javadoc 1m 18s the patch passed with JDK v1.8.0_111 +1 javadoc 2m 7s the patch passed with JDK v1.7.0_121 +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121. +1 unit 48m 31s hadoop-hdfs in the patch passed with JDK v1.7.0_121. +1 unit 3m 26s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 151m 24s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842604/HDFS-8630-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b0ca8e9c360a 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 73d5de5 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17811/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17811/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17811/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached branch-2.8 patch..
        Please review..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached branch-2.8 patch.. Please review..
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks Surendra, I've committed your patches to branch-2 and branch-2.8 as well. Resolving, thanks again for the contribution!

        Show
        andrew.wang Andrew Wang added a comment - Thanks Surendra, I've committed your patches to branch-2 and branch-2.8 as well. Resolving, thanks again for the contribution!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 2m 10s Maven dependency ordering for branch
        +1 mvninstall 7m 11s branch-2.8 passed
        +1 compile 1m 23s branch-2.8 passed with JDK v1.8.0_111
        +1 compile 1m 31s branch-2.8 passed with JDK v1.7.0_121
        +1 checkstyle 0m 34s branch-2.8 passed
        +1 mvnsite 2m 8s branch-2.8 passed
        +1 mvneclipse 0m 45s branch-2.8 passed
        +1 findbugs 4m 3s branch-2.8 passed
        +1 javadoc 1m 28s branch-2.8 passed with JDK v1.8.0_111
        +1 javadoc 2m 12s branch-2.8 passed with JDK v1.7.0_121
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 33s the patch passed
        +1 compile 1m 20s the patch passed with JDK v1.8.0_111
        +1 javac 1m 20s the patch passed
        +1 compile 1m 30s the patch passed with JDK v1.7.0_121
        +1 javac 1m 30s the patch passed
        -0 checkstyle 0m 31s hadoop-hdfs-project: The patch generated 31 new + 601 unchanged - 6 fixed = 632 total (was 607)
        +1 mvnsite 2m 1s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 4m 41s the patch passed
        +1 javadoc 1m 31s the patch passed with JDK v1.8.0_111
        +1 javadoc 2m 10s the patch passed with JDK v1.7.0_121
        +1 unit 1m 9s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121.
        -1 unit 72m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_121.
        +1 unit 3m 51s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        196m 45s



        Reason Tests
        JDK v1.8.0_111 Failed junit tests hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
        JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.web.TestWebHDFS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Issue HDFS-8630
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842622/HDFS-8630-branch-2.8-001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 36c69d8d3639 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / 40367c8
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17814/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/17814/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17814/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17814/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17814/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 2m 10s Maven dependency ordering for branch +1 mvninstall 7m 11s branch-2.8 passed +1 compile 1m 23s branch-2.8 passed with JDK v1.8.0_111 +1 compile 1m 31s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 34s branch-2.8 passed +1 mvnsite 2m 8s branch-2.8 passed +1 mvneclipse 0m 45s branch-2.8 passed +1 findbugs 4m 3s branch-2.8 passed +1 javadoc 1m 28s branch-2.8 passed with JDK v1.8.0_111 +1 javadoc 2m 12s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 1m 20s the patch passed with JDK v1.8.0_111 +1 javac 1m 20s the patch passed +1 compile 1m 30s the patch passed with JDK v1.7.0_121 +1 javac 1m 30s the patch passed -0 checkstyle 0m 31s hadoop-hdfs-project: The patch generated 31 new + 601 unchanged - 6 fixed = 632 total (was 607) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 35s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 4m 41s the patch passed +1 javadoc 1m 31s the patch passed with JDK v1.8.0_111 +1 javadoc 2m 10s the patch passed with JDK v1.7.0_121 +1 unit 1m 9s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121. -1 unit 72m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_121. +1 unit 3m 51s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 196m 45s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue HDFS-8630 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842622/HDFS-8630-branch-2.8-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 36c69d8d3639 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 40367c8 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17814/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/17814/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17814/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17814/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17814/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Thanks Andrew Wang for review and commit..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Thanks Andrew Wang for review and commit..

          People

          • Assignee:
            surendrasingh Surendra Singh Lilhore
            Reporter:
            nijel nijel
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development