Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8622

Implement GETCONTENTSUMMARY operation for WebImageViewer

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      it would be better for administrators if

       GETCONTENTSUMMARY 

      are supported.

      1. HDFS-8622-00.patch
        12 kB
        Jagadesh Kiran N
      2. HDFS-8622-01.patch
        12 kB
        Jagadesh Kiran N
      3. HDFS-8622-02.patch
        15 kB
        Jagadesh Kiran N
      4. HDFS-8622-03.patch
        14 kB
        Jagadesh Kiran N
      5. HDFS-8622-04.patch
        15 kB
        Jagadesh Kiran N
      6. HDFS-8622-05.patch
        16 kB
        Jagadesh Kiran N
      7. HDFS-8622-06.patch
        16 kB
        Jagadesh Kiran N
      8. HDFS-8622-07.patch
        16 kB
        Jagadesh Kiran N
      9. HDFS-8622-08.patch
        18 kB
        Jagadesh Kiran N
      10. HDFS-8622-09.patch
        17 kB
        Jagadesh Kiran N
      11. HDFS-8622-10.patch
        17 kB
        Jagadesh Kiran N

        Activity

        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Please find the Patch attached ,Review the same and let me know any changes to be done

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Please find the Patch attached ,Review the same and let me know any changes to be done
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 39s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 2m 59s Site still builds.
        -1 checkstyle 1m 20s The applied patch generated 5 new checkstyle issues (total was 123, now 128).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 160m 16s Tests failed in hadoop-hdfs.
            210m 15s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
          hadoop.hdfs.TestAppendSnapshotTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744738/HDFS-8622-00.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 47f4c54
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11669/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11669/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11669/testReport/
        Java 1.7.0_55
        uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11669/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. -1 checkstyle 1m 20s The applied patch generated 5 new checkstyle issues (total was 123, now 128). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 160m 16s Tests failed in hadoop-hdfs.     210m 15s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.TestAppendSnapshotTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744738/HDFS-8622-00.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 47f4c54 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11669/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11669/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11669/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11669/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Fixed the Check-style Errors,pls check

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Fixed the Check-style Errors,pls check
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 15s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 0s Site still builds.
        +1 checkstyle 0m 34s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 39s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 175m 23s Tests failed in hadoop-hdfs.
            222m 36s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
        Timed out tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744883/HDFS-8622-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 1ea3629
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11674/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11674/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11674/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11674/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 15s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 0m 34s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 175m 23s Tests failed in hadoop-hdfs.     222m 36s   Reason Tests Failed unit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Timed out tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744883/HDFS-8622-01.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 1ea3629 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11674/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11674/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11674/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11674/console This message was automatically generated.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Thanks for the patch Jagadesh Kiran N, few comments

        1) It seems empty directory case is not handled in the code. Please check and add test case for empty Directory too
        2) I think , getContentSummaryList should be getContentSummaryMap
        3) {{ getContentSummary(String path) }} javadoc need corrections
        4) Please use try with resources for file write in test code TestOfflineImageViewerForContentSummary#createOriginalFSImage

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Thanks for the patch Jagadesh Kiran N , few comments 1) It seems empty directory case is not handled in the code. Please check and add test case for empty Directory too 2) I think , getContentSummaryList should be getContentSummaryMap 3) {{ getContentSummary(String path) }} javadoc need corrections 4) Please use try with resources for file write in test code TestOfflineImageViewerForContentSummary#createOriginalFSImage
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        5) In HdfsImageViewer.md

        Show
        kanaka Kanaka Kumar Avvaru added a comment - 5) In HdfsImageViewer.md
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        In HdfsImageViewer.md there is an extra hash, WebHDFS.html##Get_Content_Summary_of_a_Directory) should be WebHDFS.html#Get_Content_Summary_of_a_Directory)

        Show
        kanaka Kanaka Kumar Avvaru added a comment - In HdfsImageViewer.md there is an extra hash, WebHDFS.html##Get_Content_Summary_of_a_Directory) should be WebHDFS.html#Get_Content_Summary_of_a_Directory)
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Kanaka Kumar Avvaru for your review , updated patch addresses all the comments mentioned .

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Kanaka Kumar Avvaru for your review , updated patch addresses all the comments mentioned .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 47s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 9m 41s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 2m 59s Site still builds.
        +1 checkstyle 1m 24s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 161m 39s Tests failed in hadoop-hdfs.
            212m 2s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744933/HDFS-8622-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / d7319de
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11677/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11677/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11677/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 checkstyle 1m 24s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 161m 39s Tests failed in hadoop-hdfs.     212m 2s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744933/HDFS-8622-02.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / d7319de hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11677/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11677/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11677/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi, the test case failing at "org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot.testDatanodeRestarts" is not related to any of the changes done in the Patch.

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi, the test case failing at "org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot.testDatanodeRestarts" is not related to any of the changes done in the Patch.
        Hide
        kanaka Kanaka Kumar Avvaru added a comment -

        Thanks for update Jagadesh Kiran N, "-02.patch" looks good for me. +1 (Non binding). Akira Ajisaka, please give your view.

        Show
        kanaka Kanaka Kumar Avvaru added a comment - Thanks for update Jagadesh Kiran N , "-02.patch" looks good for me. +1 (Non binding). Akira Ajisaka , please give your view.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for taking this issue and thanks Kanaka Kumar Avvaru for reviewing the patch. Here are my first comments in the test code. I'll try your patch and comment later.

              URL url = new URL("http://localhost:" + port
                  + "/webhdfs/v1/dir1/?op=GETCONTENTSUMMARY");
              HttpURLConnection connection = (HttpURLConnection) url.openConnection();
              connection.setRequestMethod("GET");
              connection.connect();
        

        1. Adding the above code for each test case is unnecessarily. We should do it once and assert that the response code is 200 in testGetContentSummaryResponseCode.

              assertEquals(fileSummaryFromDFS.getDirectoryCount(),
                  summary.getDirectoryCount());
              assertEquals(fileSummaryFromDFS.getFileCount(), summary.getFileCount());
              assertEquals(fileSummaryFromDFS.getLength(), summary.getLength());
              assertEquals(fileSummaryFromDFS.getSpaceConsumed(),
                  summary.getSpaceConsumed());
              assertEquals(fileSummaryFromDFS.getQuota(), summary.getQuota());
              assertEquals(fileSummaryFromDFS.getSpaceQuota(), summary.getSpaceQuota());
        

        2. Can we create a separate method for comparing ContentSummary to remove code duplication?
        3. throws IOException can be removed from @AfterClass.
        4. Would you remove unused variable contentSummary?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for taking this issue and thanks Kanaka Kumar Avvaru for reviewing the patch. Here are my first comments in the test code. I'll try your patch and comment later. URL url = new URL( "http: //localhost:" + port + "/webhdfs/v1/dir1/?op=GETCONTENTSUMMARY" ); HttpURLConnection connection = (HttpURLConnection) url.openConnection(); connection.setRequestMethod( "GET" ); connection.connect(); 1. Adding the above code for each test case is unnecessarily. We should do it once and assert that the response code is 200 in testGetContentSummaryResponseCode . assertEquals(fileSummaryFromDFS.getDirectoryCount(), summary.getDirectoryCount()); assertEquals(fileSummaryFromDFS.getFileCount(), summary.getFileCount()); assertEquals(fileSummaryFromDFS.getLength(), summary.getLength()); assertEquals(fileSummaryFromDFS.getSpaceConsumed(), summary.getSpaceConsumed()); assertEquals(fileSummaryFromDFS.getQuota(), summary.getQuota()); assertEquals(fileSummaryFromDFS.getSpaceQuota(), summary.getSpaceQuota()); 2. Can we create a separate method for comparing ContentSummary to remove code duplication? 3. throws IOException can be removed from @AfterClass . 4. Would you remove unused variable contentSummary ?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Tried your patch. Additional comments:
        1. ContentSummary should be recursive. For example, dir1 has subdirectory dir2 and file3 is in dir2, the ContentSummary of dir1 includes file3.
        2. Would you set quota in TestOfflineImageViewerForContentSummary.createOriginalFSImage?

        Show
        ajisakaa Akira Ajisaka added a comment - Tried your patch. Additional comments: 1. ContentSummary should be recursive. For example, dir1 has subdirectory dir2 and file3 is in dir2, the ContentSummary of dir1 includes file3. 2. Would you set quota in TestOfflineImageViewerForContentSummary.createOriginalFSImage ?
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Akira Ajisaka for your review, i will soon update the patch as per your comments

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Akira Ajisaka for your review, i will soon update the patch as per your comments
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Akira Ajisaka i have updated the patch except one comment. Please review the same
        1. Adding the above code for each test case is unnecessarily. We should do it once and assert that the response code is 200

         intestGetContentSummaryResponseCode. 

        Reason : Input is different for all test cases so common code is not possible here

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Akira Ajisaka i have updated the patch except one comment. Please review the same 1. Adding the above code for each test case is unnecessarily. We should do it once and assert that the response code is 200 intestGetContentSummaryResponseCode. Reason : Input is different for all test cases so common code is not possible here
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 4s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 0s Site still builds.
        +1 checkstyle 0m 37s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 2s Pre-build of native portion
        -1 hdfs tests 160m 51s Tests failed in hadoop-hdfs.
            207m 46s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746553/HDFS-8622-03.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 4025326
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11786/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11786/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11786/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 4s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 0m 37s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 2s Pre-build of native portion -1 hdfs tests 160m 51s Tests failed in hadoop-hdfs.     207m 46s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746553/HDFS-8622-03.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 4025326 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11786/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11786/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11786/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi, the test cases failing at

         org.apache.hadoop.hdfs.TestDistributedFileSystem.testDFSClientPeerWriteTimeout  

        &

         org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot.testDatanodeRestarts  

        is not related to any of the changes done in the Patch

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi, the test cases failing at org.apache.hadoop.hdfs.TestDistributedFileSystem.testDFSClientPeerWriteTimeout & org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot.testDatanodeRestarts is not related to any of the changes done in the Patch
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch.

        +      try (FSDataOutputStream o = hdfs.create(new Path(dir3, "file4"))) {
        +        o.write("1234".getBytes());
        +        o.close();
        +      }
        

        1. dir3 should be empty, so the above code should be removed.

        /**
         * Tests OfflineImageViewer if the input fsimage has contentSummary
         */
        

        2. WebImageViewer will support GETCONTENTSUMMARY for every fsimage, so would you update the sentence? For example, "Tests GETCONTENTSUMMARY operation for WebImageViewer."

              try (FSDataOutputStream o = hdfs.create(new Path(dir, "file1"))) {
                o.write("123".getBytes());
                o.close();
              }
        

        3. You need not call o.close() if the resource o is initialized in try-with-resources statement.

                if (fromINodeId(cid).getType() == INode.Type.DIRECTORY) {
                  fillDirSummary(cid, data);
                } else {
                  FsImageProto.INodeSection.INodeFile f = fromINodeId(cid).getFile();
                  long curLength = getFileSize(f);
                  data[1]++;
                  data[2] += curLength;
                  data[3] += (curLength) * (f.getReplication());
                }
        

        4. If the inode is FILE, fromINodeId(cid) will be called twice and that is costly. Would you update the patch as follows?

                INode inode = fromINodeId(cid);
                switch (inode.getType()) {
                case FILE:
                  ...
                case DIRECTORY:
                  ...
                default
                  ...
        

        That way we can skip SYMLINK.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. + try (FSDataOutputStream o = hdfs.create( new Path(dir3, "file4" ))) { + o.write( "1234" .getBytes()); + o.close(); + } 1. dir3 should be empty, so the above code should be removed. /** * Tests OfflineImageViewer if the input fsimage has contentSummary */ 2. WebImageViewer will support GETCONTENTSUMMARY for every fsimage, so would you update the sentence? For example, "Tests GETCONTENTSUMMARY operation for WebImageViewer." try (FSDataOutputStream o = hdfs.create( new Path(dir, "file1" ))) { o.write( "123" .getBytes()); o.close(); } 3. You need not call o.close() if the resource o is initialized in try-with-resources statement. if (fromINodeId(cid).getType() == INode.Type.DIRECTORY) { fillDirSummary(cid, data); } else { FsImageProto.INodeSection.INodeFile f = fromINodeId(cid).getFile(); long curLength = getFileSize(f); data[1]++; data[2] += curLength; data[3] += (curLength) * (f.getReplication()); } 4. If the inode is FILE , fromINodeId(cid) will be called twice and that is costly. Would you update the patch as follows? INode inode = fromINodeId(cid); switch (inode.getType()) { case FILE: ... case DIRECTORY: ... default ... That way we can skip SYMLINK .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        That way we can skip SYMLINK.

        More precisely, we can avoid calling inode.getFile() if the inode is symlink.

        Show
        ajisakaa Akira Ajisaka added a comment - That way we can skip SYMLINK . More precisely, we can avoid calling inode.getFile() if the inode is symlink.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Input is different for all test cases so common code is not possible here

        Okay. Would you add assertEquals(HttpURLConnection.HTTP_OK, connection.getResponseCode()); after connection.connect() for each test?

        Show
        ajisakaa Akira Ajisaka added a comment - Input is different for all test cases so common code is not possible here Okay. Would you add assertEquals(HttpURLConnection.HTTP_OK, connection.getResponseCode()); after connection.connect() for each test?
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka ,the patch addresses all comments , please check

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka ,the patch addresses all comments , please check
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 22m 4s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 27s There were no new javac warning messages.
        +1 javadoc 10m 25s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 7s Site still builds.
        +1 checkstyle 1m 30s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 23s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 7s Pre-build of native portion
        -1 hdfs tests 160m 14s Tests failed in hadoop-hdfs.
            214m 3s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDistributedFileSystem



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746808/HDFS-8622-04.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / ee98d63
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11807/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11807/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11807/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 22m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 27s There were no new javac warning messages. +1 javadoc 10m 25s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 7s Site still builds. +1 checkstyle 1m 30s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 7s Pre-build of native portion -1 hdfs tests 160m 14s Tests failed in hadoop-hdfs.     214m 3s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746808/HDFS-8622-04.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / ee98d63 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11807/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11807/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11807/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi the test case failure is not related to the changes done in the patch

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi the test case failure is not related to the changes done in the patch
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thank you for updating the patch, Jagadesh Kiran N. Now I have three comments about symlink.

        FSImageLoader.getContentSummaryMap
            default:
              return null;
        

        1. If a path is symlink, webhdfs.getContentSummary(path) fails by NPE. Would you set data appropriately?

        FSImageLoader.fillDirSummary
                } else {
                  FsImageProto.INodeSection.INodeFile f = node.getFile();
                  long curLength = getFileSize(f);
                  data[1]++;
                  data[2] += curLength;
                  data[3] += (curLength) * (f.getReplication());
                }
        

        2. The above code works well (FYI: Even if the node is symlink, any exception does not occur and only the data[1] will be incremented.), but it would be better to fix the code for improving readability using switch statement as follows:

          INode node = fromInodeId(cid);
          switch (node.getType()) {
          case DIRECTORY:
            ...
          case FILE:
            ...
          case SYMLINK:
            ...
          default:
            ...
          }
        

        3. Would you add a test case for symlink?

        Show
        ajisakaa Akira Ajisaka added a comment - Thank you for updating the patch, Jagadesh Kiran N . Now I have three comments about symlink. FSImageLoader.getContentSummaryMap default : return null ; 1. If a path is symlink, webhdfs.getContentSummary(path) fails by NPE. Would you set data appropriately? FSImageLoader.fillDirSummary } else { FsImageProto.INodeSection.INodeFile f = node.getFile(); long curLength = getFileSize(f); data[1]++; data[2] += curLength; data[3] += (curLength) * (f.getReplication()); } 2. The above code works well (FYI: Even if the node is symlink, any exception does not occur and only the data[1] will be incremented.), but it would be better to fix the code for improving readability using switch statement as follows: INode node = fromInodeId(cid); switch (node.getType()) { case DIRECTORY: ... case FILE: ... case SYMLINK: ... default : ... } 3. Would you add a test case for symlink?
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka regarding Symlink ,currently they are disabled as per my understanding (HADOOP-10020) ,do you think it will do some value add if i add code for content summary?,please let me know your views so that i can go a head

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka regarding Symlink ,currently they are disabled as per my understanding ( HADOOP-10020 ) ,do you think it will do some value add if i add code for content summary?,please let me know your views so that i can go a head
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        HADOOP-10052 this one also related to Symlink

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - HADOOP-10052 this one also related to Symlink
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh for the comment.

        do you think it will do some value add if i add code for content summary?

        It will make sense to me because we cannot expect when to enable the feature again. It would be better to prepare the code to support symlink.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh for the comment. do you think it will do some value add if i add code for content summary? It will make sense to me because we cannot expect when to enable the feature again. It would be better to prepare the code to support symlink.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka , i have updated the patch as per your comments , please check

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka , i have updated the patch as per your comments , please check
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 10s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 1s Site still builds.
        +1 checkstyle 0m 31s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 30s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 160m 43s Tests failed in hadoop-hdfs.
            207m 37s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747570/HDFS-8622-05.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / f170934
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11854/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11854/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11854/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 10s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 1s Site still builds. +1 checkstyle 0m 31s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 160m 43s Tests failed in hadoop-hdfs.     207m 37s   Reason Tests Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747570/HDFS-8622-05.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / f170934 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11854/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11854/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11854/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi the test case failure "org.apache.hadoop.hdfs.TestAppendSnapshotTruncate.testAST" is not related to the changes done in the patch

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi the test case failure "org.apache.hadoop.hdfs.TestAppendSnapshotTruncate.testAST" is not related to the changes done in the patch
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Mostly looks good to me. Minor comments:

        1. Would you reverse the order of setting content summary?

        +      data[2] = getFileSize(f);
        +      data[1] = 1;
        

        2. Would you make the variables private and remove symLinkDirSummaryFromDFS, which is unused?

        +  static ContentSummary summaryFromDFS = null;
        +  static ContentSummary emptyDirSummaryFromDFS = null;
        +  static ContentSummary fileSummaryFromDFS = null;
        +  static ContentSummary symLinkSummaryFromDFS = null;
        +  static ContentSummary symLinkDirSummaryFromDFS =null;
        
        Show
        ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Minor comments: 1. Would you reverse the order of setting content summary? + data[2] = getFileSize(f); + data[1] = 1; 2. Would you make the variables private and remove symLinkDirSummaryFromDFS, which is unused? + static ContentSummary summaryFromDFS = null ; + static ContentSummary emptyDirSummaryFromDFS = null ; + static ContentSummary fileSummaryFromDFS = null ; + static ContentSummary symLinkSummaryFromDFS = null ; + static ContentSummary symLinkDirSummaryFromDFS = null ;
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka updated and attached the patch as per your comments

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka updated and attached the patch as per your comments
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 19m 25s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 9s There were no new javac warning messages.
        +1 javadoc 10m 16s There were no new javadoc warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 4s Site still builds.
        +1 checkstyle 0m 36s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        +1 hdfs tests 163m 17s Tests passed in hadoop-hdfs.
            213m 13s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749007/HDFS-8622-06.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 154c9d2
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11916/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11916/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11916/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 25s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 9s There were no new javac warning messages. +1 javadoc 10m 16s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 site 3m 4s Site still builds. +1 checkstyle 0m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion +1 hdfs tests 163m 17s Tests passed in hadoop-hdfs.     213m 13s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749007/HDFS-8622-06.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 154c9d2 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11916/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11916/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11916/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Pre-Patch failures are not Related to the Patch submitted

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Pre-Patch failures are not Related to the Patch submitted
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch. Would you add a test case for a directory that has a symlink? I'm +1 if that is addressed.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. Would you add a test case for a directory that has a symlink? I'm +1 if that is addressed.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Akira Ajisaka for review, i have added the test case ,please check

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Akira Ajisaka for review, i have added the test case ,please check
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 26s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 9m 45s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 1s Site still builds.
        -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 123, now 124).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 1s Pre-build of native portion
        -1 hdfs tests 165m 23s Tests failed in hadoop-hdfs.
            215m 35s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
          hadoop.hdfs.server.datanode.TestDataNodeMetrics



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749089/HDFS-8622-07.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / e73a928
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11920/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11920/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11920/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11920/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 26s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 1s Site still builds. -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 123, now 124). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 1s Pre-build of native portion -1 hdfs tests 165m 23s Tests failed in hadoop-hdfs.     215m 35s   Reason Tests Failed unit tests hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.server.datanode.TestDataNodeMetrics Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749089/HDFS-8622-07.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / e73a928 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11920/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11920/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11920/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11920/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        The Test case Failures

          org.apache.hadoop.hdfs.TestRollingUpgrade.testFinalizeWithMultipleNN	 
         org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics.testDataNodeTimeSpend 
         org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot.testDatanodeRestarts  

        is not related to any of the changes done in the Patch

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - The Test case Failures org.apache.hadoop.hdfs.TestRollingUpgrade.testFinalizeWithMultipleNN org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics.testDataNodeTimeSpend org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot.testDatanodeRestarts is not related to any of the changes done in the Patch
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for the update. Two comments:

        1.

        Would you add a test case for a directory that has a symlink?

        In other words, would you add a test case to cover the following code?

        FSImageLoader#fillDirSummary
              case SYMLINK:
                data[1]++;
                break;
              }
        

        This test case is not for a symlink which links to a directory, but for a directory that has a simlink to something. I'm thinking it's sufficient to create a symlink in dir1, which links to a file (ex. file1).

        2.

        FSImageLoader#getContentSummaryMap
            case SYMLINK:
              data[0] = 0;
              data[1] = 1;
              data[2] = 0;
              nsQuota = -1;
              data[3] = data[2] * f.getReplication();
              spaceQuota = -1;
              return fillSummaryMap(spaceQuota, nsQuota, data);
        

        data[2] * f.getReplication() should be 0. I forgot to comment that.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for the update. Two comments: 1. Would you add a test case for a directory that has a symlink? In other words, would you add a test case to cover the following code? FSImageLoader#fillDirSummary case SYMLINK: data[1]++; break ; } This test case is not for a symlink which links to a directory, but for a directory that has a simlink to something. I'm thinking it's sufficient to create a symlink in dir1 , which links to a file (ex. file1 ). 2. FSImageLoader#getContentSummaryMap case SYMLINK: data[0] = 0; data[1] = 1; data[2] = 0; nsQuota = -1; data[3] = data[2] * f.getReplication(); spaceQuota = -1; return fillSummaryMap(spaceQuota, nsQuota, data); data[2] * f.getReplication() should be 0. I forgot to comment that.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka ,updated your comments.please review the patch

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka ,updated your comments.please review the patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 59s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 59s There were no new javac warning messages.
        +1 javadoc 9m 53s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 6s Site still builds.
        -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 123, now 124).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 22s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 10s Pre-build of native portion
        -1 hdfs tests 143m 31s Tests failed in hadoop-hdfs.
            195m 0s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDecommission
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
        Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749248/HDFS-8622-08.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / b6265d3
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11936/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11936/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11936/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11936/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 59s There were no new javac warning messages. +1 javadoc 9m 53s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 6s Site still builds. -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 123, now 124). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 10s Pre-build of native portion -1 hdfs tests 143m 31s Tests failed in hadoop-hdfs.     195m 0s   Reason Tests Failed unit tests hadoop.hdfs.TestDecommission   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749248/HDFS-8622-08.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / b6265d3 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11936/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11936/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11936/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11936/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thank you for the update. Some comments from me. (Mainly naming of the variables)

              Path parentDir = new Path("/dir1");
        

        1. I'm thinking the name of the variables should be the same as the name of the path for readability.

              Path targetDirForLinks = new Path("/targetDirForLinks");
        

        2. Since the directory is not a target of a symlink, dirForLinks is better for me.

              Path linkPath = new Path("/link1");
              Path linkPathDir = new Path("/linkdir");
              Path linkForDir = new Path("/targetDirForLinks/linkfordir1");
        

        3. I'm thinking linkPathDir and the related test is not necessary because the attribute of the target of a symlink is not related to the content summary of the symlink. For the naming, link1, link2, ... is sufficient for me.

              try (FSDataOutputStream o = hdfs.create(new Path(parentDir, "file4"))) {
                o.write("123".getBytes());
              }
              Path filePath = new Path(parentDir,"/file4");
        ...
              hdfs.createSymlink(filePath, linkPath, true);
        

        4. We can define the filePath first and re-use it, or we can create a symlink to file1 instead of defining filePath. The latter option is clear for me.

        5. Would you fix the checkstyle issue?

        Show
        ajisakaa Akira Ajisaka added a comment - Thank you for the update. Some comments from me. (Mainly naming of the variables) Path parentDir = new Path( "/dir1" ); 1. I'm thinking the name of the variables should be the same as the name of the path for readability. Path targetDirForLinks = new Path( "/targetDirForLinks" ); 2. Since the directory is not a target of a symlink, dirForLinks is better for me. Path linkPath = new Path( "/link1" ); Path linkPathDir = new Path( "/linkdir" ); Path linkForDir = new Path( "/targetDirForLinks/linkfordir1" ); 3. I'm thinking linkPathDir and the related test is not necessary because the attribute of the target of a symlink is not related to the content summary of the symlink. For the naming, link1, link2, ... is sufficient for me. try (FSDataOutputStream o = hdfs.create( new Path(parentDir, "file4" ))) { o.write( "123" .getBytes()); } Path filePath = new Path(parentDir, "/file4" ); ... hdfs.createSymlink(filePath, linkPath, true ); 4. We can define the filePath first and re-use it, or we can create a symlink to file1 instead of defining filePath . The latter option is clear for me. 5. Would you fix the checkstyle issue?
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka all review points are addressed in the patch .Please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka all review points are addressed in the patch .Please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 42s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 55s There were no new javac warning messages.
        +1 javadoc 9m 57s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 0s Site still builds.
        +1 checkstyle 1m 21s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 5s Pre-build of native portion
        -1 hdfs tests 175m 56s Tests failed in hadoop-hdfs.
            226m 52s  



        Reason Tests
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12749416/HDFS-8622-09.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 8f73bdd
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11945/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11945/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11945/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 1m 21s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 5s Pre-build of native portion -1 hdfs tests 175m 56s Tests failed in hadoop-hdfs.     226m 52s   Reason Tests Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749416/HDFS-8622-09.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 8f73bdd hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11945/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11945/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11945/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        THe Test failures "org.apache.hadoop.cli.TestHDFSCLI" are not related to the patch submitted .

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - THe Test failures "org.apache.hadoop.cli.TestHDFSCLI" are not related to the patch submitted .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch.

              hdfs.createSymlink(new Path("parentDir/file4"), link1, true);
        

        This path is "parentDir/file4", not equal to the path of file4 ("/parentDir/file4"). Would you add "/" before "parentDir/file4" or re-use file1OnParentDir instead of creating the same instance?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. hdfs.createSymlink( new Path( "parentDir/file4" ), link1, true ); This path is "parentDir/file4", not equal to the path of file4 ("/parentDir/file4"). Would you add "/" before "parentDir/file4" or re-use file1OnParentDir instead of creating the same instance?
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka updated the review comment. Pls check

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka updated the review comment. Pls check
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 4s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 49s There were no new javac warning messages.
        +1 javadoc 9m 44s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 2m 59s Site still builds.
        +1 checkstyle 1m 26s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 23s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 3s Pre-build of native portion
        -1 hdfs tests 176m 38s Tests failed in hadoop-hdfs.
            227m 40s  



        Reason Tests
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750079/HDFS-8622-10.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 1c12adb
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11981/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11981/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11981/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 checkstyle 1m 26s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 34s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 176m 38s Tests failed in hadoop-hdfs.     227m 40s   Reason Tests Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750079/HDFS-8622-10.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 1c12adb hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11981/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11981/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11981/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, the test failure looks unrelated to the patch. I ran the test successfully on my environment.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, the test failure looks unrelated to the patch. I ran the test successfully on my environment.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8292 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8292/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8292 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8292/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1016 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1016/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1016 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1016/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2213 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2213/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2213 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2213/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #275 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/275/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #275 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/275/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #283 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/283/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #283 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/283/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2232/)
        HDFS-8622. Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2232/ ) HDFS-8622 . Implement GETCONTENTSUMMARY operation for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev 40f815131e822f5b7a8e6a6827f4b85b31220c43) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForContentSummary.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I've committed this to trunk and branch-2. Thanks Jagadesh Kiran N for the continuous work!

        Show
        ajisakaa Akira Ajisaka added a comment - I've committed this to trunk and branch-2. Thanks Jagadesh Kiran N for the continuous work!

          People

          • Assignee:
            jagadesh.kiran Jagadesh Kiran N
            Reporter:
            jagadesh.kiran Jagadesh Kiran N
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development