Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fuse-dfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some applications (for us, the big one is rsync) will open a file in read-write mode when it really only intends to read xor write (not both). fuse-dfs should try to not fail until the application actually tries to write to a pre-existing file or read from a newly created file.

      1. HDFS-861.patch
        0.8 kB
        Brian Bockelman

        Activity

        Hide
        Brian Bockelman added a comment -

        This patch implements the proposed change. O_RDWR will work in a few cases; fuse-dfs respond with an error when you try to do a forbidden operation (such as writing to an existing file) instead of when you open it in the wrong mode.

        This is important for our community as it allows users to "rsync" from a remote system into HDFS; primarily, I am trying to get the patch and its licensing documented.

        Show
        Brian Bockelman added a comment - This patch implements the proposed change. O_RDWR will work in a few cases; fuse-dfs respond with an error when you try to do a forbidden operation (such as writing to an existing file) instead of when you open it in the wrong mode. This is important for our community as it allows users to "rsync" from a remote system into HDFS; primarily, I am trying to get the patch and its licensing documented.
        Hide
        Eli Collins added a comment -

        +1 Patch looks good to me, tested locally. Will have to revisit when fuse-dfs supports appends. Updated HDFS-861 to indicate this test needs to be added when TestFuseDFS is revived.

        Show
        Eli Collins added a comment - +1 Patch looks good to me, tested locally. Will have to revisit when fuse-dfs supports appends. Updated HDFS-861 to indicate this test needs to be added when TestFuseDFS is revived.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12429048/HDFS-861.patch
        against trunk revision 899456.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429048/HDFS-861.patch against trunk revision 899456. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/190/console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Brian!

        (The test failure is unrelated.)

        Show
        Tom White added a comment - I've just committed this. Thanks Brian! (The test failure is unrelated.)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #212 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/212/)
        . fuse-dfs does not support O_RDWR. Contributed by Brian Bockelman.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #212 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/212/ ) . fuse-dfs does not support O_RDWR. Contributed by Brian Bockelman.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/ )

          People

          • Assignee:
            Brian Bockelman
            Reporter:
            Brian Bockelman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development