[HDFS-8607] TestFileCorruption doesn't work as expected

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Walter Su
• Reporter: Walter Su
• Created: 15/Jun/15 10:12
• Updated: 30/Aug/16 01:32
• Resolved: 15/Jun/15 17:14

Description

Although it passes, it's useless.

 77  File[] blocks = data_dir.listFiles();
 78  assertTrue("Blocks do not exist in data-dir", (blocks != null) && (blocks.length > 0));
 79  for (int idx = 0; idx < blocks.length; idx++) {
 80    if (!blocks[idx].getName().startsWith(Block.BLOCK_FILE_PREFIX)) {
 81      continue;
 82    }
 83    System.out.println("Deliberately removing file "+blocks[idx].getName());
 84    assertTrue("Cannot remove file.", blocks[idx].delete());
 85  }

blocks are located at finalized/subdir0/subdir0, but line 77 only returns "subdir0" because File.listFiles() is not recursive. So line 83~84 will never be excuted.