Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7197 Enhancements to Mover
  3. HDFS-8541

Mover should exit with NO_MOVE_PROGRESS if there is no move progress

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: balancer & mover
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-8143 changed Mover to exit after some retry when failed to move blocks. Two additional suggestions:

      1. Mover retry counter should be incremented only if all moves fail. If there are some successful moves, the counter should be reset.
      2. Mover should exit with NO_MOVE_PROGRESS instead of IO_EXCEPTION in case of failure.
      1. HDFS-8541.patch
        3 kB
        Surendra Singh Lilhore
      2. HDFS-8541_1.patch
        6 kB
        Surendra Singh Lilhore
      3. HDFS-8541_2.patch
        6 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Tsz Wo Nicholas Sze for reporting this Improvement, I will update the path soon...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Tsz Wo Nicholas Sze for reporting this Improvement, I will update the path soon...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          I will attach the patch* soon...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - I will attach the patch* soon...
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached initial patch, please review.

          I think no need of test case, TestMover.testMoverFailedRetry() is enough.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached initial patch, please review. I think no need of test case, TestMover.testMoverFailedRetry() is enough.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Forgot to change exit state to NO_MOVE_PROGRESS?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Forgot to change exit state to NO_MOVE_PROGRESS?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Yes, updated the new patch. Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Yes, updated the new patch. Please review..
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 49s There were no new javac warning messages.
          +1 javadoc 9m 59s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 18s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 22s Pre-build of native portion
          -1 hdfs tests 163m 54s Tests failed in hadoop-hdfs.
              211m 50s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.TestReplaceDatanodeOnFailure



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12740044/HDFS-8541_1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ebb9a82
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11387/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11387/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11387/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11387/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 18s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 22s Pre-build of native portion -1 hdfs tests 163m 54s Tests failed in hadoop-hdfs.     211m 50s   Reason Tests Failed unit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestReplaceDatanodeOnFailure Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740044/HDFS-8541_1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ebb9a82 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11387/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11387/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11387/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11387/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Removed whitespace..

          Attached new patch, Please review ...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Removed whitespace.. Attached new patch, Please review ...
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8158 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8158/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8158 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8158/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Surendra!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Surendra!
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Tsz Wo Nicholas Sze for review and commit

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Tsz Wo Nicholas Sze for review and commit
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/256/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #256 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/256/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #986 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/986/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #986 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/986/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2183 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2183/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2183 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2183/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #244 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/244/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #244 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/244/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2202/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2202/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #254 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/254/)
          HDFS-8541. Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #254 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/254/ ) HDFS-8541 . Mover should exit with NO_MOVE_PROGRESS if there is no move progress. Contributed by Surendra Singh Lilhore (szetszwo: rev 9ef03a4c5bb5573eadc7d04e371c4af2dc6bae37) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              szetszwo Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development