[HDFS-8540] Mover should exit with NO_MOVE_BLOCK if no block can be moved

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: balancer & mover
• Hadoop Flags: Reviewed
• Assignee: Surendra Singh Lilhore
• Reporter: Tsz-wo Sze
• Created: 04/Jun/15 23:07
• Updated: 30/Aug/16 01:33
• Resolved: 16/Jun/15 00:04

Description

When there are files not satisfying their storage policy and no move is possible, Mover exits with SUCCESS. It should exit with NO_MOVE_BLOCK.

The bug seems in the following code. When StorageTypeDiff is not empty and scheduleMoves4Block return false, it does not update hasRemaining. Also, there is no indication of "No block can be moved" for the entire iteration.

//Mover.processFile(..)
        if (!diff.removeOverlap(true)) {
          if (scheduleMoves4Block(diff, lb, ecSchema)) {
            hasRemaining |= (diff.existing.size() > 1 &&
                diff.expected.size() > 1);
          }
        }

Issue Links

• relates to: HDFS-9151 Mover should print the exit status/reason on console like balancer tool.