Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The testSimple* test cases use artificial throttling in the output stream.

      The throttling does not look necessary to verify the correctness and the same code paths are exercised without the throttling.

      1. HDFS-8454.01.patch
        0.7 kB
        Arpit Agarwal

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Reduces the test run time from 160 to ~60 seconds on my dev machine.

        I think the throttling in testComplex is necessary to hit the target code paths so I left it alone.

        Show
        arpitagarwal Arpit Agarwal added a comment - Reduces the test run time from 160 to ~60 seconds on my dev machine. I think the throttling in testComplex is necessary to hit the target code paths so I left it alone.
        Hide
        wheat9 Haohui Mai added a comment -

        +1 pending jenkins

        Show
        wheat9 Haohui Mai added a comment - +1 pending jenkins
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 10s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 20s Pre-build of native portion
        -1 hdfs tests 160m 49s Tests failed in hadoop-hdfs.
            182m 26s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
          hadoop.hdfs.server.datanode.TestDeleteBlockPool



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734648/HDFS-8454.01.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 4513761
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11091/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11091/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11091/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 10s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 20s Pre-build of native portion -1 hdfs tests 160m 49s Tests failed in hadoop-hdfs.     182m 26s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.server.datanode.TestDeleteBlockPool Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734648/HDFS-8454.01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 4513761 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11091/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11091/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11091/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The test failures are unrelated.

        Thanks for the review Haohui. Committed for 2.8.0.

        Show
        arpitagarwal Arpit Agarwal added a comment - The test failures are unrelated. Thanks for the review Haohui. Committed for 2.8.0.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7888/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7888/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/935/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/935/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/)
        HDFS-8454. Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/ ) HDFS-8454 . Remove unnecessary throttling in TestDatanodeDeath. (Arpit Agarwal) (arp: rev cf2b5694d656f5807011b3d8c97ee999ad070d35) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeDeath.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            arpitagarwal Arpit Agarwal
            Reporter:
            arpitagarwal Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development