Details

    • Hadoop Flags:
      Reviewed

      Description

      Attached screenshot shows that hdfs could not find class 'crypto' for Windows.

      1. hdfs-8431.001.patch
        2 kB
        Anu Engineer
      2. hdfs-8431.002.patch
        2 kB
        Anu Engineer
      3. Screen Shot 2015-05-18 at 6.27.11 PM.png
        52 kB
        Sumana Sathish

        Activity

        Hide
        anu Anu Engineer added a comment -

        changed hdfs.cmd to support crypto command. This was added only in hdfs shell script and hence was not working on windows

        Hand tested on Windows 2012 server

        Show
        anu Anu Engineer added a comment - changed hdfs.cmd to support crypto command. This was added only in hdfs shell script and hence was not working on windows Hand tested on Windows 2012 server
        Hide
        cnauroth Chris Nauroth added a comment -

        Hi Anu. This looks good, and I can help test it.

        I have one minor nitpick. hdfs.cmd is much like the hdfs bash script on branch-2. (The cmd scripts haven't implemented the bash rewrite that was done on trunk.) I'd like to try to keep the cmd scripts as similar as possible to the branch-2 bash scripts. For consistency in the usage output, let's please move crypto after cacheadmin. That's how the commands are ordered in the bash script's usage message:

        https://github.com/apache/hadoop/blob/branch-2/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs#L68

        It looks like some other inconsistencies in the ordering have crept in, but don't worry about fixing those within the scope of this issue. We can just make sure the addition of crypto doesn't introduce a new inconsistency.

        Thanks!

        Show
        cnauroth Chris Nauroth added a comment - Hi Anu. This looks good, and I can help test it. I have one minor nitpick. hdfs.cmd is much like the hdfs bash script on branch-2. (The cmd scripts haven't implemented the bash rewrite that was done on trunk.) I'd like to try to keep the cmd scripts as similar as possible to the branch-2 bash scripts. For consistency in the usage output, let's please move crypto after cacheadmin . That's how the commands are ordered in the bash script's usage message: https://github.com/apache/hadoop/blob/branch-2/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs#L68 It looks like some other inconsistencies in the ordering have crept in, but don't worry about fixing those within the scope of this issue. We can just make sure the addition of crypto doesn't introduce a new inconsistency. Thanks!
        Hide
        anu Anu Engineer added a comment -

        will do, I did look at if there was any ordering and since I did not find any added it at the bottom in the help.

        Show
        anu Anu Engineer added a comment - will do, I did look at if there was any ordering and since I did not find any added it at the bottom in the help.
        Hide
        anu Anu Engineer added a comment -

        updated the patch based on code review comments

        Show
        anu Anu Engineer added a comment - updated the patch based on code review comments
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 25s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735734/hdfs-8431.002.patch
        Optional Tests  
        git revision trunk / 5450413
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11142/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735734/hdfs-8431.002.patch Optional Tests   git revision trunk / 5450413 Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11142/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 25s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735734/hdfs-8431.002.patch
        Optional Tests  
        git revision trunk / 5450413
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11145/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735734/hdfs-8431.002.patch Optional Tests   git revision trunk / 5450413 Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11145/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for the patch. I committed this to trunk and branch-2. Anu, thank you for the contribution.

        Show
        cnauroth Chris Nauroth added a comment - +1 for the patch. I committed this to trunk and branch-2. Anu, thank you for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7912 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7912/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7912 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7912/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/211/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/211/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #941 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/941/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #941 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/941/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2139 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2139/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2139 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2139/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #199 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/199/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #199 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/199/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #209 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/209/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #209 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/209/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2157 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2157/)
        HDFS-8431. hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2157 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2157/ ) HDFS-8431 . hdfs crypto class not found in Windows. Contributed by Anu Engineer. (cnauroth: rev 50eeea13000f0c82e0567410f0f8b611248f8c1b) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Sangjin Lee backported this to 2.6.1 after fixing minor conflicts.

        I just pushed the commit to 2.6.1 after running compilation.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Sangjin Lee backported this to 2.6.1 after fixing minor conflicts. I just pushed the commit to 2.6.1 after running compilation.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1.

        branch-2 patch applies cleanly. Ran compilation before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Just pulled this into branch-2.7 (release 2.7.2) as it already exists in 2.6.1. branch-2 patch applies cleanly. Ran compilation before the push.

          People

          • Assignee:
            anu Anu Engineer
            Reporter:
            ssathish@hortonworks.com Sumana Sathish
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development