Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8421

Move startFile() and related operations into FSDirWriteFileOp

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira proposes to move startFile() and related functions into FSDirWriteFileOp.

      1. HDFS-8421.000.patch
        27 kB
        Haohui Mai
      2. HDFS-8421.001.patch
        39 kB
        Haohui Mai
      3. HDFS-8421.002.patch
        39 kB
        Haohui Mai

        Activity

        Hide
        shv Konstantin Shvachko added a comment -

        Are you rewriting HDFS in C-style all statics?
        What is the reason for that? Previously commented here

        Show
        shv Konstantin Shvachko added a comment - Are you rewriting HDFS in C-style all statics? What is the reason for that? Previously commented here
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 33s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 10s The applied patch generated 8 new checkstyle issues (total was 280, now 286).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 163m 57s Tests failed in hadoop-hdfs.
            206m 34s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12733580/HDFS-8421.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 060c84e
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11034/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11034/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11034/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11034/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 10s The applied patch generated 8 new checkstyle issues (total was 280, now 286). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 163m 57s Tests failed in hadoop-hdfs.     206m 34s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733580/HDFS-8421.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 060c84e checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11034/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11034/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11034/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11034/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 43s There were no new javac warning messages.
        +1 javadoc 10m 0s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 16s The applied patch generated 14 new checkstyle issues (total was 422, now 432).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 8s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 27s Pre-build of native portion
        -1 hdfs tests 111m 42s Tests failed in hadoop-hdfs.
            155m 58s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
          hadoop.hdfs.TestModTime
          hadoop.fs.TestUrlStreamHandler
          hadoop.hdfs.security.TestDelegationToken
          hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolarent
          hadoop.hdfs.server.namenode.TestFileLimit
          hadoop.hdfs.TestParallelShortCircuitRead
          hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
          hadoop.hdfs.server.namenode.TestEditLogAutoroll
          hadoop.TestRefreshCallQueue
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.cli.TestCryptoAdminCLI
          hadoop.hdfs.TestSetrepDecreasing
          hadoop.hdfs.server.datanode.TestDiskError
          hadoop.fs.viewfs.TestViewFsWithAcls
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.namenode.TestFSEditLogLoader
          hadoop.hdfs.server.namenode.TestHostsFiles
          hadoop.hdfs.server.datanode.TestTransferRbw
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy
          hadoop.fs.contract.hdfs.TestHDFSContractDelete
          hadoop.hdfs.server.namenode.TestFileContextAcl
          hadoop.fs.TestFcHdfsSetUMask
          hadoop.fs.TestUnbuffer
          hadoop.hdfs.server.namenode.TestDeleteRace
          hadoop.hdfs.TestPread
          hadoop.hdfs.server.namenode.TestFSDirectory
          hadoop.fs.contract.hdfs.TestHDFSContractOpen
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
          hadoop.hdfs.server.datanode.TestBlockRecovery
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestReadWhileWriting
          hadoop.fs.contract.hdfs.TestHDFSContractMkdir
          hadoop.fs.contract.hdfs.TestHDFSContractAppend
          hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
          hadoop.hdfs.server.namenode.TestAuditLogger
          hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles
          hadoop.hdfs.TestWriteBlockGetsBlockLengthHint
          hadoop.hdfs.server.namenode.TestHDFSConcat
          hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
          hadoop.hdfs.server.datanode.TestCachingStrategy
          hadoop.hdfs.server.namenode.TestAddBlockRetry
          hadoop.fs.TestSymlinkHdfsFileSystem
          hadoop.fs.viewfs.TestViewFsDefaultValue
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.TestClientProtocolForPipelineRecovery
          hadoop.hdfs.TestFSInputChecker
          hadoop.hdfs.server.mover.TestStorageMover
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol
          hadoop.cli.TestAclCLI
          hadoop.hdfs.security.token.block.TestBlockToken
          hadoop.hdfs.server.namenode.ha.TestHAMetrics
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
          hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.server.datanode.TestReadOnlySharedStorage
          hadoop.hdfs.TestEncryptedTransfer
          hadoop.hdfs.tools.TestStoragePolicyCommands
          hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
          hadoop.hdfs.server.datanode.TestHSync
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.fs.contract.hdfs.TestHDFSContractSeek
          hadoop.hdfs.server.namenode.TestFileContextXAttr
          hadoop.hdfs.TestAbandonBlock
          hadoop.hdfs.server.namenode.TestAclConfigFlag
          hadoop.hdfs.TestFileCreationClient
          hadoop.hdfs.TestRemoteBlockReader2
          hadoop.hdfs.server.namenode.TestFSImageWithXAttr
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.TestFileAppendRestart
          hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
          hadoop.hdfs.server.namenode.TestFSImageWithAcl
          hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
          hadoop.hdfs.TestDFSShellGenericOptions
          hadoop.tracing.TestTracing
          hadoop.hdfs.tools.TestDFSZKFailoverController
          hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
          hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.TestBlockReaderLocalLegacy
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestParallelImageWrite
          hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
          hadoop.hdfs.TestFileConcurrentReader
          hadoop.fs.viewfs.TestViewFsWithXAttrs
          hadoop.hdfs.qjournal.TestNNWithQJM
          hadoop.hdfs.TestClose
          hadoop.hdfs.server.namenode.TestEditLogJournalFailures
          hadoop.hdfs.TestPersistBlocks
          hadoop.hdfs.TestDFSRollback
          hadoop.tools.TestJMXGet
          hadoop.hdfs.server.namenode.TestNameNodeMXBean
          hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
          hadoop.hdfs.tools.TestDebugAdmin
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
          hadoop.fs.contract.hdfs.TestHDFSContractCreate
          hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart
          hadoop.hdfs.TestWriteRead
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
          hadoop.fs.TestEnhancedByteBufferAccess
          hadoop.fs.TestFcHdfsPermission
          hadoop.fs.viewfs.TestViewFsHdfs
          hadoop.hdfs.TestDFSRename
          hadoop.fs.TestResolveHdfsSymlink
          hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps
          hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
          hadoop.tracing.TestTracingShortCircuitLocalRead
          hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
          hadoop.hdfs.TestParallelShortCircuitReadNoChecksum
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
          hadoop.hdfs.TestDecommission
          hadoop.hdfs.server.datanode.TestTriggerBlockReport
          hadoop.hdfs.server.namenode.TestINodeFile
          hadoop.hdfs.TestFSOutputSummer
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.TestFileLengthOnClusterRestart
          hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
          hadoop.hdfs.TestSetTimes
          hadoop.hdfs.server.namenode.TestQuotaByStorageType
          hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.fs.TestFcHdfsCreateMkdir
          hadoop.hdfs.TestAppendDifferentChecksum
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
          hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
          hadoop.hdfs.server.namenode.TestBlockUnderConstruction
          hadoop.hdfs.server.mover.TestMover
          hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
          hadoop.hdfs.TestDFSFinalize
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
          hadoop.hdfs.TestFileAppend2
          hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
          hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.TestStorageRestore
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.fs.viewfs.TestViewFileSystemWithXAttrs
          hadoop.hdfs.server.namenode.ha.TestHAFsck
          hadoop.fs.viewfs.TestViewFileSystemWithAcls
          hadoop.hdfs.server.namenode.TestXAttrConfigFlag
          hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
          hadoop.hdfs.TestFsShellPermission
          hadoop.hdfs.TestFileAppend3
          hadoop.hdfs.TestDFSInputStream
          hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
          hadoop.hdfs.TestQuota
          hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
          hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
          hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
          hadoop.hdfs.server.namenode.TestSnapshotPathINodes
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
          hadoop.security.TestPermission
          hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
          hadoop.fs.contract.hdfs.TestHDFSContractConcat
          hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
          hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
          hadoop.hdfs.server.namenode.TestFsck
          hadoop.hdfs.server.namenode.TestAuditLogs
          hadoop.hdfs.TestListFilesInFileContext
          hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
          hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
          hadoop.security.TestPermissionSymlinks
          hadoop.hdfs.TestRenameWhileOpen
          hadoop.hdfs.server.blockmanagement.TestSequentialBlockId
          hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.TestParallelUnixDomainRead
          hadoop.cli.TestXAttrCLI
          hadoop.hdfs.server.namenode.TestNameEditsConfigs
          hadoop.hdfs.TestEncryptionZonesWithHA
          hadoop.hdfs.TestFileCreationEmpty
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.fs.contract.hdfs.TestHDFSContractRename
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
          hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles
          hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
          hadoop.fs.permission.TestStickyBit
          hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
          hadoop.hdfs.TestDFSStartupVersions
          hadoop.hdfs.TestFileCreation
          hadoop.hdfs.server.namenode.ha.TestHASafeMode
          hadoop.hdfs.TestMissingBlocksAlert
          hadoop.hdfs.server.namenode.TestSecureNameNode
          hadoop.hdfs.server.namenode.snapshot.TestSnapshot
          hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot
          hadoop.hdfs.server.namenode.TestStartup
          hadoop.hdfs.server.namenode.TestNameNodeRecovery
          hadoop.hdfs.TestRead
          hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
          hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.server.datanode.TestDeleteBlockPool
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
          hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
          hadoop.hdfs.TestBlockReaderFactory
          hadoop.hdfs.server.namenode.TestINodeAttributeProvider
          hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
          hadoop.hdfs.TestPipelines
          hadoop.fs.loadGenerator.TestLoadGenerator
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
          hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
          hadoop.hdfs.TestFileCorruption
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.fs.TestHDFSFileContextMainOperations
          hadoop.hdfs.server.namenode.TestSaveNamespace
          hadoop.fs.TestGlobPaths
          hadoop.fs.viewfs.TestViewFsFileStatusHdfs
          hadoop.hdfs.server.namenode.TestMetaSave
          hadoop.hdfs.server.blockmanagement.TestPendingReplication
          hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
          hadoop.fs.viewfs.TestViewFsAtHdfsRoot
          hadoop.hdfs.server.datanode.TestIncrementalBrVariations
          hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.server.namenode.TestBackupNode
          hadoop.hdfs.server.namenode.TestNameNodeAcl
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.fs.shell.TestHdfsTextCommand
          hadoop.hdfs.TestLargeBlock
          hadoop.cli.TestHDFSCLI
          hadoop.hdfs.TestReplaceDatanodeOnFailure
          hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
          hadoop.fs.TestSymlinkHdfsDisable
          hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
          hadoop.hdfs.server.namenode.TestFSImage
          hadoop.fs.viewfs.TestViewFileSystemHdfs
          hadoop.hdfs.server.namenode.TestAddBlock
          hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.TestDFSInotifyEventInputStream
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
          hadoop.hdfs.TestLease
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
          hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
          hadoop.hdfs.server.namenode.TestNameNodeXAttr
          hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
          hadoop.hdfs.server.namenode.TestCheckpoint
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
          hadoop.hdfs.server.namenode.ha.TestDNFencing
          hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
          hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12733661/HDFS-8421.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0790275
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11040/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11040/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11040/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11040/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 16s The applied patch generated 14 new checkstyle issues (total was 422, now 432). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 8s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 27s Pre-build of native portion -1 hdfs tests 111m 42s Tests failed in hadoop-hdfs.     155m 58s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.TestModTime   hadoop.fs.TestUrlStreamHandler   hadoop.hdfs.security.TestDelegationToken   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolarent   hadoop.hdfs.server.namenode.TestFileLimit   hadoop.hdfs.TestParallelShortCircuitRead   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.TestRefreshCallQueue   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.cli.TestCryptoAdminCLI   hadoop.hdfs.TestSetrepDecreasing   hadoop.hdfs.server.datanode.TestDiskError   hadoop.fs.viewfs.TestViewFsWithAcls   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.TestFSEditLogLoader   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.server.datanode.TestTransferRbw   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistPolicy   hadoop.fs.contract.hdfs.TestHDFSContractDelete   hadoop.hdfs.server.namenode.TestFileContextAcl   hadoop.fs.TestFcHdfsSetUMask   hadoop.fs.TestUnbuffer   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.TestPread   hadoop.hdfs.server.namenode.TestFSDirectory   hadoop.fs.contract.hdfs.TestHDFSContractOpen   hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestReadWhileWriting   hadoop.fs.contract.hdfs.TestHDFSContractMkdir   hadoop.fs.contract.hdfs.TestHDFSContractAppend   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.server.namenode.TestAuditLogger   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles   hadoop.hdfs.TestWriteBlockGetsBlockLengthHint   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.datanode.TestCachingStrategy   hadoop.hdfs.server.namenode.TestAddBlockRetry   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.fs.viewfs.TestViewFsDefaultValue   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.TestClientProtocolForPipelineRecovery   hadoop.hdfs.TestFSInputChecker   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistLockedMemory   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.fsdataset.impl.TestInterDatanodeProtocol   hadoop.cli.TestAclCLI   hadoop.hdfs.security.token.block.TestBlockToken   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.datanode.TestReadOnlySharedStorage   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.tools.TestStoragePolicyCommands   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks   hadoop.hdfs.server.datanode.TestHSync   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.fs.contract.hdfs.TestHDFSContractSeek   hadoop.hdfs.server.namenode.TestFileContextXAttr   hadoop.hdfs.TestAbandonBlock   hadoop.hdfs.server.namenode.TestAclConfigFlag   hadoop.hdfs.TestFileCreationClient   hadoop.hdfs.TestRemoteBlockReader2   hadoop.hdfs.server.namenode.TestFSImageWithXAttr   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.TestFileAppendRestart   hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot   hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.hdfs.TestDFSShellGenericOptions   hadoop.tracing.TestTracing   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestBlockReaderLocalLegacy   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestParallelImageWrite   hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot   hadoop.hdfs.TestFileConcurrentReader   hadoop.fs.viewfs.TestViewFsWithXAttrs   hadoop.hdfs.qjournal.TestNNWithQJM   hadoop.hdfs.TestClose   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.TestDFSRollback   hadoop.tools.TestJMXGet   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN   hadoop.hdfs.tools.TestDebugAdmin   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.fs.contract.hdfs.TestHDFSContractCreate   hadoop.hdfs.server.datanode.fsdataset.impl.TestDatanodeRestart   hadoop.hdfs.TestWriteRead   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation   hadoop.fs.TestEnhancedByteBufferAccess   hadoop.fs.TestFcHdfsPermission   hadoop.fs.viewfs.TestViewFsHdfs   hadoop.hdfs.TestDFSRename   hadoop.fs.TestResolveHdfsSymlink   hadoop.hdfs.server.namenode.metrics.TestNNMetricFilesInGetListingOps   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.tracing.TestTracingShortCircuitLocalRead   hadoop.hdfs.server.blockmanagement.TestNameNodePrunesMissingStorages   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestParallelShortCircuitReadNoChecksum   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration   hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.TestFSOutputSummer   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs   hadoop.hdfs.TestSetTimes   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.balancer.TestBalancer   hadoop.fs.TestFcHdfsCreateMkdir   hadoop.hdfs.TestAppendDifferentChecksum   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.TestDFSFinalize   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestStorageRestore   hadoop.hdfs.server.namenode.TestEditLog   hadoop.fs.viewfs.TestViewFileSystemWithXAttrs   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.fs.viewfs.TestViewFileSystemWithAcls   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.TestFileAppend3   hadoop.hdfs.TestDFSInputStream   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.TestQuota   hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot   hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.security.TestPermission   hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup   hadoop.fs.contract.hdfs.TestHDFSContractConcat   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.TestListFilesInFileContext   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.server.namenode.TestSecondaryNameNodeUpgrade   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.security.TestPermissionSymlinks   hadoop.hdfs.TestRenameWhileOpen   hadoop.hdfs.server.blockmanagement.TestSequentialBlockId   hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.TestParallelUnixDomainRead   hadoop.cli.TestXAttrCLI   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.TestFileCreationEmpty   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.fs.contract.hdfs.TestHDFSContractRename   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.fs.permission.TestStickyBit   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.TestDFSStartupVersions   hadoop.hdfs.TestFileCreation   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.namenode.TestNameNodeRecovery   hadoop.hdfs.TestRead   hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDeleteBlockPool   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.TestBlockReaderFactory   hadoop.hdfs.server.namenode.TestINodeAttributeProvider   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.TestPipelines   hadoop.fs.loadGenerator.TestLoadGenerator   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.fs.TestHDFSFileContextMainOperations   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.fs.TestGlobPaths   hadoop.fs.viewfs.TestViewFsFileStatusHdfs   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.blockmanagement.TestPendingReplication   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.fs.viewfs.TestViewFsAtHdfsRoot   hadoop.hdfs.server.datanode.TestIncrementalBrVariations   hadoop.hdfs.server.balancer.TestBalancerWithSaslDataTransfer   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.fs.shell.TestHdfsTextCommand   hadoop.hdfs.TestLargeBlock   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd   hadoop.fs.TestSymlinkHdfsDisable   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.server.namenode.TestFSImage   hadoop.fs.viewfs.TestViewFileSystemHdfs   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.TestDFSInotifyEventInputStream   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing   hadoop.hdfs.TestLease   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733661/HDFS-8421.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0790275 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11040/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11040/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11040/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11040/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 35s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 18s The applied patch generated 14 new checkstyle issues (total was 422, now 432).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 16s Pre-build of native portion
        -1 hdfs tests 163m 14s Tests failed in hadoop-hdfs.
            206m 13s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12733661/HDFS-8421.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / de30d66
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11050/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11050/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11050/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11050/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 35s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 18s The applied patch generated 14 new checkstyle issues (total was 422, now 432). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion -1 hdfs tests 163m 14s Tests failed in hadoop-hdfs.     206m 13s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733661/HDFS-8421.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / de30d66 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11050/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11050/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11050/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11050/console This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -
        1. We do not need to remove the following check from the beginning of the startFile call.
          checkOperation(OperationCategory.WRITE);
          
        2. The safemode check should only be in the real file creation section
        3. The following log seems unnecessary to me: in case of Standby NN this change will cause a lot of warning msg in the log
          +    } catch (IOException e) {
          +      NameNode.stateChangeLog.warn("DIR* NameSystem.startFile: " + src + " " +
          +          e.getMessage());
          
        Show
        jingzhao Jing Zhao added a comment - We do not need to remove the following check from the beginning of the startFile call. checkOperation(OperationCategory.WRITE); The safemode check should only be in the real file creation section The following log seems unnecessary to me: in case of Standby NN this change will cause a lot of warning msg in the log + } catch (IOException e) { + NameNode.stateChangeLog.warn( "DIR* NameSystem.startFile: " + src + " " + + e.getMessage());
        Hide
        jingzhao Jing Zhao added a comment -

        +1 after addressing the comments.

        Show
        jingzhao Jing Zhao added a comment - +1 after addressing the comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 59s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 42s There were no new javac warning messages.
        +1 javadoc 9m 55s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 52s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 19s Pre-build of native portion
        +1 hdfs tests 163m 40s Tests passed in hadoop-hdfs.
            206m 6s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734312/HDFS-8421.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fb6b38d
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11071/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11071/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11071/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 52s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 19s Pre-build of native portion +1 hdfs tests 163m 40s Tests passed in hadoop-hdfs.     206m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734312/HDFS-8421.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fb6b38d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11071/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11071/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11071/console This message was automatically generated.
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Jing for the reviews.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Jing for the reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7883 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7883/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7883 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7883/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/935/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #935 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/935/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/204/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2133 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2133/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/193/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/203/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/)
        HDFS-8421. Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2151 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2151/ ) HDFS-8421 . Move startFile() and related functions into FSDirWriteFileOp. Contributed by Haohui Mai. (wheat9: rev 2b6bcfdafa91223a4116e3e9304579f5f91dccac) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java

          People

          • Assignee:
            wheat9 Haohui Mai
            Reporter:
            wheat9 Haohui Mai
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development