[HDFS-8407] libhdfs hdfsListDirectory must set errno to 0 on success

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: native
• Target Version/s: 2.8.0
• Assignee: Masatake Iwasaki
• Reporter: Juan Yu
• Created: 15/May/15 04:01
• Updated: 30/Aug/16 01:34
• Resolved: 28/May/15 18:39

Description

The documentation says it returns NULL on error, but it could also return NULL when the directory is empty.
/**

• hdfsListDirectory - Get list of files/directories for a given
• directory-path. hdfsFreeFileInfo should be called to deallocate memory.
• @param fs The configured filesystem handle.
• @param path The path of the directory.
• @param numEntries Set to the number of files/directories in path.
• @return Returns a dynamically-allocated array of hdfsFileInfo
• objects; NULL on error.
  */

      hdfsFileInfo *pathList = NULL; 
      ...
      //Figure out the number of entries in that directory
      jPathListSize = (*env)->GetArrayLength(env, jPathList);
      if (jPathListSize == 0) {
          ret = 0;
          goto done;
      }
      ...
      if (ret) {
          hdfsFreeFileInfo(pathList, jPathListSize);
          errno = ret;
          return NULL;
      }
      *numEntries = jPathListSize;
      return pathList;
  
  

Either change the implementation to match the doc, or fix the doc to match the implementation.