Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8405

Fix a typo in NamenodeFsck

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
        • Component/s: namenode
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          DFSConfigKeys.DFS_NAMENODE_REPLICATION_MIN_KEY below should not be quoted.

                    res.append("\n  ").append("DFSConfigKeys.DFS_NAMENODE_REPLICATION_MIN_KEY:\t")
             .append(minReplication);
          1. Text File
            HDFS-8405.1.patch
            7 kB
            Takanobu Asanuma

            Issue Links

            is broken by

            Improvement - An improvement or enhancement to an existing feature or task. HDFS-7537 fsck is confusing when dfs.namenode.replication.min > 1 && missing replicas && NN restart

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              tasanuma0829 Takanobu Asanuma added a comment -

              I uploaded an initial patch. I also did refactor to remove an unnecessary parameter of NamenodeFsck(). Please review it.

              Show
              tasanuma0829 Takanobu Asanuma added a comment - I uploaded an initial patch. I also did refactor to remove an unnecessary parameter of NamenodeFsck(). Please review it.
              Hide
              Permalink
              szetszwo Tsz Wo Nicholas Sze added a comment -

              +1 patch looks good.

              Show
              szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
              +1 javac 7m 28s There were no new javac warning messages.
              +1 javadoc 9m 42s There were no new javadoc warning messages.
              +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 0m 50s There were no new checkstyle issues.
              -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
              +1 install 1m 35s mvn install still works.
              +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
              +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
              +1 native 3m 14s Pre-build of native portion
              +1 hdfs tests 164m 15s Tests passed in hadoop-hdfs.
                  205m 49s  



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12733487/HDFS-8405.1.patch
              Optional Tests javadoc javac unit findbugs checkstyle
              git revision trunk / 363c355
              whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11029/artifact/patchprocess/whitespace.txt
              hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11029/artifact/patchprocess/testrun_hadoop-hdfs.txt
              Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11029/testReport/
              Java 1.7.0_55
              uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11029/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 50s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 164m 15s Tests passed in hadoop-hdfs.     205m 49s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733487/HDFS-8405.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 363c355 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11029/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11029/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11029/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11029/console This message was automatically generated.
              Hide
              Permalink
              szetszwo Tsz Wo Nicholas Sze added a comment -

              I have committed this. Thanks, Asanuma-san!

              Show
              szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Asanuma-san!
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-trunk-Commit #7855 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7855/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7855 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7855/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              tasanuma0829 Takanobu Asanuma added a comment -

              Thank you very much, Nicholas!

              Show
              tasanuma0829 Takanobu Asanuma added a comment - Thank you very much, Nicholas!
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Yarn-trunk #932 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/932/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #932 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/932/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/201/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/201/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk #2130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2130/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2130/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/190/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/190/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/200/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/200/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Mapreduce-trunk #2148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2148/)
              HDFS-8405. Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2148/ ) HDFS-8405 . Fix a typo in NamenodeFsck. Contributed by Takanobu Asanuma (szetszwo: rev 0c590e1c097462979f7ee054ad9121345d58655b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FsckServlet.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java

                People

                • Assignee:
                  tasanuma0829 Takanobu Asanuma
                  Reporter:
                  szetszwo Tsz Wo Nicholas Sze
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development