Details
Description
- Following log is confusing, make it tidy. Its missing break; statement and causing this unwanted logs.
2015-05-10 15:06:45,878 INFO datanode.DataNode (BPOfferService.java:processCommandFromActive(728)) - DatanodeCommand action: DNA_ERASURE_CODING_RECOVERY 2015-05-10 15:06:45,879 WARN datanode.DataNode (BPOfferService.java:processCommandFromActive(732)) - Unknown DatanodeCommand action: 11
- Add exception trace to the log, would improve debuggability
} catch (Throwable e) { LOG.warn("Failed to recover striped block: " + blockGroup); }
- Make member variables present in ErasureCodingWorker, ReconstructAndTransferBlock, StripedReader private final
- Correct spelling of the variable STRIPED_READ_TRHEAD_POOL to STRIPED_READ_THREAD_POOL
- Good to add debug logs to print the striped read pool size
LOG.debug("Using striped reads; pool threads=" + num);
- Add meaningful message to the precondition check:
Preconditions.checkArgument(liveIndices.length == sources.length);
- Remove unused import
import org.apache.hadoop.hdfs.server.common.HdfsServerConstants;