[HDFS-8321] CacheDirectives and CachePool operations should throw RetriableException in safemode

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Labels: BB2015-05-TBR
• Hadoop Flags: Reviewed
• Assignee: Haohui Mai
• Reporter: Haohui Mai
• Created: 05/May/15 01:43
• Updated: 30/Aug/16 04:34
• Resolved: 08/May/15 01:17

Description

Operations such as addCacheDirectives() throws SafeModeException when the NN is in safemode:

      if (isInSafeMode()) {
        throw new SafeModeException(
            "Cannot add cache directive", safeMode);
      }

While other NN operations throws RetriableException when HA is enabled:

  void checkNameNodeSafeMode(String errorMsg)
      throws RetriableException, SafeModeException {
    if (isInSafeMode()) {
      SafeModeException se = new SafeModeException(errorMsg, safeMode);
      if (haEnabled && haContext != null
          && haContext.getState().getServiceState() == HAServiceState.ACTIVE
          && shouldRetrySafeMode(this.safeMode)) {
        throw new RetriableException(se);
      } else {
        throw se;
      }
    }
  }