Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8273

FSNamesystem#Delete() should not call logSync() when holding the lock

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Blocker
        • Resolution: Fixed
        • Affects Version/s: 2.7.0
        • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
        • Component/s: namenode
        • Labels:
          None
        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          HDFS-7573 moves the logSync call inside of the write lock by accident. We should move it out.

          1. Text File
            HDFS-8273.000.patch
            2 kB
            Haohui Mai
          2. Text File
            HDFS-8273.001.patch
            4 kB
            Haohui Mai

            Issue Links

            is broken by

            Sub-task - The sub-task of the issue HDFS-7573 Consolidate the implementation of delete() into a single class

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 14m 46s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              +1 javac 7m 30s There were no new javac warning messages.
              +1 javadoc 9m 37s There were no new javadoc warning messages.
              +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 7m 13s There were no new checkstyle issues.
              +1 install 1m 40s mvn install still works.
              +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
              +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
              +1 native 3m 14s Pre-build of native portion
              -1 hdfs tests 188m 56s Tests failed in hadoop-hdfs.
                  237m 5s  



              Reason Tests
              Failed unit tests hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
              Timed out tests org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12728674/HDFS-8273.000.patch
              Optional Tests javadoc javac unit findbugs checkstyle
              git revision trunk / feb68cb
              hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10422/artifact/patchprocess/testrun_hadoop-hdfs.txt
              Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10422/testReport/
              Java 1.7.0_55
              uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10422/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 7m 13s There were no new checkstyle issues. +1 install 1m 40s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 188m 56s Tests failed in hadoop-hdfs.     237m 5s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics Timed out tests org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728674/HDFS-8273.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / feb68cb hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10422/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10422/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10422/console This message was automatically generated.
              Hide
              Permalink
              jingzhao Jing Zhao added a comment -
              1. We should also move the removeBlocks call out of the write lock in clearCorruptLazyPersistFiles
              2. logSync should be called before removeBlocks. Otherwise we may have data loss if logSync fails while block invalidation commands have been sent out to DNs.
              3. We may need to fix TestNameNodeMetrics.
              Show
              jingzhao Jing Zhao added a comment - We should also move the removeBlocks call out of the write lock in clearCorruptLazyPersistFiles logSync should be called before removeBlocks . Otherwise we may have data loss if logSync fails while block invalidation commands have been sent out to DNs. We may need to fix TestNameNodeMetrics .
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 14m 29s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              +1 javac 7m 27s There were no new javac warning messages.
              +1 javadoc 9m 33s There were no new javadoc warning messages.
              +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 7m 46s There were no new checkstyle issues.
              +1 install 1m 32s mvn install still works.
              +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
              +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
              +1 native 3m 14s Pre-build of native portion
              -1 hdfs tests 163m 40s Tests failed in hadoop-hdfs.
                  211m 44s  



              Reason Tests
              Failed unit tests hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12728919/HDFS-8273.001.patch
              Optional Tests javadoc javac unit findbugs checkstyle
              git revision trunk / bc1bd7e
              hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10435/artifact/patchprocess/testrun_hadoop-hdfs.txt
              Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10435/testReport/
              Java 1.7.0_55
              uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10435/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 7m 46s There were no new checkstyle issues. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 163m 40s Tests failed in hadoop-hdfs.     211m 44s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728919/HDFS-8273.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bc1bd7e hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10435/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10435/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10435/console This message was automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              +1 javac 7m 27s There were no new javac warning messages.
              +1 javadoc 9m 35s There were no new javadoc warning messages.
              +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 7m 13s There were no new checkstyle issues.
              +1 install 1m 33s mvn install still works.
              +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
              +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
              +1 native 3m 14s Pre-build of native portion
              +1 hdfs tests 164m 40s Tests passed in hadoop-hdfs.
                  212m 19s  



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12728929/HDFS-8273.001.patch
              Optional Tests javadoc javac unit findbugs checkstyle
              git revision trunk / 5190923
              hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10436/artifact/patchprocess/testrun_hadoop-hdfs.txt
              Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10436/testReport/
              Java 1.7.0_55
              uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10436/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 7m 13s There were no new checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 164m 40s Tests passed in hadoop-hdfs.     212m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728929/HDFS-8273.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5190923 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10436/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10436/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10436/console This message was automatically generated.
              Hide
              Permalink
              jingzhao Jing Zhao added a comment -

              +1 for the latest patch. Thanks for the fix, Haohui!

              Show
              jingzhao Jing Zhao added a comment - +1 for the latest patch. Thanks for the fix, Haohui!
              Hide
              Permalink
              wheat9 Haohui Mai added a comment - - edited

              I've committed the patch to trunk, branch-2 and branch-2.7. Thanks Jing for the reviews.

              Show
              wheat9 Haohui Mai added a comment - - edited I've committed the patch to trunk, branch-2 and branch-2.7. Thanks Jing for the reviews.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -



              -1 overall



              Vote Subsystem Runtime Comment
              0 pre-patch 15m 6s Pre-patch trunk compilation is healthy.
              +1 @author 0m 0s The patch does not contain any @author tags.
              -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              -1 javac 7m 43s The applied patch generated 2 additional warning messages.
              +1 javadoc 9m 50s There were no new javadoc warning messages.
              +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
              +1 checkstyle 5m 28s There were no new checkstyle issues.
              +1 install 1m 37s mvn install still works.
              +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
              +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
              +1 native 3m 18s Pre-build of native portion
              -1 hdfs tests 164m 23s Tests failed in hadoop-hdfs.
                  211m 37s  



              Reason Tests
              Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



              Subsystem Report/Notes
              Patch URL http://issues.apache.org/jira/secure/attachment/12728929/HDFS-8273.001.patch
              Optional Tests javadoc javac unit findbugs checkstyle
              git revision trunk / 5190923
              javac https://builds.apache.org/job/PreCommit-HDFS-Build/10440/artifact/patchprocess/diffJavacWarnings.txt
              hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10440/artifact/patchprocess/testrun_hadoop-hdfs.txt
              Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10440/testReport/
              Java 1.7.0_55
              uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
              Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10440/console

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 6s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. -1 javac 7m 43s The applied patch generated 2 additional warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 28s There were no new checkstyle issues. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 18s Pre-build of native portion -1 hdfs tests 164m 23s Tests failed in hadoop-hdfs.     211m 37s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728929/HDFS-8273.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5190923 javac https://builds.apache.org/job/PreCommit-HDFS-Build/10440/artifact/patchprocess/diffJavacWarnings.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10440/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10440/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10440/console This message was automatically generated.
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-trunk-Commit #7697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7697/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7697 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7697/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk #2110 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2110/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2110 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2110/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/169/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #169 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/169/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/178/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/178/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Yarn-trunk #912 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/912/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #912 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/912/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/179/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/179/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Hide
              Permalink
              hudson Hudson added a comment -

              FAILURE: Integrated in Hadoop-Mapreduce-trunk #2128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2128/)
              HDFS-8273. FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16)

              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
              • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java
              • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
              Show
              hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2128 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2128/ ) HDFS-8273 . FSNamesystem#Delete() should not call logSync() when holding the lock. Contributed by Haohui Mai. (wheat9: rev c79e7f7d997596e0c38ae4cddff2bd0910581c16) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirDeleteOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                People

                • Assignee:
                  wheat9 Haohui Mai
                  Reporter:
                  jingzhao Jing Zhao
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development