[HDFS-8269] getBlockLocations() does not resolve the .reserved path and generates incorrect edit logs when updating the atime

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
• Target Version/s: 2.7.1
• Hadoop Flags: Reviewed
• Assignee: Haohui Mai
• Reporter: Yesha Vora
• Created: 27/Apr/15 18:36
• Updated: 06/Sep/18 13:18
• Resolved: 29/Apr/15 18:13

Description

When FSNamesystem#getBlockLocations updates the access time of the INode, it uses the path passed from the client, which generates incorrect edit logs entries:

  <RECORD>
    <OPCODE>OP_TIMES</OPCODE>
    <DATA>
      <TXID>5085</TXID>
      <LENGTH>0</LENGTH>
      <PATH>/.reserved/.inodes/18230</PATH>
      <MTIME>-1</MTIME>
      <ATIME>1429908236392</ATIME>
    </DATA>
  </RECORD>

Note that the NN does not resolve the /.reserved path when processing the edit log, therefore it eventually leads to a NPE when loading the edit logs.

Issue Links

• Blocked: HDFS-13901 INode access time is ignored because of race between open and rename
• duplicates: HDFS-9477 namenode starts failed:FSEditLogLoader: Encountered exception on operation TimesOp
• is broken by: HDFS-7463 Simplify FSNamesystem#getBlockLocationsUpdateTimes