Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Non-HA rollback steps have been changed. Run the rollback command on the namenode (`bin/hdfs namenode -rollback`) before starting cluster with '-rollback' option using (sbin/start-dfs.sh -rollback).

      Description

      In HA while performing rollback , we use “hdfs namenode –rollback” which would prompt user for confirmation. ( Implemented as part of HDFS-5138)

      For Non-HA , as per doc if we perform rollback using “start-dfs.sh –rollback” , then namenode startup hangs ( As it tries to start namenode in daemon mode , hence will not be able to prompt user for confirmation )

      1. HDFS-8226.1.patch
        1 kB
        J.Andreina
      2. HDFS-8226.2.patch
        2 kB
        J.Andreina

        Activity

        Hide
        andreina J.Andreina added a comment -

        Observation:
        =========
        Namenode Thread Dump

        "main" prio=10 tid=0x000000000061d000 nid=0x3778 runnable [0x00007f5a573d8000]
           java.lang.Thread.State: RUNNABLE
                at java.io.FileOutputStream.writeBytes(Native Method)
                at java.io.FileOutputStream.write(FileOutputStream.java:345)
                at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
                at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
                - locked <0x00000000c868f3b0> (a java.io.BufferedOutputStream)
                at java.io.PrintStream.write(PrintStream.java:482)
                - locked <0x00000000c868f390> (a java.io.PrintStream)
                at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221)
                at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:291)
                at sun.nio.cs.StreamEncoder.flushBuffer(StreamEncoder.java:104)
                - locked <0x00000000c868f4e0> (a java.io.OutputStreamWriter)
                at java.io.OutputStreamWriter.flushBuffer(OutputStreamWriter.java:185)
                at java.io.PrintStream.write(PrintStream.java:527)
                - locked <0x00000000c868f390> (a java.io.PrintStream)
                at java.io.PrintStream.print(PrintStream.java:669)
                at java.io.PrintStream.println(PrintStream.java:806)
                - locked <0x00000000c868f390> (a java.io.PrintStream)
        

        Shall we update the document to perform Non-HA rollback using “hdfs namenode –rollback “ and then start namenode ? ( which would be incompatible with previous version) .
        Please provide feedback on this issue.

        Show
        andreina J.Andreina added a comment - Observation: ========= Namenode Thread Dump "main" prio=10 tid=0x000000000061d000 nid=0x3778 runnable [0x00007f5a573d8000] java.lang.Thread.State: RUNNABLE at java.io.FileOutputStream.writeBytes(Native Method) at java.io.FileOutputStream.write(FileOutputStream.java:345) at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82) at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140) - locked <0x00000000c868f3b0> (a java.io.BufferedOutputStream) at java.io.PrintStream.write(PrintStream.java:482) - locked <0x00000000c868f390> (a java.io.PrintStream) at sun.nio.cs.StreamEncoder.writeBytes(StreamEncoder.java:221) at sun.nio.cs.StreamEncoder.implFlushBuffer(StreamEncoder.java:291) at sun.nio.cs.StreamEncoder.flushBuffer(StreamEncoder.java:104) - locked <0x00000000c868f4e0> (a java.io.OutputStreamWriter) at java.io.OutputStreamWriter.flushBuffer(OutputStreamWriter.java:185) at java.io.PrintStream.write(PrintStream.java:527) - locked <0x00000000c868f390> (a java.io.PrintStream) at java.io.PrintStream.print(PrintStream.java:669) at java.io.PrintStream.println(PrintStream.java:806) - locked <0x00000000c868f390> (a java.io.PrintStream) Shall we update the document to perform Non-HA rollback using “hdfs namenode –rollback “ and then start namenode ? ( which would be incompatible with previous version) . Please provide feedback on this issue.
        Hide
        andreina J.Andreina added a comment -

        I have updated an initial patch . This has document updation for the steps to perform Non-HA rollback ( which is incompatible with older releases).

        Please provide your feedback on this approach .

        Show
        andreina J.Andreina added a comment - I have updated an initial patch . This has document updation for the steps to perform Non-HA rollback ( which is incompatible with older releases). Please provide your feedback on this approach .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728225/HDFS-8226.1.patch
        Optional Tests site
        git revision trunk / 1a2459b
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10402/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728225/HDFS-8226.1.patch Optional Tests site git revision trunk / 1a2459b Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10402/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Updated the patch with latest code.
        Please review.

        Show
        andreina J.Andreina added a comment - Updated the patch with latest code. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 2m 59s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 site 2m 54s Site still builds.
        0 shellcheck 2m 54s Shellcheck was not available.
            6m 28s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728323/HDFS-8226.2.patch
        Optional Tests shellcheck site
        git revision trunk / 618ba70
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10406/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 2m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 site 2m 54s Site still builds. 0 shellcheck 2m 54s Shellcheck was not available.     6m 28s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728323/HDFS-8226.2.patch Optional Tests shellcheck site git revision trunk / 618ba70 Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10406/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Patch looks good. +1.
        Since this is an document and script update for the incompatible change done already.

        Show
        vinayrpet Vinayakumar B added a comment - Patch looks good. +1. Since this is an document and script update for the incompatible change done already.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Will commit soon.

        Show
        vinayrpet Vinayakumar B added a comment - Will commit soon.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7773 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7773/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7773 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7773/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk, branch-2 and branch-2.7
        Thanks J.Andreina for the good catch and contribution.

        Updated the release notes with the updated steps for Non-HA rollback.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2 and branch-2.7 Thanks J.Andreina for the good catch and contribution. Updated the release notes with the updated steps for Non-HA rollback.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
        HDFS-8226. Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) HDFS-8226 . Non-HA rollback compatibility broken (Contributed by J.Andreina) (vinayakumarb: rev e01c1a979cbc8fb398d5b7a46693657bc2668a58) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsUserGuide.md

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            andreina J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development