Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      After HDFS-6826 several functions in FSDirStatAndListingOp are dead. This jira proposes to clean them up.

      1. HDFS-8200.000.patch
        12 kB
        Haohui Mai
      2. HDFS-8200.001.patch
        13 kB
        Haohui Mai

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726772/HDFS-8200.000.patch
        against trunk revision d52de61.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.TestLeaseRecovery2

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10327//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10327//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726772/HDFS-8200.000.patch against trunk revision d52de61. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestLeaseRecovery2 Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10327//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10327//console This message is automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        The patch looks good to me. One minor is that we can also pass the INodeAttributes into createFileStatus(..., needLocation, ...) to make the style more consistent. +1 after addressing the comments.

        Show
        jingzhao Jing Zhao added a comment - The patch looks good to me. One minor is that we can also pass the INodeAttributes into createFileStatus(..., needLocation, ...) to make the style more consistent. +1 after addressing the comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 36s There were no new javac warning messages.
        -1 javadoc 9m 56s The applied patch generated 50 additional warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 5m 27s The applied patch generated 2 additional checkstyle issues.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 20s Pre-build of native portion
        +1 hdfs tests 163m 38s Tests passed in hadoop-hdfs.
            210m 22s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12726982/HDFS-8200.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0ebe84d
        javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/10352/artifact/patchprocess/diffJavadocWarnings.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10352/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10352/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10352/testReport/
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10352//console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 36s There were no new javac warning messages. -1 javadoc 9m 56s The applied patch generated 50 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 27s The applied patch generated 2 additional checkstyle issues. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 20s Pre-build of native portion +1 hdfs tests 163m 38s Tests passed in hadoop-hdfs.     210m 22s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12726982/HDFS-8200.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0ebe84d javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/10352/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10352/artifact/patchprocess/checkstyle-result-diff.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10352/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10352/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10352//console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 31s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 6m 50s The applied patch generated 2 additional checkstyle issues.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 12s Pre-build of native portion
        -1 hdfs tests 171m 29s Tests failed in hadoop-hdfs.
            218m 45s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12726982/HDFS-8200.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a100be6
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10355/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10355/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10355/testReport/
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10355//console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 6m 50s The applied patch generated 2 additional checkstyle issues. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 171m 29s Tests failed in hadoop-hdfs.     218m 45s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12726982/HDFS-8200.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a100be6 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10355/artifact/patchprocess/checkstyle-result-diff.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10355/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10355/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10355//console This message was automatically generated.
        Hide
        brandonli Brandon Li added a comment -

        +1.

        Show
        brandonli Brandon Li added a comment - +1.
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Brandon for the reviews.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Brandon for the reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7708 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7708/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7708 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7708/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/180/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/180/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #914 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/914/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #914 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/914/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2112 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2112/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2112 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2112/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/171/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/171/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/181/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/181/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2130 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2130/)
        HDFS-8200. Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2130 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2130/ ) HDFS-8200 . Refactor FSDirStatAndListingOp. Contributed by Haohui Mai. (wheat9: rev c55d609053fe24b3a50fbe17dc1b47717b453ed6) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        zhz Zhe Zhang added a comment -

        Since HDFS-6826 also affects branch-2.7, this change is a valid improvement for branch-2.7. I just did the backport.

        Show
        zhz Zhe Zhang added a comment - Since HDFS-6826 also affects branch-2.7, this change is a valid improvement for branch-2.7. I just did the backport.

          People

          • Assignee:
            wheat9 Haohui Mai
            Reporter:
            wheat9 Haohui Mai
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development