Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8116

Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RollingWindowManager#getTopUserForMetric should check if LOG.isDebugEnabled() before LOG.debug()

      1. HDFS-8116.patch
        1 kB
        Brahma Reddy Battula
      2. HDFS-8116-002.patch
        1 kB
        Brahma Reddy Battula

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Hi Xiaoyu, this class uses slf4j so we shouldn't need to wrap logs in isDebugEnabled checks. SLF4j avoids string construction costs via template args. I took a quick look, and all the logs are templated. Look good to you too?

        If you've got profile data showing hotspots in these debug LOGs, let's guard, else I'm inclined to close as WONTFIX.

        Show
        andrew.wang Andrew Wang added a comment - Hi Xiaoyu, this class uses slf4j so we shouldn't need to wrap logs in isDebugEnabled checks. SLF4j avoids string construction costs via template args. I took a quick look, and all the logs are templated. Look good to you too? If you've got profile data showing hotspots in these debug LOGs, let's guard, else I'm inclined to close as WONTFIX.
        Hide
        xyao Xiaoyu Yao added a comment -

        Andrew Wang, I don't have a profile for it yet. I'm concerned because the debug log below is written in a loop of O(#ActiveUser*#Ops).

              LOG.debug("offer window of metric: {} userName: {} sum: {}",
                  metricName, userName, windowSum);
        

        If RollingWindowManager class uses SLF4j which does not need to wrap logs in isDebugEnabled(), we should use this consistently to avoid confusion. Should we remove the check from RollingWindowManager#snapshot?

            if (LOG.isDebugEnabled()) {
              Set<String> metricNames = metricMap.keySet();
              LOG.debug("iterating in reported metrics, size={} values={}",
                  metricNames.size(), metricNames);
            }
        
        Show
        xyao Xiaoyu Yao added a comment - Andrew Wang , I don't have a profile for it yet. I'm concerned because the debug log below is written in a loop of O(#ActiveUser*#Ops). LOG.debug( "offer window of metric: {} userName: {} sum: {}" , metricName, userName, windowSum); If RollingWindowManager class uses SLF4j which does not need to wrap logs in isDebugEnabled(), we should use this consistently to avoid confusion. Should we remove the check from RollingWindowManager#snapshot? if (LOG.isDebugEnabled()) { Set< String > metricNames = metricMap.keySet(); LOG.debug( "iterating in reported metrics, size={} values={}" , metricNames.size(), metricNames); }
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Andrew Wang ,it's better to remove LOG.isDebugEnabled() as Xiaoyu Yao pointed which makes consistency in RollingWindowManager ..if you agree, i will chage defect summary and give patch..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Andrew Wang ,it's better to remove LOG.isDebugEnabled() as Xiaoyu Yao pointed which makes consistency in RollingWindowManager ..if you agree, i will chage defect summary and give patch..
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Kindly review the attached patch!!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Kindly review the attached patch!!!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 7m 40s There were no new checkstyle issues.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 164m 49s Tests failed in hadoop-hdfs.
            212m 53s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728137/HDFS-8116.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 78c6b46
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10387/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10387/testReport/
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10387/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 7m 40s There were no new checkstyle issues. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 164m 49s Tests failed in hadoop-hdfs.     212m 53s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728137/HDFS-8116.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 78c6b46 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10387/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10387/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10387/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Testcase failures are unrelated to this patch...

        Show
        brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated to this patch...
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        I think we should performance test before and after this fix as Andrew Wang mentioned.

        Show
        ozawa Tsuyoshi Ozawa added a comment - I think we should performance test before and after this fix as Andrew Wang mentioned.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        I think, Performance test might not require..Just for consistency I removed LOG.isDebugEnabled().. If I add LOG.isDebugEnabled() before LOG.Debug() ( as per defect summary),Then we need to do performance test before and after the patch...Please correct me , If I am wrong.. Need to change defect summary..

        Show
        brahmareddy Brahma Reddy Battula added a comment - I think, Performance test might not require..Just for consistency I removed LOG.isDebugEnabled().. If I add LOG.isDebugEnabled() before LOG.Debug() ( as per defect summary),Then we need to do performance test before and after the patch...Please correct me , If I am wrong.. Need to change defect summary..
        Hide
        vinayrpet Vinayakumar B added a comment -

        If RollingWindowManager class uses SLF4j which does not need to wrap logs in isDebugEnabled(), we should use this consistently to avoid confusion. Should we remove the check from RollingWindowManager#snapshot?

        I agree that it looks good to be constistent, but there are so many other classes also with this kind of coding.
        Do we need to change everywhere to be consistent? or leave as is and take care in future coding, as there will not be any benefit in performance after change.

        Show
        vinayrpet Vinayakumar B added a comment - If RollingWindowManager class uses SLF4j which does not need to wrap logs in isDebugEnabled(), we should use this consistently to avoid confusion. Should we remove the check from RollingWindowManager#snapshot? I agree that it looks good to be constistent, but there are so many other classes also with this kind of coding. Do we need to change everywhere to be consistent? or leave as is and take care in future coding, as there will not be any benefit in performance after change.
        Hide
        xyao Xiaoyu Yao added a comment -

        Just my 2c: I think we should have cleaned it up when switching to SFL4j. If there are many other classes with the same issue, we can open separate JIRAs for them. This way, we reduce the long term maintenance overhead and avoid new contributors following the unnecessary if (isDebugEnabled()) pattern in new code.

        Show
        xyao Xiaoyu Yao added a comment - Just my 2c: I think we should have cleaned it up when switching to SFL4j. If there are many other classes with the same issue, we can open separate JIRAs for them. This way, we reduce the long term maintenance overhead and avoid new contributors following the unnecessary if (isDebugEnabled()) pattern in new code.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Xiaoyu Yao agree with you..Kindly review the patch..thanks

        Show
        brahmareddy Brahma Reddy Battula added a comment - Xiaoyu Yao agree with you..Kindly review the patch..thanks
        Hide
        xyao Xiaoyu Yao added a comment -

        Can you reduce the 2 extra leading spaces of your change? +1 otherwise pending Jenkins.

        Show
        xyao Xiaoyu Yao added a comment - Can you reduce the 2 extra leading spaces of your change? +1 otherwise pending Jenkins.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Xiaoyu Yao kindly review!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Xiaoyu Yao kindly review!!
        Hide
        xyao Xiaoyu Yao added a comment -

        Brahma Reddy Battula, patch 002 seems to be the same as the original patch. Did you attach the right patch?

        Show
        xyao Xiaoyu Yao added a comment - Brahma Reddy Battula , patch 002 seems to be the same as the original patch. Did you attach the right patch?
        Hide
        xyao Xiaoyu Yao added a comment -

        You may also remove the unnecessary empty line. The fix I would expect is:

          TopWindow window = new TopWindow(windowLenMs);
          Set<String> metricNames = metricMap.keySet();
          LOG.debug("iterating in reported metrics, size={} values={}",
              metricNames.size(), metricNames);
        
        Show
        xyao Xiaoyu Yao added a comment - You may also remove the unnecessary empty line. The fix I would expect is: TopWindow window = new TopWindow(windowLenMs); Set< String > metricNames = metricMap.keySet(); LOG.debug( "iterating in reported metrics, size={} values={}" , metricNames.size(), metricNames);
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Xiaoyu Yao Now I attached the correct one..kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Xiaoyu Yao Now I attached the correct one..kindly review..
        Hide
        xyao Xiaoyu Yao added a comment -

        +1

        Show
        xyao Xiaoyu Yao added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 45s There were no new javac warning messages.
        +1 javadoc 10m 1s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 23s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 15s Pre-build of native portion
        +1 hdfs tests 160m 12s Tests passed in hadoop-hdfs.
            206m 33s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738141/HDFS-8116-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / b3ffa87
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11253/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11253/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11253/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 23s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion +1 hdfs tests 160m 12s Tests passed in hadoop-hdfs.     206m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738141/HDFS-8116-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b3ffa87 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11253/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11253/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11253/console This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Brahma Reddy Battula for the contribution! I've committed the patch to trunk and branch-2.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Brahma Reddy Battula for the contribution! I've committed the patch to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7983 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7983/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7983 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7983/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/221/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/221/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #951 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/951/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #951 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/951/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2149/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2149/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/210/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/210/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #219 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/219/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #219 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/219/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2167 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2167/)
        HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2167 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2167/ ) HDFS-8116 . Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (xyao: rev b61b48999530851da177db2e8998858ffc01f77e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development