Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8108

Fsck should provide the info on mandatory option to be used along with "-blocks , -locations and -racks"

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Fsck usage information should provide the information on which options are mandatory to be passed along with "-blocks , -locations and -racks" to be in sync with documentation.

      For example :
      To get information on:
      1. Blocks (-blocks), option "-files" should also be used.
      2. Rack information (-racks), option "-files" and "-blocks" should also be used.

      ./hdfs fsck -files -blocks
      ./hdfs fsck -files -blocks -racks
      
      1. HDFS-8108.1.patch
        1 kB
        J.Andreina
      2. HDFS-8108.2.patch
        1 kB
        J.Andreina

        Activity

        Hide
        andreina J.Andreina added a comment -

        Provided an initial patch.
        Please review.

        Show
        andreina J.Andreina added a comment - Provided an initial patch. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 33s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 7m 49s The applied patch generated 1 additional checkstyle issues.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 12s Pre-build of native portion
        +1 hdfs tests 164m 5s Tests passed in hadoop-hdfs.
            212m 20s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728213/HDFS-8108.1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 22b70e7
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10398/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10398/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10398/testReport/
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10398/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 7m 49s The applied patch generated 1 additional checkstyle issues. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 12s Pre-build of native portion +1 hdfs tests 164m 5s Tests passed in hadoop-hdfs.     212m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728213/HDFS-8108.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 22b70e7 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10398/artifact/patchprocess/checkstyle-result-diff.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10398/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10398/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10398/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        I am not able to find from the report what is the checkstyle error in my patch.
        Can someone help me in identifying it.
        Thanks in advance.

        Show
        andreina J.Andreina added a comment - I am not able to find from the report what is the checkstyle error in my patch. Can someone help me in identifying it. Thanks in advance.
        Hide
        aw Allen Wittenauer added a comment -

        Using a new version of the checkstyle test-patch code, it says:

        hadoop-hdfs-project/hadoop-hdfs/.../hadoop/hdfs/tools/DFSck.java:95: Line is longer than 80 characters (found 87).

        Show
        aw Allen Wittenauer added a comment - Using a new version of the checkstyle test-patch code, it says: hadoop-hdfs-project/hadoop-hdfs/.../hadoop/hdfs/tools/DFSck.java:95: Line is longer than 80 characters (found 87).
        Hide
        andreina J.Andreina added a comment -

        Thanks Allen Wittenauer for clarifying .
        I have updated the patch fixing checkstyle error.
        Please review.

        Show
        andreina J.Andreina added a comment - Thanks Allen Wittenauer for clarifying . I have updated the patch fixing checkstyle error. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 9s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 10m 2s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 5m 35s The applied patch generated 1 additional checkstyle issues.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 23s Pre-build of native portion
        +1 hdfs tests 167m 52s Tests passed in hadoop-hdfs.
            215m 32s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728311/HDFS-8108.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 618ba70
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10405/artifact/patchprocess/whitespace.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10405/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10405/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10405/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10405/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 35s The applied patch generated 1 additional checkstyle issues. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 23s Pre-build of native portion +1 hdfs tests 167m 52s Tests passed in hadoop-hdfs.     215m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728311/HDFS-8108.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 618ba70 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10405/artifact/patchprocess/whitespace.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10405/artifact/patchprocess/checkstyle-result-diff.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10405/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10405/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10405/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        This issue is for updating the usage description of fsck . So no need of testcase

        Show
        andreina J.Andreina added a comment - This issue is for updating the usage description of fsck . So no need of testcase
        Hide
        nijel nijel added a comment -

        reviewed
        +1

        Show
        nijel nijel added a comment - reviewed +1
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        +1

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - +1
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        I have just committed this to trunk and branch-2

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - I have just committed this to trunk and branch-2
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7772 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7772/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7772 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7772/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
        HDFS-8108. Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) HDFS-8108 . Fsck should provide the info on mandatory option to be used along with -blocks ,-locations and -racks. Contributed by J.Andreina. (umamahesh: rev 4b00ae5c113a9a8bd2a300f6d88897b932eeb94f) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            andreina J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development