Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-806

Add new unit tests to the 10-mins 'run-commit-test' target

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The reason to add these test is that they are true unit tests thus running very fast while testing pretty significant parts of the HDFS code base. Additional time is very short (<3 secs) and won't affect 10 mins commit testing.

      1. HDFS-806.patch
        0.6 kB
        Konstantin Boudnik
      2. HDFS-806.patch
        0.6 kB
        Konstantin Boudnik
      3. HDFS-806.patch
        0.6 kB
        Konstantin Boudnik
      4. HDFS-806.patch
        2 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Konstantin Boudnik created issue -
          Konstantin Boudnik made changes -
          Field Original Value New Value
          Summary Add new unit tests to the 10-mins CI suite Add new unit tests to the 10-mins 'run-commit-test' target
          Description The reason to add these test is that they are true unit tests thus running very fast while testing pretty significant parts of the HDFS code base. Additional time is very short (<3 secs) and won't affect 10 mins run. The reason to add these test is that they are true unit tests thus running very fast while testing pretty significant parts of the HDFS code base. Additional time is very short (<3 secs) and won't affect 10 mins commit testing.
          Hide
          Konstantin Boudnik added a comment -

          That should do

          Show
          Konstantin Boudnik added a comment - That should do
          Konstantin Boudnik made changes -
          Attachment HDFS-806.patch [ 12426813 ]
          Konstantin Boudnik made changes -
          Assignee Konstantin Boudnik [ cos ]
          Hide
          Konstantin Boudnik added a comment -

          Refitting to the current trunk.

          Show
          Konstantin Boudnik added a comment - Refitting to the current trunk.
          Konstantin Boudnik made changes -
          Attachment HDFS-806.patch [ 12450132 ]
          Hide
          Konstantin Boudnik added a comment -

          It seems like running unit test before commits are a better idea. They are smaller and run faster.

          Show
          Konstantin Boudnik added a comment - It seems like running unit test before commits are a better idea. They are smaller and run faster.
          Konstantin Boudnik made changes -
          Attachment HDFS-806.patch [ 12450136 ]
          Hide
          Konstantin Boudnik added a comment -

          let's check.

          Show
          Konstantin Boudnik added a comment - let's check.
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450136/HDFS-806.patch
          against trunk revision 966394.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450136/HDFS-806.patch against trunk revision 966394. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/444/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          this patch also address another corner case when -Dtestcase is specified from either smoke-tests or commit-tests lists. Not it will run such testcase if run-test-hdfs has been started.

          Show
          Konstantin Boudnik added a comment - this patch also address another corner case when -Dtestcase is specified from either smoke-tests or commit-tests lists. Not it will run such testcase if run-test-hdfs has been started.
          Konstantin Boudnik made changes -
          Attachment HDFS-806.patch [ 12451186 ]
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          Let's check it again.

          Show
          Konstantin Boudnik added a comment - Let's check it again.
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12451186/HDFS-806.patch
          against trunk revision 982091.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12451186/HDFS-806.patch against trunk revision 982091. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/229/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          The test failures are 8 and 9 days respectively and apparently unrelated. The patch doesn't have any unit test in it for it is the build patch.

          Show
          Konstantin Boudnik added a comment - The test failures are 8 and 9 days respectively and apparently unrelated. The patch doesn't have any unit test in it for it is the build patch.
          Hide
          Jakob Homan added a comment -

          The -Dtestcase= workaround looks good. The new macro runner added to the commit test section duplicates the body of run-test-unit. Can we make that target a pre-req for commit test, or just call it directly rather than duplicating the code?

          Show
          Jakob Homan added a comment - The -Dtestcase= workaround looks good. The new macro runner added to the commit test section duplicates the body of run-test-unit. Can we make that target a pre-req for commit test, or just call it directly rather than duplicating the code?
          Hide
          Konstantin Boudnik added a comment -

          Can we make that target a pre-req for commit test, or just call it directly rather than duplicating the code?

          • Pre-req will create an issue if someone will run run-commit-test with -Dtestcase. In this scenario, if a testcase is from unit suite then it will be executed. And it doesn't matter that unless="testcase" clause will be in effect.
          • calling directly means a use of subant which will cause the resolution of all dependencies of that target and so on. In other words, it'd be ugly. Although, the code duplication is an awful thing it seems to be a good enough solution in this case.
            Besides, it isn't a duplication of the code: this is merely a duplication of macro call.
          Show
          Konstantin Boudnik added a comment - Can we make that target a pre-req for commit test, or just call it directly rather than duplicating the code? Pre-req will create an issue if someone will run run-commit-test with -Dtestcase. In this scenario, if a testcase is from unit suite then it will be executed. And it doesn't matter that unless="testcase" clause will be in effect. calling directly means a use of subant which will cause the resolution of all dependencies of that target and so on. In other words, it'd be ugly. Although, the code duplication is an awful thing it seems to be a good enough solution in this case. Besides, it isn't a duplication of the code: this is merely a duplication of macro call.
          Hide
          Jakob Homan added a comment -

          Sounds reasonable. +1.

          Show
          Jakob Homan added a comment - Sounds reasonable. +1.
          Jakob Homan made changes -
          Hadoop Flags [Reviewed]
          Hide
          Konstantin Boudnik added a comment -

          I have just committed this.

          Show
          Konstantin Boudnik added a comment - I have just committed this.
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.21.0 [ 12314046 ]
          Resolution Fixed [ 1 ]
          Konstantin Boudnik made changes -
          Link This issue is related to HDFS-1311 [ HDFS-1311 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/ )
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development