Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8004

Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: encryption
    • Labels:
      None
    • Target Version/s:

      Description

      It'd be slightly better to use the provided warm-up method, even though what we do now (getting and throwing away a key) is functionally the same.

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        thanks Arun, don't forget to set the fix version

        Show
        andrew.wang Andrew Wang added a comment - thanks Arun, don't forget to set the fix version
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2078 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2078/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2078 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2078/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2096 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2096/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2096 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2096/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/146/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/146/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/137/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/137/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #880 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/880/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #880 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/880/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/146/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #146 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/146/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7450 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7450/)
        HDFS-8004. Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7450 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7450/ ) HDFS-8004 . Use KeyProviderCryptoExtension#warmUpEncryptedKeys when creating an encryption zone. (awang via asuresh) (Arun Suresh: rev e97f8e44af9dffc42c030278425cffe0c9da723b) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        asuresh Arun Suresh added a comment -

        Thanks again for the patch Andrew Wang.
        Ive committed this to trunk and branch-2

        Show
        asuresh Arun Suresh added a comment - Thanks again for the patch Andrew Wang . Ive committed this to trunk and branch-2
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707881/hdfs-8004.001.patch
        against trunk revision 05499b1.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10096//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10096//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707881/hdfs-8004.001.patch against trunk revision 05499b1. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10096//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10096//console This message is automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        The patch looks good Andrew Wang, Thanks..
        +1 (pending jenkins)
        will commit after..

        Show
        asuresh Arun Suresh added a comment - The patch looks good Andrew Wang , Thanks.. +1 (pending jenkins) will commit after..
        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached, quite trivial. Arun Suresh care to review?

        Show
        andrew.wang Andrew Wang added a comment - Patch attached, quite trivial. Arun Suresh care to review?

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development