Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7897

Shutdown metrics when stopping JournalNode

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue is found when reading the code.

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12702960/HDFS-7897-001.patch
        against trunk revision 952640f.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

        The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702960/HDFS-7897-001.patch against trunk revision 952640f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//console This message is automatically generated.
        Hide
        sinago zhouyingchao added a comment -

        I tried the patch on my computer with the two failed case reported by robot, both of them finish successfully. The failure should not be related with the patch.

        Show
        sinago zhouyingchao added a comment - I tried the patch on my computer with the two failed case reported by robot, both of them finish successfully. The failure should not be related with the patch.
        Hide
        sinago zhouyingchao added a comment -

        Any updates regarding this simple patch?

        Show
        sinago zhouyingchao added a comment - Any updates regarding this simple patch?
        Hide
        wheat9 Haohui Mai added a comment -

        +1. Ran the test locally and they passed. Committing.

        Show
        wheat9 Haohui Mai added a comment - +1. Ran the test locally and they passed. Committing.
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks zhouyingchao for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks zhouyingchao for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8854 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8854/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8854 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8854/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #699 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/699/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #699 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/699/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #710 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/710/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #710 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/710/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2640 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2640/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2640 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2640/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1435 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1435/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1435 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1435/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/)
        HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/ ) HDFS-7897 . Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java

          People

          • Assignee:
            sinago zhouyingchao
            Reporter:
            sinago zhouyingchao
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development