Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7867

Update action param from "start" to "prepare" in rolling upgrade javadoc

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the following code comment rolling upgrade action "start" should be updated to "prepare"

      DistributedFileSystem.java :

       /**
         * Rolling upgrade: start/finalize/query.
         */
        public RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action)
            throws IOException {
      

      ClientProtocol.java :

              /**
         * Rolling upgrade operations.
         * @param action either query, start or finailze.
         * @return rolling upgrade information.
         */
        @Idempotent
        public RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action)
            throws IOException;
      

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2087 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2087/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2087 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2087/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/137/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/137/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/128/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #128 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/128/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2069 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2069/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2069 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2069/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #871 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/871/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #871 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/871/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/137/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #137 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/137/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7371 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7371/)
        HDFS-7867. Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7371 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7371/ ) HDFS-7867 . Update action param from 'start' to 'prepare' in rolling upgrade ( Contributed by J.Andreina) Updated JIRA id. (vinayakumarb: rev 355e008ffbb0a33cb7d5782fc291abd62d684aaa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks for the contribution J.Andreina.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks for the contribution J.Andreina .
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1. Will commit soon.

        Show
        vinayrpet Vinayakumar B added a comment - +1. Will commit soon.
        Hide
        andreina J.Andreina added a comment -

        Failures are not related to this patch. Unit Testcases are not needed for this issue as it is a change in code comment.

        Show
        andreina J.Andreina added a comment - Failures are not related to this patch. Unit Testcases are not needed for this issue as it is a change in code comment.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12701867/HDFS-7867.1.patch
        against trunk revision ca1c00b.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9696//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9696//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701867/HDFS-7867.1.patch against trunk revision ca1c00b. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9696//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9696//console This message is automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Attached a patch with changes as per description.

        Please review the patch.

        Show
        andreina J.Andreina added a comment - Attached a patch with changes as per description. Please review the patch.

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            andreina J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development