[HDFS-7761] cleanup unnecssary code logic in LocatedBlock

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.7.0
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Yi Liu
• Reporter: Yi Liu
• Created: 10/Feb/15 03:11
• Updated: 10/Apr/15 20:30
• Resolved: 12/Feb/15 04:08

Description

1. The usage of following two variables is unnecessary. We can remove them to make code a bit brief.

   private final boolean hasStorageIDs;
   private final boolean hasStorageTypes;

2. In HDFS-7647, no need to modify LocatedBlock#getStorageTypes and LocatedBlock#getStorageIDs, we just need to update the cached storageIDs and storageTypes after sort.
3. Another thing is we'd better setSoftwareVersion when constructing DatanodeInfoWithStorage from DatanodeInfo

Issue Links

• relates to: HDFS-7647 DatanodeManager.sortLocatedBlocks sorts DatanodeInfos but not StorageIDs