Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-764

Moving Access Token implementation from Common to HDFS

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change

      Description

      This is the HDFS changes of HADOOP-6367.

      1. 764-01.patch
        72 kB
        Kan Zhang
      2. 764-02.patch
        72 kB
        Kan Zhang
      3. HADOOP-6367_HDFS-764-0_20.1.patch
        92 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Correction in previous comment:
          The combined patch for hadoop 20 is for jiras HADOOP-6367 and HDFS-764.

          Show
          Jitendra Nath Pandey added a comment - Correction in previous comment: The combined patch for hadoop 20 is for jiras HADOOP-6367 and HDFS-764 .
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6367_HDFS-764-0_20.1.patch [ 12428959 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for hadoop 20 is added. This is a combined patch for HADOOP-6376 and HDFS-764. A combined patch or hadoop 20 is required otherwise build will fail.

          Show
          Jitendra Nath Pandey added a comment - Patch for hadoop 20 is added. This is a combined patch for HADOOP-6376 and HDFS-764 . A combined patch or hadoop 20 is required otherwise build will fail.
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #81 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/81/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #81 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/81/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #118 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/118/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #118 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/118/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #145 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/145/)
          . Places the Block Access token implementation in hdfs project. Contributed by .

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #145 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/145/ ) . Places the Block Access token implementation in hdfs project. Contributed by .
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #115 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/115/)
          . Places the Block Access token implementation in hdfs project. Contributed by .

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #115 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/115/ ) . Places the Block Access token implementation in hdfs project. Contributed by .
          Devaraj Das made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Kan!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Kan!
          Hide
          Jitendra Nath Pandey added a comment -

          +1 for the patch.

          Show
          Jitendra Nath Pandey added a comment - +1 for the patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12424761/764-02.patch
          against trunk revision 835534.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 21 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424761/764-02.patch against trunk revision 835534. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/73/console This message is automatically generated.
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Kan Zhang made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Kan Zhang made changes -
          Attachment 764-02.patch [ 12424761 ]
          Hide
          Kan Zhang added a comment -

          attaching a new patch which removed the unnecessary import. Otherwise, same as the previous one.

          Show
          Kan Zhang added a comment - attaching a new patch which removed the unnecessary import. Otherwise, same as the previous one.
          Hide
          Jitendra Nath Pandey added a comment -

          Import of AccessTokenHandler are not needed in some files e.g. src/java/org/apache/hadoop/hdfs/server/datanode/DatanodeJspHelper.java.

          Show
          Jitendra Nath Pandey added a comment - Import of AccessTokenHandler are not needed in some files e.g. src/java/org/apache/hadoop/hdfs/server/datanode/DatanodeJspHelper.java.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12424648/764-01.patch
          against trunk revision 834377.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 21 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424648/764-01.patch against trunk revision 834377. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/104/console This message is automatically generated.
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Incompatible change]
          Affects Version/s 0.21.0 [ 12314046 ]
          Fix Version/s 0.21.0 [ 12314046 ]
          Kan Zhang made changes -
          Attachment 764-01.patch [ 12424648 ]
          Hide
          Kan Zhang added a comment -

          attaching a patch for the changes in HDFS. No new test is added since there is no functional change (only moving existing code around and renaming).

          Show
          Kan Zhang added a comment - attaching a patch for the changes in HDFS. No new test is added since there is no functional change (only moving existing code around and renaming).
          Kan Zhang made changes -
          Field Original Value New Value
          Link This issue blocks HADOOP-6367 [ HADOOP-6367 ]
          Kan Zhang created issue -

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development