Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7582

Enforce maximum number of ACL entries separately per access and default.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Limit on Maximum number of ACL entries(32) will be enforced separately on access and default ACLs. So in total, max. 64 ACL entries can be present in a ACL spec.

      Description

      Current ACL limits are only on the total number of entries.

      But there can be a situation where number of default entries for a directory will be more than half of the maximum entries, i.e. > 16.

      In such case, under this parent directory only files can be created which will have ACLs inherited using parent's default entries.

      But when directories are created, total number of entries will be more than the maximum allowed, because sub-directories copies both inherited ACLs as well as default entries.
      Since currently there is no check while copying ACLs from default ACLs directory creation succeeds, but any modification (only permission on one entry also) on the same ACL will fail.

      It would be better to enforce the maximum of 32 entries separately per access and default. This would be consistent with our observations testing ACLs on other file systems, such as XFS and ext3.

      1. HDFS-7582-02.patch
        8 kB
        Vinayakumar B
      2. HDFS-7582-01.patch
        8 kB
        Vinayakumar B
      3. HDFS-7582-001.patch
        3 kB
        Vinayakumar B

        Activity

        Hide
        vinayrpet Vinayakumar B added a comment -

        Attached the patch.
        Please review

        Show
        vinayrpet Vinayakumar B added a comment - Attached the patch. Please review
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12690009/HDFS-7582-001.patch
        against trunk revision ddc5be4.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9140//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9140//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9140//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690009/HDFS-7582-001.patch against trunk revision ddc5be4. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9140//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9140//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9140//console This message is automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        Hi, Vinayakumar B. I had tested this behavior against a Linux file system with POSIX ACLs during initial implementation. I observed the same behavior on Linux: you can end up exceeding the limit of 32 if there are a lot of default ACL entries. While it's a bit counter-intuitive, I thought it would be more familiar to users if HDFS kept the same behavior. Let me know what you think.

        Show
        cnauroth Chris Nauroth added a comment - Hi, Vinayakumar B . I had tested this behavior against a Linux file system with POSIX ACLs during initial implementation. I observed the same behavior on Linux: you can end up exceeding the limit of 32 if there are a lot of default ACL entries. While it's a bit counter-intuitive, I thought it would be more familiar to users if HDFS kept the same behavior. Let me know what you think.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Hi Chris Nauroth, Thanks for checking.
        I have also verified again, but my results shows different behaviour in this context. Also there is a chance that this could be distribution specific. I have verified in CentOS distribution.

        In My test of POSIX ACLs, the limit of 25 were separately applied on ACCESS and DEFAULT entries, so totally there could be 50 entries.
        So when the child directory created, it also will have max of 50 entries, 25 ACCESS and 25 DEFAULT. So there is no violation here.

        But in HDFS ACLs, the limit is applied is on whole. This has to match the POSIX behaviour.
        There are 2 possibilities to handle current case.
        1. Apply the EXISTING limit (32) separately on ACCESS and DEFAULT. This will increase the NN Memory.
        2. Restrict only DEFAULT entries to 16, and whole to 32. This could have backward compatibility issue if already existing default entries are more than 16, of course thats not correct, still i t wont throw any error while creating the child and inheriting the ACLs.

        Any thoughts?

        FYR,

        [vinay@server2 ~]$ getfacl testAcl/
        # file: testAcl/
        # owner: vinay
        # group: vinay
        user::rwx
        user:root:rwx
        user:bin:rwx
        user:daemon:rwx
        user:adm:rwx
        user:lp:rwx
        user:sync:rwx
        user:shutdown:rwx
        user:halt:rwx
        user:mail:rwx
        user:operator:rwx
        user:games:rwx
        user:ftp:rwx
        user:ntp:rwx
        user:avahi:rwx
        user:dbus:rwx
        user:nobody:rwx
        user:usbmuxd:rwx
        user:abrt:rwx
        user:colord:rwx
        user:unbound:rwx
        user:polkitd:rwx
        group::rwx
        mask::rwx
        other::r-x
        default:user::rwx
        default:user:root:rwx
        default:user:bin:rwx
        default:user:daemon:rwx
        default:user:adm:rwx
        default:user:lp:rwx
        default:user:sync:rwx
        default:user:shutdown:rwx
        default:user:halt:rwx
        default:user:mail:rwx
        default:user:operator:rwx
        default:user:games:rwx
        default:user:ftp:rwx
        default:user:ntp:rwx
        default:user:avahi:rwx
        default:user:dbus:rwx
        default:user:nobody:rwx
        default:user:usbmuxd:rwx
        default:user:abrt:rwx
        default:user:colord:rwx
        default:user:unbound:rwx
        default:user:polkitd:rwx
        default:group::rwx
        default:mask::rwx
        default:other::r-x
        Show
        vinayrpet Vinayakumar B added a comment - Hi Chris Nauroth , Thanks for checking. I have also verified again, but my results shows different behaviour in this context. Also there is a chance that this could be distribution specific. I have verified in CentOS distribution. In My test of POSIX ACLs, the limit of 25 were separately applied on ACCESS and DEFAULT entries, so totally there could be 50 entries. So when the child directory created, it also will have max of 50 entries, 25 ACCESS and 25 DEFAULT. So there is no violation here. But in HDFS ACLs, the limit is applied is on whole. This has to match the POSIX behaviour. There are 2 possibilities to handle current case. 1. Apply the EXISTING limit (32) separately on ACCESS and DEFAULT. This will increase the NN Memory. 2. Restrict only DEFAULT entries to 16, and whole to 32. This could have backward compatibility issue if already existing default entries are more than 16, of course thats not correct, still i t wont throw any error while creating the child and inheriting the ACLs. Any thoughts? FYR, [vinay@server2 ~]$ getfacl testAcl/ # file: testAcl/ # owner: vinay # group: vinay user::rwx user:root:rwx user:bin:rwx user:daemon:rwx user:adm:rwx user:lp:rwx user:sync:rwx user:shutdown:rwx user:halt:rwx user:mail:rwx user:operator:rwx user:games:rwx user:ftp:rwx user:ntp:rwx user:avahi:rwx user:dbus:rwx user:nobody:rwx user:usbmuxd:rwx user:abrt:rwx user:colord:rwx user:unbound:rwx user:polkitd:rwx group::rwx mask::rwx other::r-x default:user::rwx default:user:root:rwx default:user:bin:rwx default:user:daemon:rwx default:user:adm:rwx default:user:lp:rwx default:user:sync:rwx default:user:shutdown:rwx default:user:halt:rwx default:user:mail:rwx default:user:operator:rwx default:user:games:rwx default:user:ftp:rwx default:user:ntp:rwx default:user:avahi:rwx default:user:dbus:rwx default:user:nobody:rwx default:user:usbmuxd:rwx default:user:abrt:rwx default:user:colord:rwx default:user:unbound:rwx default:user:polkitd:rwx default:group::rwx default:mask::rwx default:other::r-x
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12690009/HDFS-7582-001.patch
        against trunk revision af9d4fe.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.TestLeaseRecovery2

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10247//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10247//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690009/HDFS-7582-001.patch against trunk revision af9d4fe. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestLeaseRecovery2 Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10247//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10247//console This message is automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Hi Chris Nauroth, any update on this?

        Show
        vinayrpet Vinayakumar B added a comment - Hi Chris Nauroth , any update on this?
        Hide
        cnauroth Chris Nauroth added a comment -

        Hi Vinayakumar B. Sorry for the long delay replying to this.

        If we were to make any change that would restrict the number of ACL entries to a smaller number than what we allow now, then it would be a backwards-incompatible change. It's possible that existing deployments are already dependent on being able to create an ACL that uses the current limit. Therefore, I would have to -1 any such change made on the 2.x line.

        Do you still want to consider changing this for 3.x? We'd have the flexibility to make a backwards-incompatible change there. If we did that, then I'd still want to make sure that we can load an existing fsimage/edits that took advantage of today's limits. I'd want us to have a JUnit test to verify that, so that people upgrading from 2.x to 3.x won't fail to load the metadata or silently lose some of their ACL entries.

        In My test of POSIX ACLs, the limit of 25 were separately applied on ACCESS and DEFAULT entries, so totally there could be 50 entries.

        I'd have to retest, but I think this is different from the behavior I observed. It would be great if we could find a definitive source that defines the limit, but I haven't found it yet.

        Show
        cnauroth Chris Nauroth added a comment - Hi Vinayakumar B . Sorry for the long delay replying to this. If we were to make any change that would restrict the number of ACL entries to a smaller number than what we allow now, then it would be a backwards-incompatible change. It's possible that existing deployments are already dependent on being able to create an ACL that uses the current limit. Therefore, I would have to -1 any such change made on the 2.x line. Do you still want to consider changing this for 3.x? We'd have the flexibility to make a backwards-incompatible change there. If we did that, then I'd still want to make sure that we can load an existing fsimage/edits that took advantage of today's limits. I'd want us to have a JUnit test to verify that, so that people upgrading from 2.x to 3.x won't fail to load the metadata or silently lose some of their ACL entries. In My test of POSIX ACLs, the limit of 25 were separately applied on ACCESS and DEFAULT entries, so totally there could be 50 entries. I'd have to retest, but I think this is different from the behavior I observed. It would be great if we could find a definitive source that defines the limit, but I haven't found it yet.
        Hide
        vinayrpet Vinayakumar B added a comment - - edited

        It would be great if we could find a definitive source that defines the limit, but I haven't found it yet.

        http://users.suse.com/~agruen/acl/linux-acls/online/#tab:acl_entries
        I have tested on XFS, so I found the limit of 25 mentioned here for XFS. But doc didnt say that its separately applied on access and default. Anyway this limit was based on underlying FS implementations, Some supports in limiting # of entries, some support limiting overall size.

        In my earlier options, the option #1 (Apply the EXISTING limit (32) separately on ACCESS and DEFAULT) was without backward incompatibility for existing deployments. Of-course it increases the NN memory if extensively used.

        What you say about option #1?

        Do you still want to consider changing this for 3.x? We'd have the flexibility to make a backwards-incompatible change there.

        I dont think so.

        Show
        vinayrpet Vinayakumar B added a comment - - edited It would be great if we could find a definitive source that defines the limit, but I haven't found it yet. http://users.suse.com/~agruen/acl/linux-acls/online/#tab:acl_entries I have tested on XFS, so I found the limit of 25 mentioned here for XFS. But doc didnt say that its separately applied on access and default. Anyway this limit was based on underlying FS implementations, Some supports in limiting # of entries, some support limiting overall size. In my earlier options, the option #1 (Apply the EXISTING limit (32) separately on ACCESS and DEFAULT) was without backward incompatibility for existing deployments. Of-course it increases the NN memory if extensively used. What you say about option #1? Do you still want to consider changing this for 3.x? We'd have the flexibility to make a backwards-incompatible change there. I dont think so.
        Hide
        cnauroth Chris Nauroth added a comment -

        Vinayakumar B, this is starting to make sense to me now. The spec I've referred to a lot (the same one you linked in your last comment) shows the maximum number of entries for a few different file systems. Like you said, it doesn't specifically say anywhere that the limit is applied separately for access and default, but in practice, that's the behavior that both you and I have observed.

        I had been thrown off by the fact that you found different results than I did from testing against a local file system. Now I see the reason for that is you were testing with XFS (max 25 per access and default) and I was testing with ext3 (max 32 per access and default).

        Now considering all of that, I agree with you that HDFS can make a change so that the limit is enforced separately per access and default. This is backwards-compatible, because it does not reduce the number of ACL entries that can be used in existing deployments already. I'm re-targeting this to 2.8.0 and updating the description to show the new plan.

        Thank you for the follow-up!

        Show
        cnauroth Chris Nauroth added a comment - Vinayakumar B , this is starting to make sense to me now. The spec I've referred to a lot (the same one you linked in your last comment) shows the maximum number of entries for a few different file systems. Like you said, it doesn't specifically say anywhere that the limit is applied separately for access and default, but in practice, that's the behavior that both you and I have observed. I had been thrown off by the fact that you found different results than I did from testing against a local file system. Now I see the reason for that is you were testing with XFS (max 25 per access and default) and I was testing with ext3 (max 32 per access and default). Now considering all of that, I agree with you that HDFS can make a change so that the limit is enforced separately per access and default. This is backwards-compatible, because it does not reduce the number of ACL entries that can be used in existing deployments already. I'm re-targeting this to 2.8.0 and updating the description to show the new plan. Thank you for the follow-up!
        Hide
        vinayrpet Vinayakumar B added a comment -

        Chris Nauroth, thanks for looking it again.

        Now considering all of that, I agree with you that HDFS can make a change so that the limit is enforced separately per access and default. This is backwards-compatible, because it does not reduce the number of ACL entries that can be used in existing deployments already. I'm re-targeting this to 2.8.0 and updating the description to show the new plan.

        Sure, we can target it for 2.8.0 and work on it.

        Show
        vinayrpet Vinayakumar B added a comment - Chris Nauroth , thanks for looking it again. Now considering all of that, I agree with you that HDFS can make a change so that the limit is enforced separately per access and default. This is backwards-compatible, because it does not reduce the number of ACL entries that can be used in existing deployments already. I'm re-targeting this to 2.8.0 and updating the description to show the new plan. Sure, we can target it for 2.8.0 and work on it.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attached patch which checks the MAX_ENTRIES separately on ACCESS and DEFAULT entries.

        So in total max 64 (32-access and 32 default) entries can be there in an ACL.

        Please review.

        Show
        vinayrpet Vinayakumar B added a comment - Attached patch which checks the MAX_ENTRIES separately on ACCESS and DEFAULT entries. So in total max 64 (32-access and 32 default) entries can be there in an ACL. Please review.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 47s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 43s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 8s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 21s Pre-build of native portion
        -1 hdfs tests 160m 29s Tests failed in hadoop-hdfs.
            203m 48s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735554/HDFS-7582-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cdbd66b
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11138/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11138/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11138/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 21s Pre-build of native portion -1 hdfs tests 160m 29s Tests failed in hadoop-hdfs.     203m 48s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735554/HDFS-7582-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cdbd66b hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11138/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11138/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11138/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Failures are not related.

        Show
        vinayrpet Vinayakumar B added a comment - Failures are not related.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Chris Nauroth, did you get time to check this?
        thanks

        Show
        vinayrpet Vinayakumar B added a comment - Chris Nauroth , did you get time to check this? thanks
        Hide
        hitliuyi Yi Liu added a comment -

        I'm +1 on the late patch based on Chris Nauroth's comment. Chris, would you like to check it too? Thanks.

        Show
        hitliuyi Yi Liu added a comment - I'm +1 on the late patch based on Chris Nauroth 's comment. Chris, would you like to check it too? Thanks.
        Hide
        cnauroth Chris Nauroth added a comment -

        Yi Liu and Vinayakumar B, thanks for moving ahead on this one. I would like to review it, and I apologize for the delay. I just bumped it up in my priority queue, so hopefully I'll get to it no later than next week.

        Show
        cnauroth Chris Nauroth added a comment - Yi Liu and Vinayakumar B , thanks for moving ahead on this one. I would like to review it, and I apologize for the delay. I just bumped it up in my priority queue, so hopefully I'll get to it no later than next week.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks Chris Nauroth. Sure, you can take your time for review.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks Chris Nauroth . Sure, you can take your time for review.
        Hide
        cnauroth Chris Nauroth added a comment -

        Hi Vinayakumar B. Thank you again for your patience. The patch looks good. I found just one thing that needs to be corrected.

            if (defaultEntries.size() > MAX_ENTRIES) {
              throw new AclException("Invalid ACL: ACL has " + accessEntries.size()
                  + " default entries, which exceeds maximum of " + MAX_ENTRIES + ".");
            }
        

        The text of this exception needs to use defaultEntries.size() instead of accessEntries.size().

        Show
        cnauroth Chris Nauroth added a comment - Hi Vinayakumar B . Thank you again for your patience. The patch looks good. I found just one thing that needs to be corrected. if (defaultEntries.size() > MAX_ENTRIES) { throw new AclException( "Invalid ACL: ACL has " + accessEntries.size() + " default entries, which exceeds maximum of " + MAX_ENTRIES + "." ); } The text of this exception needs to use defaultEntries.size() instead of accessEntries.size() .
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks Chris Nauroth for review.
        I will correct the exception text soon.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks Chris Nauroth for review. I will correct the exception text soon.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attaching the updated patch.

        Show
        vinayrpet Vinayakumar B added a comment - Attaching the updated patch.
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for patch v02, pending a fresh Jenkins run. Thank you for the patch, Vinay!

        Show
        cnauroth Chris Nauroth added a comment - +1 for patch v02, pending a fresh Jenkins run. Thank you for the patch, Vinay!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 57s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 31s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 22s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 2s Pre-build of native portion
        -1 hdfs tests 161m 29s Tests failed in hadoop-hdfs.
            204m 45s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746272/HDFS-7582-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / df1e8ce
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11763/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11763/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11763/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11763/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 57s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 2s Pre-build of native portion -1 hdfs tests 161m 29s Tests failed in hadoop-hdfs.     204m 45s   Reason Tests Failed unit tests hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746272/HDFS-7582-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / df1e8ce Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11763/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11763/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11763/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11763/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        test failures are unrelated.

        Committing shortly.

        Show
        vinayrpet Vinayakumar B added a comment - test failures are unrelated. Committing shortly.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks Chris Nauroth for discussions and final reviews.
        Thanks Yi Liu for the review.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks Chris Nauroth for discussions and final reviews. Thanks Yi Liu for the review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8192 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8192/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8192 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8192/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/263/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/263/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #993 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/993/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #993 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/993/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2190/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2190/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #252 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/252/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #252 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/252/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #260 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/260/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #260 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/260/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2209 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2209/)
        HDFS-7582. Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2209 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2209/ ) HDFS-7582 . Enforce maximum number of ACL entries separately per access and default. (Contributed by Vinayakumar B) (vinayakumarb: rev 29cf887b226f4ab3c336a6e681db5e8e70699d66) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclTransformation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclTransformation.java

          People

          • Assignee:
            vinayrpet Vinayakumar B
            Reporter:
            vinayrpet Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development