[HDFS-7567] Potential null dereference in FSEditLogLoader#applyEditLogOp()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Later
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 23/Dec/14 20:41
• Updated: 02/Oct/19 17:15
• Resolved: 24/Jan/15 15:55

Description

      INodeFile oldFile = INodeFile.valueOf(iip.getLastINode(), path, true);
      if (oldFile != null && addCloseOp.overwrite) {
...
      INodeFile newFile = oldFile;
...
      // Update the salient file attributes.
      newFile.setAccessTime(addCloseOp.atime, Snapshot.CURRENT_STATE_ID);
      newFile.setModificationTime(addCloseOp.mtime, Snapshot.CURRENT_STATE_ID);

The last two lines are not protected by null check.

Issue Links

• is related to: HDFS-10729 Improve log message for edit loading failures caused by FS limit checks.