Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7552

change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration

    Details

    • Target Version/s:

      Description

      see https://builds.apache.org/job/PreCommit-HDFS-Build/9088//testReport/org.apache.hadoop.hdfs.server.datanode/TestDataNodeVolumeFailureToleration/testValidVolumesAtStartup/

      Per my understanding, it was due to:

      commit 3b173d95171d01ab55042b1162569d1cf14a8d43
      Author: Colin Patrick Mccabe <cmccabe@cloudera.com>
      Date: Wed Dec 17 16:41:59 2014 -0800

      HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe)

      • volatile List<FsVolumeImpl> volumes = null;
        + private final AtomicReference<FsVolumeImpl[]> volumes =
        + new AtomicReference<>(new FsVolumeImpl[0]);

      so the old case will complain at here:

            assertTrue("The DN should have started with this directory",
                si.contains(dataDir1Actual.getPath()));
      

        Issue Links

          Activity

          Hide
          xieliang007 Liang Xie added a comment -

          Lei (Eddy) Xu Colin P. McCabe Haohui Mai mind taking a look at it? thanks

          Show
          xieliang007 Liang Xie added a comment - Lei (Eddy) Xu Colin P. McCabe Haohui Mai mind taking a look at it? thanks
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thank you so much for the findings, Liang Xie.

          +1 (non-binding)

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thank you so much for the findings, Liang Xie . +1 (non-binding)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688269/HDFS-7552-001.txt
          against trunk revision 6635ccd.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
          org.apache.hadoop.fs.TestSymlinkHdfsFileContext

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9093//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9093//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9093//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688269/HDFS-7552-001.txt against trunk revision 6635ccd. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.fs.TestSymlinkHdfsFileContext Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9093//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9093//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9093//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Liang Xie. Findbugs warnings and test failures are unrelated

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Liang Xie . Findbugs warnings and test failures are unrelated
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6758 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6758/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6758 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6758/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #47 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/47/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #47 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/47/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #781 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/781/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #781 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/781/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1979 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1979/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1979 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1979/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #44 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/44/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #44 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/44/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #48 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/48/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #48 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/48/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1998 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1998/)
          HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1998 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1998/ ) HDFS-7552 . Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe) (cmccabe: rev a4876c130f1627e59ef055e586640d1933fc49af) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.6.1 as HDFS-7531 was. Without this, TestDataNodeVolumeFailureToleration was failing on 2.6.1.

          Patch applies cleanly. Ran compilation and TestDataNodeVolumeFailureToleration before the push.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1 as HDFS-7531 was. Without this, TestDataNodeVolumeFailureToleration was failing on 2.6.1. Patch applies cleanly. Ran compilation and TestDataNodeVolumeFailureToleration before the push.

            People

            • Assignee:
              xieliang007 Liang Xie
              Reporter:
              xieliang007 Liang Xie
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development